GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix manual install by maxkorp · Pull Request #835 · nodegit/nodegit

Conversation

@maxkorp

@maxkorp maxkorp commented Dec 16, 2015

Copy link
Copy Markdown
Collaborator

Fixes an issue where when manuallybuilding after a failed download, "undefined" would sneak in to the arguments for node-gyp. Also updates missing changelog entries (not including 0.5.x) and bumps to 0.6.3

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
maxkorp added 4 commits December 16, 2015 10:01
@maxkorp
fix "undefined" target
08023a7
@maxkorp
update changelog
efeaa0c
@maxkorp
bump version
d099d74
@maxkorp
fix autodeploy on travis
d6618c9
@maxkorp

maxkorp commented Dec 16, 2015

Copy link
Copy Markdown
Collaborator Author

This passed on appveyor the previous commit, and i only changed the travisyml, and travis has passed so I'm merging this. @johnhaley81 reviewed this just to be safe.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
maxkorp added a commit that referenced this pull request Dec 16, 2015
@maxkorp
Merge pull request #835 from nodegit/fix-manual-install
d120199 
Fix manual install
@maxkorp
maxkorp merged commit d120199 into master Dec 16, 2015
@maxkorp
maxkorp deleted the fix-manual-install branch December 16, 2015 17:57
@johnhaley81

johnhaley81 commented Dec 16, 2015

Copy link
Copy Markdown
Collaborator

@maxkorp you missed v0.5.0 in the CHANGELOG.md fyi
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@maxkorp

maxkorp commented Dec 17, 2015

Copy link
Copy Markdown
Collaborator Author

@johnhaley81 you missed my note about that :D

my note about that
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@maxkorp @johnhaley81
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.