GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(sqlite): add `sqlite` subsystem by avivkeller · Pull Request #121 · nodejs/core-validate-commit

Conversation

@avivkeller

@avivkeller avivkeller commented Jul 10, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Ref: nodejs/node#53795 (comment)
Ref: nodejs/node#53752

CC @targos

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@avivkeller
feat(sqlite): add sqlite subsystem
6fc8e29
@avivkeller avivkeller mentioned this pull request Jul 10, 2024
sqlite repo label nodejs/node#53795
Closed
richardlau
richardlau approved these changes Jul 10, 2024
View reviewed changes
tniessen
tniessen approved these changes Jul 10, 2024
View reviewed changes
targos
targos approved these changes Jul 10, 2024
View reviewed changes
@avivkeller

avivkeller commented Jul 16, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Ready to land? This would help with some currently open PRs (such as nodejs/node#53851 and nodejs/node#53900)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jul 17, 2024
src,test: disallow unsafe integer coercion in SQLite nodejs/node#53851
Merged
fix: update subsystem.js #122
Closed
sqlite: support db.loadExtension nodejs/node#53900
Closed
himself65
himself65 approved these changes Jul 17, 2024
View reviewed changes
@avivkeller avivkeller mentioned this pull request Jul 18, 2024
doc, sqlite: add --experimental-sqlite note nodejs/node#53907
Merged
jakecastelli
jakecastelli approved these changes Jul 27, 2024
View reviewed changes
@avivkeller

avivkeller commented Aug 5, 2024

Copy link
Copy Markdown
Member Author

This has seen no objections, can it be merged?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau
richardlau merged commit 87c1bac into nodejs:main Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targos targos targos approved these changes
@tniessen tniessen tniessen approved these changes
@richardlau richardlau richardlau approved these changes
+2 more reviewers
@himself65 himself65 himself65 approved these changes
@jakecastelli jakecastelli jakecastelli approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@avivkeller @targos @tniessen @richardlau @himself65 @jakecastelli
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.