GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc, sqlite: add `--experimental-sqlite` note by avivkeller · Pull Request #53907 · nodejs/node

Conversation

@avivkeller

@avivkeller avivkeller commented Jul 17, 2024

Copy link
Copy Markdown
Member

Fixes #53906

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. sqlite Issues and PRs related to the SQLite subsystem. labels Jul 17, 2024
avivkeller
avivkeller commented Jul 17, 2024
View reviewed changes
Comment thread doc/api/sqlite.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
atlowChemi
atlowChemi approved these changes Jul 17, 2024
View reviewed changes
@avivkeller
doc: add --experimental-sqlite note
ad45109
H4ad
H4ad approved these changes Jul 18, 2024
View reviewed changes
@avivkeller

avivkeller commented Jul 18, 2024

Copy link
Copy Markdown
Member Author

Note that the subsystem is doc, not sqlite, as nodejs/core-validate-commit#121 has not landed yet.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Jul 18, 2024

Copy link
Copy Markdown
Contributor

Note that the subsystem is doc, not sqlite, as nodejs/core-validate-commit#121 has not landed yet.

Even if nodejs/core-validate-commit#121 had landed, we'd want doc: for the subsystem here
H4ad and atlowChemi reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed Jul 18, 2024
View reviewed changes
Comment thread doc/api/sqlite.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@avivkeller
Update sqlite.md
254599d
@avivkeller avivkeller added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Jul 18, 2024
@avivkeller
avivkeller requested a review from aduh95 July 18, 2024 19:25
@avivkeller
Update sqlite.md
29f9bdd
aduh95
aduh95 reviewed Jul 18, 2024
View reviewed changes
Comment thread doc/api/sqlite.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@avivkeller @aduh95
Update doc/api/sqlite.md
4301043 
Co-authored-by: Antoine du Hamel <[email protected]>
aduh95
aduh95 approved these changes Jul 18, 2024
View reviewed changes
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 19, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 19, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 6fc0218 into nodejs:main Jul 19, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 19, 2024

Copy link
Copy Markdown
Collaborator

Landed in 6fc0218
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Jul 28, 2024
@avivkeller @targos
doc: add --experimental-sqlite note
8bf9960 
PR-URL: #53907
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 30, 2024
v22.6.0 proposal #54123
Merged
@targos targos added the dont-land-on-v20.x label Sep 21, 2024
@lheckemann

lheckemann commented Dec 26, 2024

Copy link
Copy Markdown

This doesn't seem to be showing on https://nodejs.org/docs/latest-v23.x/api/sqlite.html -- is something wrong, or am I misunderstanding where it should be?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Dec 26, 2024

Copy link
Copy Markdown
Contributor

@lheckemann SQLite integration was unflagged in #55890, which has landed on latest v23.x. The note is showing on older v23.x releases, e.g. https://nodejs.org/docs/v23.0.0/api/sqlite.html.
lheckemann reacted with thumbs up emoji lheckemann reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@H4ad H4ad H4ad approved these changes
@aduh95 aduh95 aduh95 approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

document that using node:sqlite requires --experimental-sqlite flag

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@avivkeller @aduh95 @nodejs-github-bot @lheckemann @H4ad @atlowChemi @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.