GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update all `gpg --recv-keys` invocations with explicit "did it download" checks by tianon · Pull Request #2252 · nodejs/docker-node

Conversation

@tianon

@tianon tianon commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

This solves for the case of gpg --recv-keys receiving enough valid data that it doesn't return a non-zero exit code, but that it also doesn't import a key by explicitly checking afterwards that it did import the key we asked for (so that the fallback to keyserver.ubuntu.com actually happens appropriately for keys whose UID are no longer validated on keys.openpgp.org).

See also:

  • Unable to fetch Node 22.17.0 release key Release#1110
  • Can no longer validate signatures on NodeJS binaries due to needing approval on keyserver node#58904
  • (especially Can no longer validate signatures on NodeJS binaries due to needing approval on keyserver node#58904 (comment))

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
yosifkit, MikeMcC399, and pas256 reacted with thumbs up emoji
All reactions
  • 👍 3 reactions
@tianon
Update all gpg --recv-keys invocations with explicit "did it downlo…
d78e8df 
…ad" checks

This solves for the case of `gpg --recv-keys` receiving enough valid data that it doesn't return a non-zero exit code, but that it also doesn't import a key by explicitly checking afterwards that it did import the key we asked for (so that the fallback to keyserver.ubuntu.com actually happens appropriately for keys whose UID are no longer validated on keys.openpgp.org).
@tianon

tianon commented Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

(all those "linting" annotations are especially annoying to see here, especially given I'm the author of moby/buildkit#5130 😅)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MikeMcC399

This comment was marked as outdated.

Sign in to view
@MikeMcC399 MikeMcC399 mentioned this pull request Jul 5, 2025
Can no longer validate signatures on NodeJS binaries due to needing approval on keyserver nodejs/node#58904
Closed
@MikeMcC399

MikeMcC399 commented Jul 6, 2025

Copy link
Copy Markdown
Contributor

@tianon

Thanks for proposing this remedy!

I've duplicated it to PR cypress-io/cypress-docker-images#1380 which builds Docker images for Cypress based on selectable versions of Node.js, browser versions, etc. for website testing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@PeterDaveHello
PeterDaveHello requested a review from Copilot July 6, 2025 18:32
PeterDaveHello
PeterDaveHello approved these changes Jul 6, 2025
View reviewed changes

This comment was marked as spam.

Sign in to view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@PeterDaveHello
PeterDaveHello requested a review from a team July 7, 2025 14:58
@PeterDaveHello
PeterDaveHello merged commit 3ac814a into nodejs:main Jul 7, 2025
@github-actions

github-actions Bot commented Jul 7, 2025

Copy link
Copy Markdown

Created PR on the official-images repo (docker-library/official-images#19405). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot mentioned this pull request Jul 7, 2025
Node: Update all gpg --recv-keys invocations with explicit "did it download" checks docker-library/official-images#19405
Merged
@tianon
tianon deleted the fetching-gnupg branch July 7, 2025 20:52
@nschonni nschonni mentioned this pull request Jul 16, 2025
Replace obsolete ENV VAR VALUE with ENV VAR=VALUE #2254
Merged
4 of 12 tasks
chorrell added a commit to chorrell/docker-image-testing-example that referenced this pull request Aug 12, 2025
@chorrell
Update how keys are fetched
50cad2e 
See: nodejs/docker-node#2252
chorrell added a commit to chorrell/docker-image-testing-example that referenced this pull request Aug 12, 2025
@chorrell
Dockerfile-updates (#47)
480d9c6 
* Update how keys are fetched

See: nodejs/docker-node#2252

* Fix Dockerfile linting issues
@MikeMcC399 MikeMcC399 mentioned this pull request Jan 30, 2026
yarn 1.22.22 fails in cypress/factory cypress-io/cypress-docker-images#1469
Closed
@MikeMcC399 MikeMcC399 mentioned this pull request Oct 1, 2026
chore: switch to official release-keys repo to verify Node.js artefacts #2415
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeterDaveHello PeterDaveHello PeterDaveHello approved these changes
@MikeMcC399 MikeMcC399 MikeMcC399 left review comments
Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tianon @MikeMcC399 @PeterDaveHello
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.