GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update instructions in README for onbuild variant by Starefossen · Pull Request #80 · nodejs/docker-node

Conversation

@Starefossen

@Starefossen Starefossen commented Dec 17, 2015

Copy link
Copy Markdown
Member

This PR updates the following parts of the README from docker-library/docs. It may be confusing for users if the docs in this repo and on the official image on Docker Hub are too different.

  • Examples where the onbuild image variant is used
  • Description of the onbuild image variant
  • Supported Docker versions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@chorrell

chorrell commented Dec 17, 2015

Copy link
Copy Markdown
Contributor

LTGM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chorrell

chorrell commented Dec 17, 2015

Copy link
Copy Markdown
Contributor

er, LGTM, heh
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Hans Kristian Flaatten added 2 commits January 13, 2016 23:00
Hans Kristian Flaatten
Update instructions in README for the onbuild variant
f6691b6
Hans Kristian Flaatten
Update supported Docker versions from docker-library/docs
667d7d7
@Starefossen
Starefossen force-pushed the readme-onbuild-update branch from 232a399 to 667d7d7 Compare January 13, 2016 22:01
@Starefossen

Starefossen commented Jan 13, 2016

Copy link
Copy Markdown
Member Author

Rebased with master. Merging.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Starefossen added a commit that referenced this pull request Jan 13, 2016
@Starefossen
Merge pull request #80 from Starefossen/readme-onbuild-update
c8170c3 
Update instructions in README for onbuild variant
@Starefossen
Starefossen merged commit c8170c3 into nodejs:master Jan 13, 2016
@Starefossen Starefossen mentioned this pull request Jan 13, 2016
Discourage use of the onbuild image for production use #66
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Starefossen @chorrell
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.