GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Generic method by emberian · Pull Request #145 · nodejs/http-parser

This repository was archived by the owner on Nov 6, 2022. It is now read-only.

Conversation

@emberian

@emberian emberian commented Dec 16, 2012

Copy link
Copy Markdown
Contributor

Should close up #92 and pave the way for nodejs/node-v0.x-archive#3192. Currently depends on #144 or #106 being merged, because I wasn't paying attention and I don't know how to rebase it. Tests pass, but I'm still not confident in the patch quality. Review desired.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
tomika and others added 8 commits March 24, 2012 10:17
tomika
"status complete" callback added to support Simple-Response handling …
594485c 
…in HTTP version <= 1.0
tomika
"status complete" callback added to support Simple-Response handling …
1d9c1bf 
…in HTTP version <= 1.0
@emberian
Merge remote-tracking branch 'tomika/master' into simple_response
e68c9ea
@emberian
Add tests for @tomika's patch
f1baae5
@emberian
Initial implementation of generic HTTP methods
143202e
@emberian
Fix indentation
c3c2fb0
@emberian
Tweak test (red)
af1b701
@emberian
Try and fix up invalid uri matching
d5cb13b
@emberian

emberian commented Dec 19, 2012

Copy link
Copy Markdown
Contributor Author

I'm having some trouble fixing this one. The parser runs out of data before it actually finds anything invalid. At http_parser.c:1819, the default behaviour seems to be to assume that the request was valid. Mind taking a peek?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@emberian

emberian commented Dec 20, 2012

Copy link
Copy Markdown
Contributor Author

I think adding a bit to http_parser indicating whether, given the current state, the request/response is valid if parsing were to stop immediately is a good solution. Any thoughts before I code it up later today?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kolbyjack
kolbyjack reviewed Dec 20, 2012
View reviewed changes
Comment thread http_parser.c Outdated

This comment was marked as off-topic.

Sign in to view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This comment was marked as off-topic.

Sign in to view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This comment was marked as off-topic.

Sign in to view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
emberian added 3 commits December 20, 2012 14:53
@emberian
Add generic method test
7d7852d 
Reverted a simple test to succeed even though the result is invalid, because
there are other more important things that need doing in this patch (like
getting it to actually work)
@emberian
More proper HTTP_BOTH handling
ff4d643
@emberian
Don't break on long generic method names
6d5f231
@jamesamcl

jamesamcl commented Aug 20, 2013

Copy link
Copy Markdown

Any update on accepting this? I really need support for custom methods but I'd rather not use a fork.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@emberian

emberian commented Aug 20, 2013

Copy link
Copy Markdown
Contributor Author

@udp The patch still doesn't quite work iirc. Want me to pick it back up?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jamesamcl

jamesamcl commented Aug 20, 2013

Copy link
Copy Markdown

That'd be great if you could. I don't mind doing some testing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@emberian

emberian commented Aug 20, 2013

Copy link
Copy Markdown
Contributor Author

alright, I'll get to it later today.

On Tue, Aug 20, 2013 at 6:40 AM, James McLaughlin
[email protected]:

That'd be great if you could. I don't mind doing some testing.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/145#issuecomment-22936106
.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jamesamcl jamesamcl mentioned this pull request Aug 21, 2013
Handling extension methods in a performant way #157
Closed
@mikedeboer

mikedeboer commented Jun 11, 2014

Copy link
Copy Markdown

@cmr to achieve full-spec CalDAV support for our project, mikedeboer/jsDAV, this'd be awesome to have!

I'm guessing more and more ppl will stumble upon this sooner or later, but you'll be my hero to start with ;)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@emberian

emberian commented Jun 11, 2014

Copy link
Copy Markdown
Contributor Author

I'm no longer interested in working on this. Sorry!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@emberian emberian closed this Jun 11, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@emberian @jamesamcl @mikedeboer @kolbyjack @bnoordhuis
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.