GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bundled zlib is missing an upstream UB fix · Issue #41744 · nodejs/node

bundled zlib is missing an upstream UB fix #41744

New issue
Copy link
New issue
Copy link
Closed
Closed
bundled zlib is missing an upstream UB fix#41744
Copy link
Labels
zlibIssues and PRs related to the zlib module and its compression dependencies.Issues and PRs related to the zlib module and its compression dependencies.

Description

@jmatthew
jmatthew
opened on Jan 29, 2022
Issue body actions

Version

v12.22.7

Platform

OpenBSD hostname 7.0 GENERIC.MP#107 amd64

Subsystem

No response

What steps will reproduce the bug?

The bundled zlib is missing this fix: https://chromium.googlesource.com/chromium/src.git/+/e0f88a903fdcb6c772de1929834a73d1662d509a%5E%21/

The consequences of which can be experienced in real life by running pacote.extract("https://registry.npmjs.org/bower/-/bower-1.8.13.tgz", "/tmp/zzzz") on a platform where memcpy() with overlapping source and destination is a fatal error, such as OpenBSD. On OpenBSD, the node process will abort, writing "node: backwards memcpy" to the system logs.

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

No response

What do you see instead?

Welcome to Node.js v12.22.7.
Type ".help" for more information.

const pacote = require('pacote')
undefined
pacote.extract("https://registry.npmjs.org/bower/-/bower-1.8.13.tgz", "/tmp/zzzz");
Promise { }
Abort trap (core dumped)

Additional information

No response

Activity

  1. benjamingr
    added
    zlibIssues and PRs related to the zlib module and its compression dependencies.Issues and PRs related to the zlib module and its compression dependencies.
    on Jan 29, 2022
  2. targos commented on Jan 29, 2022

    @targos
    targos
    on Jan 29, 2022
    Member
    More actions

    Is it related to the error we get with asan in #40238 (comment) ?

  3. jmatthew commented on Jan 29, 2022

    @jmatthew
    jmatthew
    on Jan 29, 2022
    Author
    More actions

    it's the same copy operation that produces that error.

  4. targos
    self-assigned this
    on Jan 29, 2022
  5. targos commented on Jan 29, 2022

    @targos
    targos
    on Jan 29, 2022
    Member
    More actions

    PR to update zlib: #41745

  6. targos
    removed their assignment
    on Feb 4, 2022
  7. MylesBorins commented on Apr 20, 2022

    @MylesBorins
    MylesBorins
    on Apr 20, 2022
    Contributor
    More actions

    Closing as #41745 landed

  8. MylesBorins
    closed this as completedon Apr 20, 2022
  9. MylesBorins commented on Apr 20, 2022

    @MylesBorins
    MylesBorins
    on Apr 20, 2022
    Contributor
    More actions

    nvm I realize that didn't land

  10. MylesBorins
    reopened this on Apr 20, 2022
  11. lpinca commented on Nov 17, 2022

    @lpinca
    lpinca
    on Nov 17, 2022
    Member
    More actions

    Closing as #45387 landed.

  12. lpinca
    closed this as completedon Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    zlibIssues and PRs related to the zlib module and its compression dependencies.Issues and PRs related to the zlib module and its compression dependencies.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.