GeezerVison

Copy link

Copy Markdown

Member

bricss and baparham reacted with thumbs up emoji Neustradamus reacted with heart emoji

lpinca force-pushed the update/zlib branch from 3ff3da2 to 155d705 Compare November 9, 2022 13:54

RafaelGSS approved these changes Nov 9, 2022

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

C:\workspace\node-compile-windows\node\deps\zlib\cpu_features.c(55,1): fatal error C1189: #error:  cpu_features.c CPU feature detection in not defined for your platform [C:\workspace\node-compile-windows\node\deps\zlib\zlib.vcxproj]

lpinca force-pushed the update/zlib branch 2 times, most recently from 5fe09af to 02dfc58 Compare November 10, 2022 09:21

lpinca force-pushed the update/zlib branch from 02dfc58 to 4dca228 Compare November 10, 2022 10:10

lpinca force-pushed the update/zlib branch from 4dca228 to 638653b Compare November 10, 2022 13:21

lpinca force-pushed the update/zlib branch from 638653b to 718b068 Compare November 10, 2022 17:32

Updated as described in doc/contributing/maintaining-zlib.md.

PR-URL: #45387
Reviewed-By: Rafael Gonzaga <[email protected]>

Fix the compile flags so that zlib can run on CPUs that do
not have SSSE3/SSE4.2/etc. Do not compile zlib with flags that
indicate that those features are available, and instead enable
them selectively for functions that use them.

There are probably better way to do this, e.g. through gyp file
modifications as suggested in the issue. However, this patch
should do just fine until that happens.

Fixes: #32553

PR-URL: #32627
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #45387
Reviewed-By: Rafael Gonzaga <[email protected]>

Updated as described in doc/contributing/maintaining-zlib.md.

PR-URL: #45387
Reviewed-By: Rafael Gonzaga <[email protected]>

Fix the compile flags so that zlib can run on CPUs that do
not have SSSE3/SSE4.2/etc. Do not compile zlib with flags that
indicate that those features are available, and instead enable
them selectively for functions that use them.

There are probably better way to do this, e.g. through gyp file
modifications as suggested in the issue. However, this patch
should do just fine until that happens.

Fixes: #32553

PR-URL: #32627
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #45387
Reviewed-By: Rafael Gonzaga <[email protected]>

Updated as described in doc/contributing/maintaining-zlib.md.

PR-URL: #45387
Reviewed-By: Rafael Gonzaga <[email protected]>

Fix the compile flags so that zlib can run on CPUs that do
not have SSSE3/SSE4.2/etc. Do not compile zlib with flags that
indicate that those features are available, and instead enable
them selectively for functions that use them.

There are probably better way to do this, e.g. through gyp file
modifications as suggested in the issue. However, this patch
should do just fine until that happens.

Fixes: #32553

PR-URL: #32627
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #45387
Reviewed-By: Rafael Gonzaga <[email protected]>

Updated as described in doc/contributing/maintaining-zlib.md.

Refs: nodejs#45387 (comment)

Updated as described in doc/contributing/maintaining-zlib.md.

Refs: #45387 (comment)
PR-URL: #47151
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>

Updated as described in doc/contributing/maintaining-zlib.md.

Refs: #45387 (comment)
PR-URL: #47151
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>

Updated as described in doc/contributing/maintaining-zlib.md.

Refs: #45387 (comment)
PR-URL: #47151
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>

Updated as described in doc/contributing/maintaining-zlib.md.

Refs: nodejs#45387 (comment)
PR-URL: nodejs#47151
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>