GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: improve the code in test-fs-access by edsadr · Pull Request #10542 · nodejs/node

Conversation

@edsadr

@edsadr edsadr commented Dec 30, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change
  • use const and let instead of var
  • use common.mustCall to control functions execution
  • use assert.ifError instead of assert.strictEqual for errors
  • use arrow functions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to Node.js core tests and test infrastructure. lts-watch-v6.x labels Dec 30, 2016
@mscdex mscdex added the fs Issues and PRs related to file-system APIs and the fs module. label Dec 30, 2016
jasnell
jasnell approved these changes Dec 30, 2016
View reviewed changes
cjihrig
cjihrig approved these changes Dec 30, 2016
View reviewed changes
lpinca
lpinca reviewed Dec 31, 2016
View reviewed changes
Comment thread test/parallel/test-fs-access.js Outdated

@lpinca lpinca Dec 31, 2016

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: it doesn't harm but I think the use of common.mustCall() is not necessary here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
lpinca
lpinca approved these changes Dec 31, 2016
View reviewed changes
@edsadr
edsadr force-pushed the fs-access branch from f9b1b94 to c34155c Compare December 31, 2016 15:30
@nodejs-github-bot nodejs-github-bot added the lts-watch-v6.x label Dec 31, 2016
@edsadr

edsadr commented Dec 31, 2016

Copy link
Copy Markdown
Contributor Author

@lpinca , did the nit
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca

lpinca commented Dec 31, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5649/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@edsadr
test: improve the code in test-fs-access
43f21c5 
* use const and let instead of var
* use common.mustCall to control functions execution
* use assert.ifError instead of assert.strictEqual for errors
* use arrow functions
@edsadr
edsadr force-pushed the fs-access branch from c34155c to 43f21c5 Compare January 3, 2017 03:11
@nodejs-github-bot nodejs-github-bot added the dont-land-on-v7.x label Jan 3, 2017
@edsadr

edsadr commented Jan 3, 2017

Copy link
Copy Markdown
Contributor Author

solved the conflicts for this one after ff1efa6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Jan 3, 2017
View reviewed changes
@lpinca

lpinca commented Jan 6, 2017

Copy link
Copy Markdown
Member

New CI: https://ci.nodejs.org/job/node-test-pull-request/5722/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca

lpinca commented Jan 6, 2017

Copy link
Copy Markdown
Member

Landed in 6c7219e.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca lpinca closed this Jan 6, 2017
lpinca pushed a commit that referenced this pull request Jan 6, 2017
@edsadr @lpinca
test: improve test-fs-access
6c7219e 
* use const and let instead of var
* use common.mustCall to control functions execution
* use assert.ifError instead of assert.strictEqual for errors
* use arrow functions

PR-URL: #10542
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@lpinca lpinca removed the dont-land-on-v7.x label Jan 7, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@edsadr Italo A. Casas
test: improve test-fs-access
9d302ae 
* use const and let instead of var
* use common.mustCall to control functions execution
* use assert.ifError instead of assert.strictEqual for errors
* use arrow functions

PR-URL: nodejs#10542
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 19, 2017
@edsadr Italo A. Casas
test: improve test-fs-access
649af4c 
* use const and let instead of var
* use common.mustCall to control functions execution
* use assert.ifError instead of assert.strictEqual for errors
* use arrow functions

PR-URL: nodejs#10542
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Proposal to update v7.x-staging #10989
Closed
targos pushed a commit that referenced this pull request Jan 28, 2017
@edsadr @targos
test: improve test-fs-access
e748adb 
* use const and let instead of var
* use common.mustCall to control functions execution
* use assert.ifError instead of assert.strictEqual for errors
* use arrow functions

PR-URL: #10542
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
v7.5.0 proposal #11062
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@edsadr Italo A. Casas
test: improve test-fs-access
b1c742e 
* use const and let instead of var
* use common.mustCall to control functions execution
* use assert.ifError instead of assert.strictEqual for errors
* use arrow functions

PR-URL: nodejs#10542
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@edsadr Italo A. Casas
test: improve test-fs-access
b7745e5 
* use const and let instead of var
* use common.mustCall to control functions execution
* use assert.ifError instead of assert.strictEqual for errors
* use arrow functions

PR-URL: nodejs#10542
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 13, 2017
@edsadr @MylesBorins
test: improve test-fs-access
b85d15f 
* use const and let instead of var
* use common.mustCall to control functions execution
* use assert.ifError instead of assert.strictEqual for errors
* use arrow functions

PR-URL: #10542
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins added the land-on-v6.x label Apr 13, 2017
@MylesBorins MylesBorins removed the lts-watch-v6.x label Apr 13, 2017
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@edsadr @MylesBorins
test: improve test-fs-access
f064520 
* use const and let instead of var
* use common.mustCall to control functions execution
* use assert.ifError instead of assert.strictEqual for errors
* use arrow functions

PR-URL: #10542
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
v6.10.3 proposal #12498
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@edsadr @andrew749
test: improve test-fs-access
215dfec 
* use const and let instead of var
* use common.mustCall to control functions execution
* use assert.ifError instead of assert.strictEqual for errors
* use arrow functions

PR-URL: nodejs/node#10542
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fs Issues and PRs related to file-system APIs and the fs module. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@edsadr @lpinca @jasnell @cjihrig @mscdex @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.