GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: clarify memory sharing behavior of buffer ctor by zbjornson · Pull Request #10778 · nodejs/node

Conversation

@zbjornson

@zbjornson zbjornson commented Jan 13, 2017

Copy link
Copy Markdown
Contributor
  • Clarify that memory is always shared and never copied.
  • Fix wording that sounded like ArrayBuffer has a buffer property.

Fixes #10770

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

docs (buffer)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zbjornson
doc: clarify memory sharing behavior of buffer ctor
214471c 
* Clarify that memory is always shared and never copied.
* Fix wording that sounded like ArrayBuffer has a buffer property.

Fixes nodejs#10770
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to Node.js documentation. lts-watch-v6.x labels Jan 13, 2017
lpinca
lpinca approved these changes Jan 13, 2017
View reviewed changes
jasnell
jasnell approved these changes Jan 13, 2017
View reviewed changes
@italoacasas

italoacasas commented Jan 16, 2017

Copy link
Copy Markdown

Landed 5ab910e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@italoacasas italoacasas closed this Jan 16, 2017
italoacasas pushed a commit that referenced this pull request Jan 16, 2017
@zbjornson Italo A. Casas
doc: clarify memory sharing behavior of buffer ctor
5ab910e 
* Clarify that memory is always shared and never copied.
* Fix wording that sounded like ArrayBuffer has a buffer property.

PR-URL: #10778
Ref: #10770
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@zbjornson
zbjornson deleted the 10770-arraybuff-docs branch January 16, 2017 21:40
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@zbjornson Italo A. Casas
doc: clarify memory sharing behavior of buffer ctor
90c8204 
* Clarify that memory is always shared and never copied.
* Fix wording that sounded like ArrayBuffer has a buffer property.

PR-URL: nodejs#10778
Ref: nodejs#10770
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
@zbjornson Italo A. Casas
doc: clarify memory sharing behavior of buffer ctor
3735682 
* Clarify that memory is always shared and never copied.
* Fix wording that sounded like ArrayBuffer has a buffer property.

PR-URL: nodejs#10778
Ref: nodejs#10770
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 24, 2017
@zbjornson Italo A. Casas
doc: clarify memory sharing behavior of buffer ctor
3a58d43 
* Clarify that memory is always shared and never copied.
* Fix wording that sounded like ArrayBuffer has a buffer property.

PR-URL: nodejs#10778
Ref: nodejs#10770
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Proposal to update v7.x-staging #10989
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@zbjornson Italo A. Casas
doc: clarify memory sharing behavior of buffer ctor
73939ec 
* Clarify that memory is always shared and never copied.
* Fix wording that sounded like ArrayBuffer has a buffer property.

PR-URL: nodejs#10778
Ref: nodejs#10770
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
v7.5.0 proposal #11062
Merged
@MylesBorins

MylesBorins commented Mar 7, 2017

Copy link
Copy Markdown
Contributor

Should this be backported?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zbjornson

zbjornson commented Mar 14, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@MylesBorins it would correctly describe v6 if backported, so seems like it should be (although I don't know the backporting policy). v4.x has clear language; the unclear language was introduced in ac57089 (which was not backported).
gibfahn reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins MylesBorins added land-on-v6.x and removed lts-watch-v6.x labels Apr 13, 2017
MylesBorins pushed a commit that referenced this pull request Apr 13, 2017
@zbjornson @MylesBorins
doc: clarify memory sharing behavior of buffer ctor
a6ab9f2 
* Clarify that memory is always shared and never copied.
* Fix wording that sounded like ArrayBuffer has a buffer property.

PR-URL: #10778
Ref: #10770
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@zbjornson @MylesBorins
doc: clarify memory sharing behavior of buffer ctor
4fd765e 
* Clarify that memory is always shared and never copied.
* Fix wording that sounded like ArrayBuffer has a buffer property.

PR-URL: #10778
Ref: #10770
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
v6.10.3 proposal #12498
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@zbjornson @andrew749
doc: clarify memory sharing behavior of buffer ctor
71f2519 
* Clarify that memory is always shared and never copied.
* Fix wording that sounded like ArrayBuffer has a buffer property.

PR-URL: nodejs/node#10778
Ref: nodejs/node#10770
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@zbjornson @italoacasas @MylesBorins @jasnell @lpinca @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.