GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — 7.x backport: crypto: support OPENSSL_CONF again (and its dependencies) by sam-github · Pull Request #11345 · nodejs/node

Conversation

@sam-github

@sam-github sam-github commented Feb 13, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Backport of:

  • crypto: support OPENSSL_CONF again #11006
  • src: fix recent --icu-data-dir= regression #11255
  • src: make copies of startup environment variables #11051
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

LinusU reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. i18n-api Issues and PRs related to Node.js internationalization support. process Issues and PRs related to the process subsystem. v7.x labels Feb 13, 2017
@sam-github

sam-github commented Feb 13, 2017

Copy link
Copy Markdown
Contributor Author

/to @italoacasas @bnoordhuis
/cc @gibfahn @mhdawson

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sam-github

sam-github commented Feb 13, 2017

Copy link
Copy Markdown
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/6380/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@italoacasas

italoacasas commented Feb 13, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

thanks @sam-github, I would like to fast-track this backport, potentially landing this tomorrow that way we can include this in the RC. Thoughts?

gibfahn reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sam-github sam-github mentioned this pull request Feb 13, 2017
Proposal - 7.6.0 (Current) #11185
Merged
@sam-github

sam-github commented Feb 13, 2017

Copy link
Copy Markdown
Contributor Author

Agree on fast-tracking.

I didn't think the 48 hour delay applied to backports, but we should get a review by @bnoordhuis soon, or perhaps @jasnell can review these?

The reason they didn't cherrypick clean is that #11051 touched a CLI switch that was only introduced in #10116 (which is semver-major). I just removed the part of the commit that touch the switch that doesn't exist in 7.x.

italoacasas reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bnoordhuis
bnoordhuis approved these changes Feb 13, 2017
View reviewed changes
@sam-github sam-github mentioned this pull request Feb 14, 2017
7.x backport: crypto: support OPENSSL_CONF again (and its dependencies) #11344
Closed
4 tasks
@italoacasas
italoacasas force-pushed the v7.x-staging branch from ac72c3e to 2f1ce29 Compare February 14, 2017 17:31
@gibfahn

gibfahn commented Feb 15, 2017

Copy link
Copy Markdown
Member

I assume v7.x-staging got rebased, this PR now has 110 commits. Could you rebase @sam-github ?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@italoacasas

italoacasas commented Feb 15, 2017

Copy link
Copy Markdown

This is my bad, I had to force push to remove some commits with specs issues.

gibfahn reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gibfahn

gibfahn commented Feb 15, 2017

Copy link
Copy Markdown
Member

@italoacasas I think that's pretty much unavoidable with the number of commits you're juggling.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bnoordhuis and others added 5 commits February 16, 2017 09:06
@bnoordhuis @sam-github
src: make copies of startup environment variables
dcdebc3
Mutations of the environment can invalidate pointers to environment
variables, so make `secure_getenv()` copy them out instead of returning
pointers.

PR-URL: nodejs#11051
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
@bnoordhuis @sam-github
src: make --icu-data-dir= switch testable
ce10b06
Move some code around so we can properly test whether the switch
actually does anything.

PR-URL: nodejs#11255
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
@bnoordhuis @sam-github
src: fix --icu-data-dir= regression
d0b9c34
Commit a8734af ("src: make copies of startup environment variables")
from two weeks ago introduced a regression in the capturing of the
`--icu-data-dir=` switch: it captured the string up to the `=` instead
of what comes after it.

PR-URL: nodejs#11255
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
@sam-github
src: add SafeGetenv() to internal API
dc77c6e
Allow it to be used anywhere in src/ that env variables with security
implications are accessed.

PR-URL: nodejs#11006
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@sam-github
crypto: support OPENSSL_CONF again
a3bf4a2
A side-effect of https://github.com/nodejs/node-private/pull/82
was to remove support for OPENSSL_CONF, as well as removing the default
read of a configuration file on startup.

Partly revert this, allowing OPENSSL_CONF to be used to specify a
configuration file to read on startup, but do not read a file by
default.

If the --openssl-config command line option is provided, its value is
used, not the OPENSSL_CONF environment variable.

Fix: nodejs#10938
PR-URL: nodejs#11006
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@sam-github
sam-github force-pushed the backport-pr-11051-11255-11006 branch from 4f98413 to a3bf4a2 Compare February 16, 2017 17:07
@sam-github

sam-github commented Feb 16, 2017

Copy link
Copy Markdown
Contributor Author

rebased

btw, will be without internet connection from this afternoon, until Sunday morning

also, @italoacasas I don't quite understand why I needed to rebase, the changes all cherry-pick clean I think, based on the fact that the rebase was completely conflict free

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sam-github

sam-github commented Feb 16, 2017

Copy link
Copy Markdown
Contributor Author

@italoacasas which means I can help with anything for the next 5 hours, but not after

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@italoacasas

italoacasas commented Feb 16, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Moving this to staging right now

sam-github reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@italoacasas

italoacasas commented Feb 16, 2017

Copy link
Copy Markdown

Landed in v7-staging. Thanks for the help @sam-github

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@italoacasas italoacasas closed this Feb 16, 2017
@sam-github sam-github added dont-land-on-v4.x labels Feb 27, 2017
@sam-github sam-github added lts-watch-v6.x semver-minor PRs that contain new features and should be released in the next minor version. and removed lts-watch-v4.x labels Feb 27, 2017
@sam-github

sam-github commented Feb 27, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@nodejs/lts I request acceptance for 6.x, it isn't meaningful for 4.x, which still respects OPENSSL_CONF

It doesn't land clean on 6.x, I am backporting.

EDIT: backported: #11583

gibfahn reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sam-github sam-github mentioned this pull request Feb 27, 2017
6.x backport: crypto: support OPENSSL_CONF again (and its dependencies) #11583
Closed
4 tasks
@sam-github
sam-github deleted the backport-pr-11051-11255-11006 branch April 17, 2017 20:36
@MylesBorins MylesBorins removed the lts-watch-v6.x label May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. i18n-api Issues and PRs related to Node.js internationalization support. process Issues and PRs related to the process subsystem. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@sam-github @italoacasas @gibfahn @bnoordhuis @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.