GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — console: fixup `console.dir()` error handling by addaleax · Pull Request #11443 · nodejs/node

Conversation

@addaleax

@addaleax addaleax commented Feb 17, 2017

Copy link
Copy Markdown
Member

Apply the console: do not emit error events changes properly to console.dir().

This was overlooked in f18e08d (#9744).

Ref: f18e08d#commitcomment-20934407

/cc @Fishrock123

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

console

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@addaleax
console: fixup console.dir() error handling
b13d561 
Apply the `console: do not emit error events` changes properly
to `console.dir()`.

This was overlooked in f18e08d
(nodejs#9744).

Ref: nodejs@f18e08d#commitcomment-20934407
@addaleax addaleax added console Issues and PRs related to the console subsystem. dont-land-on-v4.x labels Feb 17, 2017
@nodejs-github-bot nodejs-github-bot added the console Issues and PRs related to the console subsystem. label Feb 17, 2017
@addaleax

addaleax commented Feb 17, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/7982/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Feb 17, 2017
View reviewed changes
@addaleax

addaleax commented Feb 21, 2017

Copy link
Copy Markdown
Member Author

Landed in c969047
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Feb 21, 2017
@addaleax
addaleax deleted the console-no-errors2-fixup branch February 21, 2017 15:53
addaleax added a commit that referenced this pull request Feb 21, 2017
@addaleax
console: fixup console.dir() error handling
c969047 
Apply the `console: do not emit error events` changes properly
to `console.dir()`.

This was overlooked in f18e08d
(#9744).

Ref: f18e08d#commitcomment-20934407
PR-URL: #11443
Reviewed-By: James M Snell <[email protected]>
@jasnell jasnell mentioned this pull request Apr 4, 2017
8.0.0 Release Proposal #12220
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

console Issues and PRs related to the console subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@addaleax @jasnell @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.