GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix typo in STYLE_GUIDE.md by seishun · Pull Request #11615 · nodejs/node

Conversation

@seishun

@seishun seishun commented Feb 28, 2017

Copy link
Copy Markdown
Contributor

parenthesis is singular, parentheses is plural.

Checklist
Affected core subsystem(s)

doc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@seishun
doc: fix typo in STYLE_GUIDE.md
49eff51
addaleax
addaleax approved these changes Feb 28, 2017
View reviewed changes

@addaleax addaleax left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think it’s safe to say that this doesn’t need to wait 48 hours

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
cjihrig
cjihrig approved these changes Feb 28, 2017
View reviewed changes
@addaleax addaleax added the doc Issues and PRs related to Node.js documentation. label Feb 28, 2017
@seishun
seishun merged commit 0a44b71 into master Feb 28, 2017
@seishun
seishun deleted the style-fix branch February 28, 2017 18:00
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Feb 28, 2017
addaleax pushed a commit that referenced this pull request Mar 5, 2017
@seishun @addaleax
doc: fix typo in STYLE_GUIDE.md
11aea26 
PR-URL: #11615
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@evanlucas evanlucas mentioned this pull request Mar 8, 2017
v7.7.2 proposal #11745
Merged
MylesBorins pushed a commit that referenced this pull request Apr 17, 2017
@seishun @MylesBorins
doc: fix typo in STYLE_GUIDE.md
dcf20bc 
PR-URL: #11615
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins added the land-on-v6.x label Apr 17, 2017
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@seishun @MylesBorins
doc: fix typo in STYLE_GUIDE.md
6c3b104 
PR-URL: #11615
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
v6.10.3 proposal #12498
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@seishun @andrew749
doc: fix typo in STYLE_GUIDE.md
d060902 
PR-URL: nodejs/node#11615
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@cjihrig cjihrig cjihrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@seishun @addaleax @cjihrig @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.