GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — lib: removed unused msg parameter in debug_agent by mr-spd · Pull Request #11833 · nodejs/node

Conversation

@mr-spd

@mr-spd mr-spd commented Mar 13, 2017

Copy link
Copy Markdown
Contributor

Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

lib

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot nodejs-github-bot added the debugger label Mar 13, 2017
jasnell
jasnell approved these changes Mar 13, 2017
View reviewed changes
@gibfahn

gibfahn commented Mar 13, 2017

Copy link
Copy Markdown
Member

Minor nit: could you change removed->remove in the commit message?

See the Contributing Guidelines for more info.

Someone can do this on landing if you don't have time.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

danbev
danbev approved these changes Mar 13, 2017
View reviewed changes
@mr-spd
lib: remove unused msg parameter in debug_agent
068c8b4
Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.
@mr-spd
mr-spd force-pushed the unused_parameter branch from 37384a5 to 068c8b4 Compare March 13, 2017 19:19
gibfahn
gibfahn approved these changes Mar 13, 2017
View reviewed changes

@gibfahn gibfahn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
cjihrig
cjihrig approved these changes Mar 13, 2017
View reviewed changes
hiroppy
hiroppy approved these changes Mar 14, 2017
View reviewed changes
@JacksonTian

JacksonTian commented Mar 14, 2017

Copy link
Copy Markdown
Contributor

LGTM

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hiroppy

hiroppy commented Mar 14, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/6831/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fhinkel
fhinkel approved these changes Mar 15, 2017
View reviewed changes
@fhinkel

fhinkel commented Mar 15, 2017 •
edited by gibfahn
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Thanks. Landed in 5bd1642

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@fhinkel fhinkel closed this Mar 15, 2017
fhinkel pushed a commit that referenced this pull request Mar 15, 2017
@mr-spd @fhinkel
lib: remove unused msg parameter in debug_agent
5bd1642
Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.

PR-URL: #11833
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Jackson Tian <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 20, 2017
@mr-spd Italo A. Casas
lib: remove unused msg parameter in debug_agent
9cc712c
Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.

PR-URL: nodejs#11833
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Jackson Tian <[email protected]>
@italoacasas italoacasas mentioned this pull request Mar 20, 2017
v7.7.4 Release Proposal #11941
Merged
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
@mr-spd @jungx098
lib: remove unused msg parameter in debug_agent
f1ebeed
Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.

PR-URL: nodejs#11833
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Jackson Tian <[email protected]>
@MylesBorins MylesBorins added the land-on-v6.x label Apr 18, 2017
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
@mr-spd @MylesBorins
lib: remove unused msg parameter in debug_agent
8068d3f
Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.

PR-URL: #11833
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Jackson Tian <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@mr-spd @MylesBorins
lib: remove unused msg parameter in debug_agent
f8426d9
Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.

PR-URL: #11833
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Jackson Tian <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
v6.10.3 proposal #12498
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@mr-spd @andrew749
lib: remove unused msg parameter in debug_agent
453f1b3
Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.

PR-URL: nodejs/node#11833
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Jackson Tian <[email protected]>
This was referenced Mar 7, 2020
[Snyk] Security upgrade eslint from 3.19.0 to 6.0.0 adamlaska/node#11
Open
[Snyk] Fix for 1 vulnerabilities adamlaska/node#12
Open
[Snyk] Fix for 1 vulnerabilities adamlaska/node#14
Open
[Snyk] Fix for 1 vulnerabilities adamlaska/node#15
Open
[Snyk] Fix for 1 vulnerabilities adamlaska/node#16
Open
[Snyk] Fix for 1 vulnerabilities adamlaska/node#17
Open
@adamlaska adamlaska mentioned this pull request Nov 30, 2023
[Snyk] Security upgrade eslint from 5.16.0 to 6.0.0 adamlaska/node#125
Open
@aliscco aliscco mentioned this pull request Dec 1, 2023
[Snyk] Fix for 1 vulnerabilities aliscco/alisco-node#962
Open
@leonardoadame leonardoadame mentioned this pull request Dec 1, 2023
[Snyk] Fix for 1 vulnerabilities leonardoadame/node#377
Open
This was referenced Dec 1, 2023
[Snyk] Security upgrade eslint from 4.19.1 to 6.0.0 aliscco/alisco-node#966
Open
[Snyk] Security upgrade eslint from 4.18.2 to 6.0.0 aliscco/alisco-node#968
Open
This was referenced Dec 1, 2023
[Snyk] Security upgrade eslint from 4.19.1 to 6.0.0 leonardoadame/node#391
Open
[Snyk] Fix for 1 vulnerabilities leonardoadame/node#397
Open
This was referenced Dec 1, 2023
[Snyk] Fix for 1 vulnerabilities aliscco/alisco-node#1001
Open
[Snyk] Security upgrade eslint from 4.19.1 to 6.0.0 aliscco/alisco-node#1012
Open
@adamlaska adamlaska mentioned this pull request Dec 2, 2023
[Snyk] Fix for 1 vulnerabilities adamlaska/node#132
Open
@aliscco aliscco mentioned this pull request Dec 2, 2023
[Snyk] Fix for 1 vulnerabilities aliscco/alisco-node#1015
Open
@leonardoadame leonardoadame mentioned this pull request Dec 2, 2023
[Snyk] Security upgrade eslint from 5.16.0 to 6.0.0 leonardoadame/node#426
Open
This was referenced Dec 2, 2023
[Snyk] Fix for 1 vulnerabilities aliscco/alisco-node#1019
Open
[Snyk] Security upgrade eslint from 4.12.1 to 6.0.0 aliscco/alisco-node#1025
Open
[Snyk] Fix for 1 vulnerabilities aliscco/alisco-node#1027
Open
[Snyk] Fix for 11 vulnerabilities aliscco/alisco-node#1036
Open
@leonardoadame leonardoadame mentioned this pull request Dec 2, 2023
[Snyk] Security upgrade eslint from 4.12.1 to 6.0.0 leonardoadame/node#445
Open
This was referenced Dec 2, 2023
[Snyk] Security upgrade eslint from 2.13.1 to 6.0.0 aliscco/alisco-node#1040
Open
[Snyk] Fix for 6 vulnerabilities aliscco/alisco-node#1050
Open
[Snyk] Fix for 1 vulnerabilities aliscco/alisco-node#1053
Open
This was referenced Dec 2, 2023
[Snyk] Fix for 1 vulnerabilities leonardoadame/node#453
Open
[Snyk] Security upgrade eslint from 5.7.0 to 6.0.0 leonardoadame/node#455
Open
This was referenced Dec 2, 2023
[Snyk] Fix for 2 vulnerabilities aliscco/alisco-node#1066
Open
[Snyk] Security upgrade eslint from 4.19.1 to 6.0.0 aliscco/alisco-node#1067
Open
This was referenced Dec 3, 2023
[Snyk] Fix for 1 vulnerabilities leonardoadame/node#477
Open
[Snyk] Fix for 1 vulnerabilities leonardoadame/node#478
Open
[Snyk] Security upgrade eslint from 4.19.1 to 6.0.0 leonardoadame/node#493
Open
@aliscco aliscco mentioned this pull request Dec 3, 2023
[Snyk] Fix for 7 vulnerabilities aliscco/alisco-node#1097
Open
@leonardoadame leonardoadame mentioned this pull request Dec 3, 2023
[Snyk] Security upgrade eslint from 4.18.2 to 6.0.0 leonardoadame/node#505
Open
@aliscco aliscco mentioned this pull request Dec 3, 2023
[Snyk] Security upgrade eslint from 5.16.0 to 6.0.0 aliscco/alisco-node#1124
Open
@leonardoadame leonardoadame mentioned this pull request Dec 5, 2023
[Snyk] Fix for 1 vulnerabilities leonardoadame/node#543
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
+4 more reviewers
@fhinkel fhinkel fhinkel approved these changes
@danbev danbev danbev approved these changes
@hiroppy hiroppy hiroppy approved these changes
@gibfahn gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@mr-spd @gibfahn @JacksonTian @hiroppy @fhinkel @danbev @jasnell @cjihrig @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.