GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: add second argument to assert.throws() by rjbernaldo · Pull Request #12016 · nodejs/node

Conversation

@rjbernaldo

@rjbernaldo rjbernaldo commented Mar 24, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Adds a second argument to the assert.throws() test to implicitly specify
expected error message.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Mar 24, 2017
@mscdex mscdex added the util Issues and PRs related to the built-in util module. label Mar 24, 2017
@mscdex

mscdex commented Mar 24, 2017

Copy link
Copy Markdown
Contributor

This commit's message should use the test: prefix instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rjbernaldo
test: add second argument to assert.throws()
129ae01 
Adds a second argument to the assert.throws() test to implicitly specify
expected error message.
@rjbernaldo
rjbernaldo force-pushed the first-commit-fix-test branch from cc929cb to 129ae01 Compare March 24, 2017 08:28
@rjbernaldo rjbernaldo changed the title util: add second argument to assert.throws() test test: add second argument to assert.throws() Mar 24, 2017
targos
targos approved these changes Mar 24, 2017
View reviewed changes
@vsemozhetbyt

vsemozhetbyt commented Mar 24, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/7016/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vsemozhetbyt
vsemozhetbyt approved these changes Mar 24, 2017
View reviewed changes
cjihrig
cjihrig approved these changes Mar 24, 2017
View reviewed changes
richardlau
richardlau approved these changes Mar 24, 2017
View reviewed changes
jasnell
jasnell approved these changes Mar 24, 2017
View reviewed changes
addaleax
addaleax approved these changes Mar 24, 2017
View reviewed changes
Trott
Trott approved these changes Mar 24, 2017
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI failure is unrelated.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
fhinkel
fhinkel approved these changes Mar 26, 2017
View reviewed changes
fhinkel
fhinkel approved these changes Mar 26, 2017
View reviewed changes
@fhinkel

fhinkel commented Mar 26, 2017

Copy link
Copy Markdown
Contributor

Landed in 1377d5a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@fhinkel fhinkel closed this Mar 26, 2017
fhinkel pushed a commit that referenced this pull request Mar 26, 2017
@rjbernaldo @fhinkel
test: add second argument to assert.throws()
1377d5a 
Adds a second argument to the assert.throws() test to implicitly specify
expected error message.

PR-URL: #12016
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
@rjbernaldo @MylesBorins
test: add second argument to assert.throws()
a73dea9 
Adds a second argument to the assert.throws() test to implicitly specify
expected error message.

PR-URL: #12016
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 28, 2017
V7.8.0 proposal #12104
Merged
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
v7.9.0 Release Proposal #12319
Merged
2 tasks done
@MylesBorins MylesBorins added the land-on-v6.x label Apr 18, 2017
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
@rjbernaldo @MylesBorins
test: add second argument to assert.throws()
b73b761 
Adds a second argument to the assert.throws() test to implicitly specify
expected error message.

PR-URL: #12016
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@rjbernaldo @MylesBorins
test: add second argument to assert.throws()
fcc19e1 
Adds a second argument to the assert.throws() test to implicitly specify
expected error message.

PR-URL: #12016
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
v6.10.3 proposal #12498
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@rjbernaldo @andrew749
test: add second argument to assert.throws()
9c7840a 
Adds a second argument to the assert.throws() test to implicitly specify
expected error message.

PR-URL: nodejs/node#12016
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@addaleax addaleax addaleax approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes
+3 more reviewers
@fhinkel fhinkel fhinkel approved these changes
@targos targos targos approved these changes
@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

test Issues and PRs related to Node.js core tests and test infrastructure. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

12 participants

@rjbernaldo @mscdex @vsemozhetbyt @fhinkel @jasnell @Trott @addaleax @targos @cjihrig @richardlau @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.