GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add logo to README by silverwind · Pull Request #12148 · nodejs/node

Conversation

@silverwind

@silverwind silverwind commented Mar 31, 2017

Copy link
Copy Markdown
Contributor
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Description

Added a centered SVG logo to the README to make it a little more festive. As centering is not possible in pure Markdown, I had to use a bit of HTML.

Ref: #6920

Preview

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
merraysy, lpinca, jyotman, and aqrln reacted with thumbs up emoji jyotman and watilde reacted with hooray emoji aqrln and erulabs reacted with heart emoji
All reactions
  • 👍 4 reactions
  • 🎉 2 reactions
  • ❤️ 2 reactions
@silverwind
doc: add logo to README
0a4f13d
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Mar 31, 2017
@silverwind silverwind mentioned this pull request Mar 31, 2017
doc: intent to restructure README.md to be more advertising and introducing to docs #6920
Closed
gibfahn
gibfahn approved these changes Mar 31, 2017
View reviewed changes

@gibfahn gibfahn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
lpinca
lpinca approved these changes Mar 31, 2017
View reviewed changes
addaleax
addaleax approved these changes Mar 31, 2017
View reviewed changes
@addaleax

addaleax commented Mar 31, 2017

Copy link
Copy Markdown
Member

You made that SVG, right? Have you considered uploading it as a newer/better version of https://en.wikipedia.org/wiki/File:Node.js_logo.svg?
lpinca, gibfahn, and jasnell reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Mar 31, 2017
View reviewed changes
jasnell
jasnell approved these changes Mar 31, 2017
View reviewed changes
italoacasas
italoacasas approved these changes Mar 31, 2017
View reviewed changes
cjihrig
cjihrig approved these changes Mar 31, 2017
View reviewed changes
@TimothyGu

TimothyGu commented Mar 31, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@addaleax the logos are all in https://github.com/nodejs/nodejs.org/blob/master/static/images/. The Illustrator files from which SVGs can be generated, are from Amanda Cohen by way of @gtewallace (ref nodejs/evangelism#179).
addaleax reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TimothyGu
TimothyGu reviewed Mar 31, 2017
View reviewed changes
Comment thread README.md Outdated
[![Gitter](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/nodejs/node?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) [![CII Best Practices](https://bestpractices.coreinfrastructure.org/projects/29/badge)](https://bestpractices.coreinfrastructure.org/projects/29)
<p align="center">
<a href="https://nodejs.org/">
<img src="https://nodejs.org/static/images/logo-light.svg" width="400" />

@TimothyGu TimothyGu Mar 31, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alt attribute seems appropriate here for screen readers (ditto below).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Trott Trott Apr 1, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, should have an alt attribute and it should probably be empty: alt=""

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@silverwind silverwind Apr 1, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not alt="Node.js logo"?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax and gibfahn reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

@Trott Trott Apr 1, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should follow guidance of things like http://webaim.org/techniques/alttext/#logos. "Node.js home page" is probably what we want per that doc. Specifically, the alt text should likely not contain the word "logo".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@silverwind silverwind Apr 1, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll just go with alt="Node.js" and remove the link on the logo as there are already multiple links in the document that link to the homepage.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
hiroppy
hiroppy approved these changes Apr 1, 2017
View reviewed changes
@ghost

ghost commented Apr 1, 2017

Copy link
Copy Markdown

Good idea
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@silverwind

silverwind commented Apr 1, 2017

Copy link
Copy Markdown
Contributor Author

@addaleax updated the image on Wikimedia.
addaleax and gibfahn reacted with hooray emoji
All reactions
  • 🎉 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@silverwind
add alt attribute and remove link from logo
07ef63b
@silverwind

silverwind commented Apr 2, 2017

Copy link
Copy Markdown
Contributor Author

Landed in 2d039ff 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@silverwind silverwind closed this Apr 2, 2017
silverwind added a commit that referenced this pull request Apr 2, 2017
@silverwind
doc: add logo to README
2d039ff 
Adds a centered logo to the README to make it a little more festive. As
centering is not possible in pure Markdown, a bit of HTML is used.

PR-URL: #12148
Ref: #6920
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@silverwind

silverwind commented Apr 3, 2017

Copy link
Copy Markdown
Contributor Author

I noticed that GitHub's Markdown renderer did wrap the logo in a <a> tag linking to the image source. Probably better to add our own <a> to override that.
Trott, gibfahn, and 1j01 reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell mentioned this pull request Apr 4, 2017
8.0.0 Release Proposal #12220
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Apr 10, 2017
@silverwind Italo A. Casas
doc: add logo to README
b5283f9 
Adds a centered logo to the README to make it a little more festive. As
centering is not possible in pure Markdown, a bit of HTML is used.

PR-URL: nodejs#12148
Ref: nodejs#6920
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
v7.9.0 Release Proposal #12319
Merged
2 tasks done
@MylesBorins MylesBorins added dont-land-on-v6.x labels Apr 18, 2017
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
@silverwind @MylesBorins
doc: add logo to README
b5c9c12 
Adds a centered logo to the README to make it a little more festive. As
centering is not possible in pure Markdown, a bit of HTML is used.

PR-URL: #12148
Ref: #6920
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@silverwind @MylesBorins
doc: add logo to README
d007427 
Adds a centered logo to the README to make it a little more festive. As
centering is not possible in pure Markdown, a bit of HTML is used.

PR-URL: #12148
Ref: #6920
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
v6.10.3 proposal #12498
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@silverwind @andrew749
doc: add logo to README
74a990f 
Adds a centered logo to the README to make it a little more festive. As
centering is not possible in pure Markdown, a bit of HTML is used.

PR-URL: nodejs/node#12148
Ref: nodejs/node#6920
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Italo A. Casas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott left review comments
@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes
+4 more reviewers
@TimothyGu TimothyGu TimothyGu left review comments
@hiroppy hiroppy hiroppy approved these changes
@italoacasas italoacasas italoacasas approved these changes
@gibfahn gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

13 participants

@silverwind @addaleax @TimothyGu @jasnell @Trott @lpinca @cjihrig @hiroppy @richardlau @italoacasas @gibfahn @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.