GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||
GeezerVison is showing github.com — doc: Stream 'finish' event string interpolation fix by vhmth · Pull Request #12221 · nodejs/node Conversation
Contributor
Checklist
Affected core subsystem(s)doc Description of changeString interpolation in the docs in the
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
Good catch and thanks for the contribution! Can you please format your commit message according to the commit guidelines? The first word after the subsystem must start with a lowercase letter (and should be an imperative verb) and the whole line must not exceed 50 characters. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the mentioned nits concerning commit message.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Done! Should fit in 50 chars now too |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@vhmth great! @vsemozhetbyt IMO, the change is trivial enough to not wait for 48 hours to land. What do you think? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@aqrln I am still a bit uncertain about timeframe in these cases. @nodejs/documentation, how quick can such fixes be landed? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
The minimum time for most PRs is 48 hours, 72 hours over the weekend. We can shorten the time for very trivial doc changes but those are rare. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Don't worry guys we have all the time in the world once singularity hits. 🤖 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@jasnell Is this trivial? If so, how much can the time be shorten? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
There's no hard-and-fast rules on what is "trivial" and how much things can be shortened. Use your judgment. (And if your judgment is way off, someone will tell you. The CTC can always revise the rules if there's an epidemic of PRs landing too quickly.) In my opinion, this is definitely trivial enough that you can land it right now. (I generally try to get at least two other people to say "yeah, land this right away", if that helps.) It's a tiny doc change that is easy and harmless to undo if it turns out there's something wrong with it that we're all missing. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
(All that said: If in doubt, just wait the 48 hours. There's no huge benefit to trivial docs landing faster other than it keeping them out of our backlog and not frustrating contributors who just want to add a missing apostrophe in a doc or something like that.) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Are y'all able to set up a system where PRs get auto-merged at the 48hr mark with a certain amount of approvals? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@vhmth ... auto-merging generally is not a great approach. In addition to the 48 hours, most PRs require one or more CI runs, may need additional testing using our "Canary in the Gold Mine" (CITGM) tool, or otherwise just need another set of eyes to sanity check things. There are also a number of requirements we have for squashing and formatting commit messages that we could automate but there's little apparent benefit in doing so. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
btw, +1 to this being trivial enough to land whenever you're ready. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
PR-URL: #12221 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Boom! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
PR-URL: nodejs#12221 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #12221 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #12221 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: nodejs/node#12221 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.