GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: skip irrelevant test on Windows by Trott · Pull Request #12261 · nodejs/node

Conversation

@Trott

@Trott Trott commented Apr 6, 2017

Copy link
Copy Markdown
Member

Skip test-cluster-disconnect-handles on Windows.

Refs: #12197 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott
test: skip irrelevant test on Windows
4e05220 
Skip test-cluster-disconnect-handles on Windows.

Refs: nodejs#12197 (comment)
@Trott Trott added the test Issues and PRs related to Node.js core tests and test infrastructure. label Apr 6, 2017
@Trott Trott mentioned this pull request Apr 6, 2017
src: Remove support for --debug #12197
Closed
4 tasks done
@Trott

Trott commented Apr 6, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/7249/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Apr 6, 2017

Copy link
Copy Markdown
Member Author

If CI is green, I would strongly advocate for landing this immediately. Needs an LGTM or two, though....
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hybrist

hybrist commented Apr 6, 2017

Copy link
Copy Markdown
Contributor

First of all: Sorry, should've looked more closely at the semantics of known_issues. Trying to understand this change - does this mean the test passes on non-Windows? Confused because I would expect it to fail (given that this cluster.setup uses a now invalid flag).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Apr 6, 2017
View reviewed changes
@Trott

Trott commented Apr 6, 2017

Copy link
Copy Markdown
Member Author

@jkrems This means that the test will be skipped. It won't run at all on Windows.

The current version of the test has code that checks to see if it's running on Windows and, if so, exits, which means that it doesn't fail as expected. Yeah, it's confusing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hybrist

hybrist commented Apr 6, 2017

Copy link
Copy Markdown
Contributor

Ah, missed that early return. Thanks for explaining! :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hybrist
hybrist approved these changes Apr 6, 2017
View reviewed changes
cjihrig
cjihrig approved these changes Apr 6, 2017
View reviewed changes
@Trott

Trott commented Apr 6, 2017

Copy link
Copy Markdown
Member Author

CI is green. Landing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Apr 6, 2017

Copy link
Copy Markdown
Member Author

Landed in a94a5da
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Apr 6, 2017
Trott added a commit to Trott/io.js that referenced this pull request Apr 6, 2017
@Trott
test: skip irrelevant test on Windows
a94a5da 
Skip test-cluster-disconnect-handles on Windows.

PR-URL: nodejs#12261
Ref: nodejs#12197 (comment)
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Apr 6, 2017
benchmark: readStart only after completion #12258
Merged
Collaborator nominations #10982
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Apr 10, 2017
@Trott Italo A. Casas
test: skip irrelevant test on Windows
3cdd04b 
Skip test-cluster-disconnect-handles on Windows.

PR-URL: nodejs#12261
Ref: nodejs#12197 (comment)
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
v7.9.0 Release Proposal #12319
Merged
2 tasks done
@MylesBorins MylesBorins added the land-on-v6.x label Apr 18, 2017
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
@Trott @MylesBorins
test: skip irrelevant test on Windows
6c4f786 
Skip test-cluster-disconnect-handles on Windows.

PR-URL: #12261
Ref: #12197 (comment)
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@Trott @MylesBorins
test: skip irrelevant test on Windows
a30ae72 
Skip test-cluster-disconnect-handles on Windows.

PR-URL: #12261
Ref: #12197 (comment)
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
v6.10.3 proposal #12498
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@Trott @andrew749
test: skip irrelevant test on Windows
abbc279 
Skip test-cluster-disconnect-handles on Windows.

PR-URL: nodejs/node#12261
Ref: nodejs/node#12197 (comment)
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott
Trott deleted the fix-ci branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hybrist hybrist hybrist approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Trott @hybrist @cjihrig @richardlau @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.