GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add aqrln to collaborators by aqrln · Pull Request #12273 · nodejs/node

Conversation

@aqrln

@aqrln aqrln commented Apr 7, 2017

Copy link
Copy Markdown
Contributor

Add Alexey Orlenko (@aqrln) to the list of collaborators in README.md

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vsemozhetbyt, TimothyGu, and watilde reacted with hooray emoji
All reactions
  • 🎉 3 reactions
@aqrln
doc: add aqrln to collaborators
81fd8b4 
Add Alexey Orlenko (@aqrln) to the list of collaborators in README.md
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Apr 7, 2017
cjihrig
cjihrig approved these changes Apr 7, 2017
View reviewed changes
bnoordhuis
bnoordhuis approved these changes Apr 7, 2017
View reviewed changes

@bnoordhuis bnoordhuis left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, welcome aboard!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aqrln

aqrln commented Apr 7, 2017

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/7268/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aqrln
aqrln force-pushed the add-collaborator branch from 6200abe to 81fd8b4 Compare April 7, 2017 16:26
Trott
Trott approved these changes Apr 7, 2017
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aqrln

aqrln commented Apr 7, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Sorry, had to force-push and restart the CI because of invalid order in the list (used to be sorted by the name instead of the GitHub handle).

New CI: https://ci.nodejs.org/job/node-test-pull-request/7269/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 7, 2017
@aqrln
doc: add aqrln to collaborators
6581c35 
Add Alexey Orlenko (@aqrln) to the list of collaborators in README.md

PR-URL: nodejs#12273
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@aqrln

aqrln commented Apr 7, 2017

Copy link
Copy Markdown
Contributor Author

Landed in 6581c35.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aqrln aqrln closed this Apr 7, 2017
@aqrln
aqrln deleted the add-collaborator branch April 7, 2017 17:30
@Trott Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Apr 9, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Apr 10, 2017
@aqrln Italo A. Casas
doc: add aqrln to collaborators
83f855d 
Add Alexey Orlenko (@aqrln) to the list of collaborators in README.md

PR-URL: nodejs#12273
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
v7.9.0 Release Proposal #12319
Merged
2 tasks done
@MylesBorins MylesBorins added the land-on-v6.x label Apr 18, 2017
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
@aqrln @MylesBorins
doc: add aqrln to collaborators
72e011e 
Add Alexey Orlenko (@aqrln) to the list of collaborators in README.md

PR-URL: #12273
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@aqrln @MylesBorins
doc: add aqrln to collaborators
3b38e71 
Add Alexey Orlenko (@aqrln) to the list of collaborators in README.md

PR-URL: #12273
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
v6.10.3 proposal #12498
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@aqrln @andrew749
doc: add aqrln to collaborators
b320be4 
Add Alexey Orlenko (@aqrln) to the list of collaborators in README.md

PR-URL: nodejs/node#12273
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
@Trott Trott Trott approved these changes
@cjihrig cjihrig cjihrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@aqrln @bnoordhuis @Trott @cjihrig @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.