GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||
GeezerVison is showing github.com — v8: fix build errors with g++ 7 by bnoordhuis · Pull Request #12392 · nodejs/node Conversation
|
|
test failure is weird and does not happen on my box with this commit (although, with newer clang). Found this catchorg/Catch2#334 Related issue #12388 , I'm fine with landing as is. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
The test failure: It's not related to this pull request, it happens intermittently on the clang 3.4.1 buildbot for reasons beyond my ken. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry if this is the wrong place and might be a stupid question... $ g++ -v gcc version 7.0.1 20170409 (experimental) (GCC) $ gcc -v gcc version 7.0.1 20170409 (experimental) (GCC) Running make I get the following error: make -C out BUILDTYPE=Release V=1 c++ '-D_DARWIN_USE_64_BIT_INODE=1' -I../deps/gtest -I../deps/gtest/include -Os -gdwarf-2 -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++0x -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /Users/danielbevenius/work/nodejs/node/out/Release/.deps//Users/danielbevenius/work/nodejs/node/out/Release/obj.target/gtest/deps/gtest/src/gtest-death-test.o.d.raw -c -o /Users/danielbevenius/work/nodejs/node/out/Release/obj.target/gtest/deps/gtest/src/gtest-death-test.o ../deps/gtest/src/gtest-death-test.cc c++: error: unrecognized command line option ‘-stdlib=libc++’ make[1]: *** [/Users/danielbevenius/work/nodejs/node/out/Release/obj.target/gtest/deps/gtest/src/gtest-death-test.o] Error 1 make: *** [node] Error 2 I'm able to force this compile and run the test by setting clang to 0 in ['OS=="mac"', { 'clang%': 0, }, { 'clang%': 0, }], I get the feeling that I'm missing something. If you have any advice I'd appreciated it. I'd like to be able to switch between gcc/clang for future reviews/issues/troubleshooting. Thanks |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I believe |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Worked like a charm, thanks! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
This is a local patch because upstream fixed it differently by moving large chunks of code out of objects.h. We cannot easily back-port those changes due to their size and invasiveness. Fixes: nodejs#10388 PR-URL: nodejs#12392 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]>
26dfbd6 to
2bbee49
Compare
|
Can you merge this into v8 branch too? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Ambiguity alert: do you mean the node.js v8.0 branch or the upstream V8 project? If it's the former, I don't remember build issues with g++ 7 but if you have them, file a pull request against the master branch. If it's V8, you'll have to send the changes to them - although here too I don't remember issues last time I tried. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I meant node.js v8 branch, latest nightly fails to build on rawhide. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Porting #12392 to master Ref: #12392 Fixes: #10388 PR-URL: #12676 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
This is a local patch because upstream fixed it differently by moving large chunks of code out of objects.h. We cannot easily back-port those changes due to their size and invasiveness. Fixes: #10388 PR-URL: #12392 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]>
Notable changes:
* **crypto**:
- add randomFill and randomFillSync (Evan Lucas)
#10209
* **meta**: Added new collaborators
- add lucamaraschi to collaborators (Luca Maraschi)
#12538
- add DavidCai1993 to collaborators (David Cai)
#12435
- add jkrems to collaborators (Jan Krems)
#12427
- add AnnaMag to collaborators (AnnaMag)
#12414
* **process**:
- fix crash when Promise rejection is a Symbol (Cameron Little)
#11640
* **url**:
- make WHATWG URL more spec compliant (Timothy Gu)
#12507
* **v8**:
- fix stack overflow in recursive method (Ben Noordhuis)
#12460
- fix build errors with g++ 7 (Ben Noordhuis)
#12392
PR-URL: #12775
|
v6.x backport here: #13574 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Porting #12392 to V8 5.9 Ref: #12392 Fixes: #10388 PR-URL: #13515 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
This is a local patch because upstream fixed it differently by moving large chunks of code out of objects.h. We cannot easily back-port those changes due to their size and invasiveness. Fixes: nodejs#10388 PR-URL: nodejs#12392 Backport-PR-URL: nodejs#13574 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]>
This is a local patch because upstream fixed it differently by moving large chunks of code out of objects.h. We cannot easily back-port those changes due to their size and invasiveness. Fixes: #10388 PR-URL: #12392 Backport-PR-URL: #13574 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]>
Porting #12392 to V8 5.9 Ref: #12392 Fixes: #10388 PR-URL: #13515 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Original commit message:
Fix GCC 7 build errors
BUG=chromium:691681
[email protected]
Change-Id: Id7e5698487f16dc217a804f6d3f24da7213c72b9
Reviewed-on: https://chromium-review.googlesource.com/530227
Commit-Queue: Toon Verwaest <[email protected]>
Reviewed-by: Toon Verwaest <[email protected]>
Cr-Commit-Position: refs/heads/master@{nodejs#46045}
PR-URL: nodejs#13517
Fixes: nodejs#10388
Refs: nodejs#12392
Reviewed-By: Ben Noordhuis <[email protected]>
Porting #12392 to V8 5.9 Ref: #12392 Fixes: #10388 PR-URL: #13515 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Porting #12392 to V8 5.9 Ref: #12392 Fixes: #10388 PR-URL: #13515 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
This is a local patch because upstream fixed it differently by moving large chunks of code out of objects.h. We cannot easily back-port those changes due to their size and invasiveness. Fixes: #10388 PR-URL: #12392 Backport-PR-URL: #13574 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]>
Porting #12392 to V8 5.9 Ref: #12392 Fixes: #10388 PR-URL: #13515 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Porting #12392 to V8 5.9 Ref: #12392 Fixes: #10388 PR-URL: #13515 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Porting nodejs#12392 to V8 5.9 Ref: nodejs#12392 Fixes: nodejs#10388
Porting #12392 to V8 5.9 Ref: #12392 Fixes: #10388 PR-URL: #13515 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.