GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — v6.x backport: test: refactor several parallel/test-timer tests by BethGriggs · Pull Request #12401 · nodejs/node

Conversation

@BethGriggs

@BethGriggs BethGriggs commented Apr 13, 2017

Copy link
Copy Markdown
Member

Change var to const/let. Simplify test-timers-uncaught-exception.

PR-URL: #10524
Reviewed-By: James M Snell [email protected]
Reviewed-By: Gibson Fahnestock [email protected]
Reviewed-By: Jeremiah Senkpiel [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Test

/cc @gibfahn

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to Node.js core tests and test infrastructure. v6.x labels Apr 13, 2017
@vsemozhetbyt vsemozhetbyt added the backport-to-v6.x label Apr 13, 2017
sam-github
sam-github approved these changes Apr 13, 2017
View reviewed changes
@sam-github

sam-github commented Apr 13, 2017

Copy link
Copy Markdown
Contributor

ci: https://ci.nodejs.org/job/node-test-pull-request/7381/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca lpinca changed the title test: refactor several parallel/test-timer tests v6.x backport: test: refactor several parallel/test-timer tests Apr 13, 2017
@lpinca

lpinca commented Apr 13, 2017

Copy link
Copy Markdown
Member

@BethGriggs I took the liberty of updating PR title.
gibfahn reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mscdex mscdex added timers Issues and PRs related to timers, setImmediate(), setInterval(), and setTimeout(). and removed backport-to-v6.x labels Apr 13, 2017
@MylesBorins

MylesBorins commented Apr 13, 2017

Copy link
Copy Markdown
Contributor

so it seems like the work from this PR ended up getting wrapped into another backport that has already landed. Thanks for putting the time into this @BethGriggs, fun to run into you in the PR tracker 😄
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins MylesBorins closed this Apr 13, 2017
@gibfahn

gibfahn commented Apr 18, 2017

Copy link
Copy Markdown
Member

@MylesBorins Is that true? The changes to the first file were just var->const, and they went into a different PR, but the changes to the other files don't seem to have gone into v6.x-staging, e.g. test-timers-uncaught-exception.js on v6.x-staging.

e.g. this diff:

-console.error('set first timer');
-setTimeout(function() {
-  console.error('first timer');
-  timer1++;
-  throw new Error('BAM!');
-}, 100);
+setTimeout(common.mustCall(function() {
+  throw new Error(errorMsg);
+}), 1);

isn't in test-timers-uncaught-exception.js#L10-L15.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gibfahn gibfahn reopened this Apr 18, 2017
@BethGriggs
test: refactor several parallel/test-timer tests
6896e4c 
Change var to const/let. Simplify test-timers-uncaught-exception.

PR-URL: nodejs#10524
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@BethGriggs
BethGriggs force-pushed the backport-10524-to-v6.x branch from 271e226 to 6896e4c Compare April 18, 2017 11:06
@gibfahn

gibfahn commented Apr 18, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-commit/9193/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gibfahn
gibfahn approved these changes Apr 19, 2017
View reviewed changes
@gibfahn

gibfahn commented Apr 19, 2017

Copy link
Copy Markdown
Member

CI 2: https://ci.nodejs.org/job/node-test-commit/9241/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MylesBorins pushed a commit that referenced this pull request Apr 24, 2017
@BethGriggs @MylesBorins
test: refactor several parallel/test-timer tests
9218661 
Change var to const/let. Simplify test-timers-uncaught-exception.

Backport-PR-URL: #12401
PR-URL: #10524
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@MylesBorins

MylesBorins commented Apr 24, 2017

Copy link
Copy Markdown
Contributor

landed in 9218661
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins MylesBorins closed this Apr 24, 2017
MylesBorins pushed a commit that referenced this pull request Apr 24, 2017
@BethGriggs @MylesBorins
test: refactor several parallel/test-timer tests
aae3765 
Change var to const/let. Simplify test-timers-uncaught-exception.

Backport-PR-URL: #12401
PR-URL: #10524
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@BethGriggs @andrew749
test: refactor several parallel/test-timer tests
1078086 
Change var to const/let. Simplify test-timers-uncaught-exception.

Backport-PR-URL: nodejs/node#12401
PR-URL: nodejs/node#10524
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@BethGriggs
BethGriggs deleted the backport-10524-to-v6.x branch February 21, 2018 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@sam-github sam-github sam-github approved these changes
@gibfahn gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

test Issues and PRs related to Node.js core tests and test infrastructure. timers Issues and PRs related to timers, setImmediate(), setInterval(), and setTimeout().

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@BethGriggs @sam-github @lpinca @MylesBorins @gibfahn @mscdex @vsemozhetbyt @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.