GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: improve N-API test coverage by mhdawson · Pull Request #13006 · nodejs/node

Conversation

@mhdawson

@mhdawson mhdawson commented May 12, 2017

Copy link
Copy Markdown
Member

add tests top cover functions that returns globals

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test, n-api

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhdawson
test: improve N-API test coverage
bd54759 
add tests top cover functions that returns globals
@nodejs-github-bot nodejs-github-bot added node-api Issues and PRs related to Node-API. test Issues and PRs related to Node.js core tests and test infrastructure. labels May 12, 2017
cjihrig
cjihrig approved these changes May 12, 2017
View reviewed changes
@addaleax addaleax added dont-land-on-v4.x labels May 12, 2017
addaleax
addaleax approved these changes May 12, 2017
View reviewed changes
jasongin
jasongin approved these changes May 13, 2017
View reviewed changes
@mhdawson

mhdawson commented May 15, 2017

Copy link
Copy Markdown
Member Author

CI Run: https://ci.nodejs.org/job/node-test-pull-request/8091/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson

mhdawson commented May 16, 2017

Copy link
Copy Markdown
Member Author

CI good, landing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson

mhdawson commented May 16, 2017

Copy link
Copy Markdown
Member Author

Landed as 47c3c58
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson mhdawson closed this May 16, 2017
mhdawson added a commit that referenced this pull request May 16, 2017
@mhdawson
test: improve N-API test coverage
47c3c58 
Add tests to cover functions that return globals

PR-URL: #13006
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jason Ginchereau <[email protected]>
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
@mhdawson Olivier Martin
test: improve N-API test coverage
223c992 
Add tests to cover functions that return globals

PR-URL: nodejs#13006
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jason Ginchereau <[email protected]>
@jasnell jasnell mentioned this pull request May 28, 2017
8.0.0 Release Proposal #12220
Closed
@mhdawson
mhdawson deleted the napi-cov4 branch June 28, 2017 19:23
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
@mhdawson Gabriel Schulhof
test: improve N-API test coverage
67e0372 
Add tests to cover functions that return globals

PR-URL: nodejs#13006
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jason Ginchereau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@mhdawson @MylesBorins
test: improve N-API test coverage
314f22d 
Add tests to cover functions that return globals

Backport-PR-URL: #19447
PR-URL: #13006
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jason Ginchereau <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
v6.14.2 proposal #19996
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@cjihrig cjihrig cjihrig approved these changes
+1 more reviewer
@jasongin jasongin jasongin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

node-api Issues and PRs related to Node-API. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@mhdawson @addaleax @cjihrig @jasongin @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.