GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update V8 to 5.9 by targos · Pull Request #13263 · nodejs/node

Conversation

@targos

@targos targos commented May 28, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I kept out v8: fix stack overflow in recursive method because Crankshaft is disabled in 5.9.

/cc @nodejs/v8

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

CI: https://ci.nodejs.org/job/node-test-commit/10205/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/720/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

addaleax, vsemozhetbyt, gibfahn, bricss, BridgeAR, ilkkao, SerayaEryn, lin7sh, bbrzoska, oaleynik, and 2 more reacted with hooray emoji bricss, lin7sh, and CYBAI reacted with heart emoji
All reactions
  • 🎉 12 reactions
  • ❤️ 3 reactions
@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label May 28, 2017
@targos

targos commented May 28, 2017

Copy link
Copy Markdown
Member Author

There is one failing V8 test: https://ci.nodejs.org/job/node-test-commit-v8-linux/720/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jasnell

jasnell commented May 28, 2017

Copy link
Copy Markdown
Member

In order to make things easiest, please don't land this until the 8.0.0 release is out.

targos reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos

targos commented May 29, 2017

Copy link
Copy Markdown
Member Author

I cannot reproduce the V8 test failure on Fedora 25.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos
targos force-pushed the v8-5.9 branch from 1f65015 to 782f735 Compare May 30, 2017 08:15
@targos

targos commented May 30, 2017

Copy link
Copy Markdown
Member Author

Added 22b3ad952d4c0e96610ae6604febf5be5d372790 to fix the Windows issue.
New CI: https://ci.nodejs.org/job/node-test-commit/10238/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos

targos commented May 31, 2017

Copy link
Copy Markdown
Member Author

Another V8 CI run: https://ci.nodejs.org/job/node-test-commit-v8-linux/723/
The test seems to be flaky.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gibfahn
gibfahn approved these changes May 31, 2017
View reviewed changes

@gibfahn gibfahn left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the basis that node CI is green.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@gibfahn

gibfahn commented May 31, 2017

Copy link
Copy Markdown
Member

v8tests.mjsunit/es6/typedarray-construct-offset-not-smi certainly seems flaky, do you know if there's an open issue for that?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jbajwa

jbajwa commented May 31, 2017 •
edited by gibfahn
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Looks like the issue is similar to #6678, where OOM killer kicks in and kills the process.

[7242863.995926] [34119]  1004 34119   671796   449914    1796        0             0 d8
[7242863.995927] Out of memory: Kill process 34119 (d8) score 224 or sacrifice child
[7242863.995929] Killed process 34119 (d8) total-vm:2687184kB, anon-rss:1799632kB, file-rss:24kB

in typedarray-construct-offset-not-smi.js there is an allocation of 2G block of memory

var non_smi_byte_length = %_MaxSmi() + 11; // <<-- 2147483658
  try {
    var buffer = new ArrayBuffer(non_smi_byte_length); 
  } catch (e) {

Following the same approach as #6678, following patch should fix this flaky behavior

diff --git a/deps/v8/test/mjsunit/mjsunit.status b/deps/v8/test/mjsunit/mjsunit.status
index 66ecfcf..c8c3c4e 100644
--- a/deps/v8/test/mjsunit/mjsunit.status
+++ b/deps/v8/test/mjsunit/mjsunit.status
@@ -148,7 +148,7 @@
   # Slow tests.
   'copy-on-write-assert': [PASS, SLOW],
   'es6/tail-call-megatest*': [PASS, SLOW, FAST_VARIANTS, ['tsan', SKIP]],
-  'es6/typedarray-construct-offset-not-smi': [PASS, SLOW],
+  'es6/typedarray-construct-offset-not-smi': [PASS, SLOW, NO_VARIANTS],
   'harmony/regexp-property-script-extensions': [PASS, SLOW],
   'numops-fuzz-part*': [PASS, ['mode == debug', SLOW]],
   'readonly': [PASS, SLOW],
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bnoordhuis

bnoordhuis commented May 31, 2017

Copy link
Copy Markdown
Member

I kept out v8: fix stack overflow in recursive method because Crankshaft is disabled in 5.9.

Disabled by default, not disabled altogether. Functions that don't pass --turbo_filter=... are still directed to crankshaft. If the patch is easy to forward-port, I'd keep it for now.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bnoordhuis
bnoordhuis requested changes May 31, 2017
View reviewed changes

@bnoordhuis bnoordhuis left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VS 2013 support patch can be dropped and wasn't the plan to keep 5.9 ABI and API compatible with 5.8? In that case bumping NODE_MODULE_VERSION isn't necessary.

(I realize the pull request in its current shape breaks API/ABI but I'm wondering what the plan is.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@addaleax

addaleax commented May 31, 2017

Copy link
Copy Markdown
Member

@bnoordhuis I think the plan is to have clean V8 versions on master and apply the compatibility fixes only on v8.x(-staging), so this should be fine

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos

targos commented Jun 1, 2017

Copy link
Copy Markdown
Member Author

If the patch is easy to forward-port, I'd keep it for now.

OK, I'll add it back.

The VS 2013 support patch can be dropped

Do you mean we don't support VS 2013 anymore? Then the CI jobs must change.

...wasn't the plan to keep 5.9 ABI and API compatible with 5.8?

What @addaleax said.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos
targos force-pushed the v8-5.9 branch from 782f735 to 592ae8b Compare June 1, 2017 07:32
@bnoordhuis

bnoordhuis commented Jun 1, 2017

Copy link
Copy Markdown
Member

Do you mean we don't support VS 2013 anymore? Then the CI jobs must change.

The vs2013 buildbot is only used for the v4.x branch at this point, I think, and possibly addon tests in v6.x.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fhinkel
fhinkel approved these changes Jun 1, 2017
View reviewed changes

@fhinkel fhinkel left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@targos

targos commented Jun 1, 2017

Copy link
Copy Markdown
Member Author

@bnoordhuis see nodejs/node-v8#4 (comment)

It looks like addon tests are compiled with vs2013 for all branches.

/cc @joaocgreis

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joaocgreis

joaocgreis commented Jun 1, 2017

Copy link
Copy Markdown
Member

We still support building native addons with VS2013. The CI machines with Windows 2008 all have VS2013 to make sure the addons test suite is run with VS2013.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@psmarshall

psmarshall commented Jun 1, 2017

Copy link
Copy Markdown
Contributor

That test allocating 2GB of memory is a bit extreme, we'll look into it on the v8 side for the future: (v8 bug)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bnoordhuis

bnoordhuis commented Jun 1, 2017

Copy link
Copy Markdown
Member

It looks like addon tests are compiled with vs2013 for all branches.

Okay, but that means the V8 patch can be dropped. It's many things but an add-on it is not. LGTM apart from that.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bnoordhuis
bnoordhuis approved these changes Jun 1, 2017
View reviewed changes
@targos

targos commented Jun 1, 2017

Copy link
Copy Markdown
Member Author

But without the patch, win2008r2 tests are red: https://ci.nodejs.org/job/node-test-binary-windows/8831/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bnoordhuis

bnoordhuis commented Jun 1, 2017

Copy link
Copy Markdown
Member

Ah, I somehow had the idea that the patch only touched files in deps/v8/src. Okay, objection withdrawn.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bnoordhuis bnoordhuis mentioned this pull request Jun 1, 2017
build: drop support for building addons with VS 2013 in v9 #13372
Closed
@bnoordhuis

bnoordhuis commented Jun 1, 2017

Copy link
Copy Markdown
Member

Raised #13372 to discuss dropping support for VS 2013 in node 9.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@refack refack mentioned this pull request Jun 5, 2017
net: use rest parameters instead of arguments #13472
Closed
2 tasks done
MylesBorins
MylesBorins previously requested changes Jun 5, 2017
View reviewed changes

@MylesBorins MylesBorins left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should only land this if it has the ABI compat patches for 6.0

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@jasnell

jasnell commented Jun 5, 2017

Copy link
Copy Markdown
Member

Agreed. Landing this without the ABI compat patches would be a regression

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@addaleax

addaleax commented Jun 5, 2017

Copy link
Copy Markdown
Member

@MylesBorins Even on master? We didn’t do that for V8 5.8

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

addaleax pushed a commit that referenced this pull request Jun 17, 2017
@targos @addaleax
deps: cherry-pick 6d38f89 from upstream V8
1eb69b5
Original commit message:

    [turbofan] Boost performance of Array.prototype.shift by 4x.

    For small arrays, it's way faster to just move the elements instead of
    doing the fairly complex and heavy-weight left-trimming. Crankshaft has
    had this optimization for small arrays already; this CL more or less
    ports this functionality to TurboFan, which yields a 4x speed-up when
    using shift on small arrays (with up to 16 elements).

    This should recover some of the regressions reported in the Node.js issues

      #12657

    and discovered for the syncthrough module using

      https://github.com/mcollina/syncthrough/blob/master/benchmarks/basic.js

    as benchmark.

    [email protected]
    BUG=v8:6376

    Review-Url: https://codereview.chromium.org/2874453002
    Cr-Commit-Position: refs/heads/master@{#45216}

PR-URL: #13263
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@addaleax addaleax mentioned this pull request Jun 17, 2017
v8.2.0 proposal #13744
Merged
addaleax pushed a commit that referenced this pull request Jun 21, 2017
@targos @addaleax
deps: run memory hungry V8 test in exclusive mode
e6f2233
es6/typedarray-construct-offset-not-smi allocates a 2G block of memory
and if there  are multiple variants running at the same time this can
lead to crashes, OOM kills or the OS failing to allocate memory.
This patch limits us to running a single variant of the test.

Refs: #6678

PR-URL: #13263
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
addaleax pushed a commit that referenced this pull request Jun 21, 2017
@targos @addaleax
deps: add missing include to V8 i18n.cc
5fbff98
This is required for ICU 59.1.

PR-URL: #13263
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
addaleax pushed a commit that referenced this pull request Jun 21, 2017
@bzoz @addaleax
deps: fix addons compilation with VS2013
fb948df
VS2013 does not support defaulting move constructor and assignment
operator. This adds explicit definitions of those methods for two
classes.
This fix is required because we still support building addons with
VS2013 and the incompatibility is in v8.h.

Fixes: nodejs/node-v8#4

PR-URL: #13263
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
addaleax pushed a commit that referenced this pull request Jun 21, 2017
@targos @addaleax
deps: cherry-pick 6d38f89 from upstream V8
254a13d
Original commit message:

    [turbofan] Boost performance of Array.prototype.shift by 4x.

    For small arrays, it's way faster to just move the elements instead of
    doing the fairly complex and heavy-weight left-trimming. Crankshaft has
    had this optimization for small arrays already; this CL more or less
    ports this functionality to TurboFan, which yields a 4x speed-up when
    using shift on small arrays (with up to 16 elements).

    This should recover some of the regressions reported in the Node.js issues

      #12657

    and discovered for the syncthrough module using

      https://github.com/mcollina/syncthrough/blob/master/benchmarks/basic.js

    as benchmark.

    [email protected]
    BUG=v8:6376

    Review-Url: https://codereview.chromium.org/2874453002
    Cr-Commit-Position: refs/heads/master@{#45216}

PR-URL: #13263
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
targos added a commit that referenced this pull request Jun 23, 2017
@targos
deps: run memory hungry V8 test in exclusive mode
f33217a
es6/typedarray-construct-offset-not-smi allocates a 2G block of memory
and if there  are multiple variants running at the same time this can
lead to crashes, OOM kills or the OS failing to allocate memory.
This patch limits us to running a single variant of the test.

Refs: #6678

PR-URL: #13263
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Jun 23, 2017
@targos @nodejs-ci
deps: run memory hungry V8 test in exclusive mode
69eec0e
es6/typedarray-construct-offset-not-smi allocates a 2G block of memory
and if there  are multiple variants running at the same time this can
lead to crashes, OOM kills or the OS failing to allocate memory.
This patch limits us to running a single variant of the test.

Refs: nodejs/node#6678

PR-URL: nodejs/node#13263
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Jun 24, 2017
@targos @nodejs-ci
deps: run memory hungry V8 test in exclusive mode
229acbb
es6/typedarray-construct-offset-not-smi allocates a 2G block of memory
and if there  are multiple variants running at the same time this can
lead to crashes, OOM kills or the OS failing to allocate memory.
This patch limits us to running a single variant of the test.

Refs: nodejs/node#6678

PR-URL: nodejs/node#13263
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
addaleax pushed a commit that referenced this pull request Jun 24, 2017
@targos @addaleax
deps: run memory hungry V8 test in exclusive mode
11be416
es6/typedarray-construct-offset-not-smi allocates a 2G block of memory
and if there  are multiple variants running at the same time this can
lead to crashes, OOM kills or the OS failing to allocate memory.
This patch limits us to running a single variant of the test.

Refs: #6678

PR-URL: #13263
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
addaleax pushed a commit that referenced this pull request Jun 24, 2017
@targos @addaleax
deps: add missing include to V8 i18n.cc
169de6c
This is required for ICU 59.1.

PR-URL: #13263
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
addaleax pushed a commit that referenced this pull request Jun 24, 2017
@bzoz @addaleax
deps: fix addons compilation with VS2013
73916ea
VS2013 does not support defaulting move constructor and assignment
operator. This adds explicit definitions of those methods for two
classes.
This fix is required because we still support building addons with
VS2013 and the incompatibility is in v8.h.

Fixes: nodejs/node-v8#4

PR-URL: #13263
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
addaleax pushed a commit that referenced this pull request Jun 24, 2017
@targos @addaleax
deps: cherry-pick 6d38f89 from upstream V8
aa86569
Original commit message:

    [turbofan] Boost performance of Array.prototype.shift by 4x.

    For small arrays, it's way faster to just move the elements instead of
    doing the fairly complex and heavy-weight left-trimming. Crankshaft has
    had this optimization for small arrays already; this CL more or less
    ports this functionality to TurboFan, which yields a 4x speed-up when
    using shift on small arrays (with up to 16 elements).

    This should recover some of the regressions reported in the Node.js issues

      #12657

    and discovered for the syncthrough module using

      https://github.com/mcollina/syncthrough/blob/master/benchmarks/basic.js

    as benchmark.

    [email protected]
    BUG=v8:6376

    Review-Url: https://codereview.chromium.org/2874453002
    Cr-Commit-Position: refs/heads/master@{#45216}

PR-URL: #13263
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Jun 25, 2017
@targos @nodejs-ci
deps: run memory hungry V8 test in exclusive mode
33448d8
es6/typedarray-construct-offset-not-smi allocates a 2G block of memory
and if there  are multiple variants running at the same time this can
lead to crashes, OOM kills or the OS failing to allocate memory.
This patch limits us to running a single variant of the test.

Refs: nodejs/node#6678

PR-URL: nodejs/node#13263
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Jun 26, 2017
@targos @nodejs-ci
deps: run memory hungry V8 test in exclusive mode
58da390
es6/typedarray-construct-offset-not-smi allocates a 2G block of memory
and if there  are multiple variants running at the same time this can
lead to crashes, OOM kills or the OS failing to allocate memory.
This patch limits us to running a single variant of the test.

Refs: nodejs/node#6678

PR-URL: nodejs/node#13263
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
targos added a commit that referenced this pull request Jun 26, 2017
@targos
deps: run memory hungry V8 test in exclusive mode
ee28824
es6/typedarray-construct-offset-not-smi allocates a 2G block of memory
and if there  are multiple variants running at the same time this can
lead to crashes, OOM kills or the OS failing to allocate memory.
This patch limits us to running a single variant of the test.

Refs: #6678

PR-URL: #13263
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
targos pushed a commit that referenced this pull request Jun 26, 2017
@bzoz @targos
deps: fix addons compilation with VS2013
17cd1ec
VS2013 does not support defaulting move constructor and assignment
operator. This adds explicit definitions of those methods for two
classes.
This fix is required because we still support building addons with
VS2013 and the incompatibility is in v8.h.

Fixes: nodejs/node-v8#4

PR-URL: #13263
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
targos added a commit to nodejs/node-v8 that referenced this pull request Jun 26, 2017
@targos
deps: run memory hungry V8 test in exclusive mode
8b840a9
es6/typedarray-construct-offset-not-smi allocates a 2G block of memory
and if there  are multiple variants running at the same time this can
lead to crashes, OOM kills or the OS failing to allocate memory.
This patch limits us to running a single variant of the test.

Refs: nodejs/node#6678

PR-URL: nodejs/node#13263
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@addaleax addaleax mentioned this pull request Jul 24, 2017
v8.3.0 proposal #14452
Closed
@NeilFraser NeilFraser mentioned this pull request Jul 28, 2017
Sudden performance drop after multiple executions #14528
Closed
@MylesBorins MylesBorins mentioned this pull request Oct 3, 2017
v8.7.0 proposal #15762
Merged
@jasnell jasnell mentioned this pull request Oct 30, 2017
Proposal: 2017-10-31, Version 9.0.0 (Current) #15135
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
+3 more reviewers
@fhinkel fhinkel fhinkel approved these changes
@MylesBorins MylesBorins MylesBorins approved these changes
@gibfahn gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

16 participants

@targos @jasnell @gibfahn @jbajwa @bnoordhuis @addaleax @joaocgreis @psmarshall @mgol @Fishrock123 @MylesBorins @fhinkel @nodejs-github-bot @mhdawson @bzoz @danbev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.