GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools, test: update test-npm-package paths by gibfahn · Pull Request #13441 · nodejs/node

Conversation

@gibfahn

@gibfahn gibfahn commented Jun 3, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Makes the same changes as 9946173 to update the test runner for npm5.

Refs: #12936

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools, test

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gibfahn gibfahn added npm Issues and PRs related to the npm client dependency or the npm registry. test Issues and PRs related to Node.js core tests and test infrastructure. tools Issues and PRs related to the tools directory. labels Jun 3, 2017
@gibfahn
gibfahn requested a review from hybrist June 3, 2017 19:45
@nodejs-github-bot nodejs-github-bot added npm Issues and PRs related to the npm client dependency or the npm registry. test Issues and PRs related to Node.js core tests and test infrastructure. tools Issues and PRs related to the tools directory. labels Jun 3, 2017
@gibfahn gibfahn added dont-land-on-v4.x labels Jun 3, 2017
hybrist
hybrist approved these changes Jun 3, 2017
View reviewed changes

@hybrist hybrist left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
lpinca
lpinca approved these changes Jun 4, 2017
View reviewed changes
thefourtheye
thefourtheye approved these changes Jun 4, 2017
View reviewed changes
jasnell
jasnell approved these changes Jun 4, 2017
View reviewed changes
refack
refack approved these changes Jun 5, 2017
View reviewed changes
@gibfahn gibfahn self-assigned this Jun 6, 2017
@gibfahn

gibfahn commented Jun 6, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/10411/
CI 2: https://ci.nodejs.org/job/node-test-commit/10415/

Will land tomorrow if no objections
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gibfahn
gibfahn force-pushed the npm-cli-bin branch from b5a35fa to 6a2a557 Compare June 7, 2017 14:35
@gibfahn
tools, test: update test-npm-package paths
6bcea5c 
Makes the same changes as
nodejs@9946173
to update the test runner for npm5.

PR-URL: nodejs#13441
Refs: nodejs#12936
Reviewed-By: Jan Krems <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@gibfahn
gibfahn force-pushed the npm-cli-bin branch from 6a2a557 to 6bcea5c Compare June 7, 2017 14:36
@gibfahn
gibfahn merged commit 6bcea5c into nodejs:master Jun 7, 2017
@gibfahn
gibfahn deleted the npm-cli-bin branch June 7, 2017 15:36
jasnell pushed a commit that referenced this pull request Jun 7, 2017
@gibfahn @jasnell
tools, test: update test-npm-package paths
61eb085 
Makes the same changes as
9946173
to update the test runner for npm5.

PR-URL: #13441
Refs: #12936
Reviewed-By: Jan Krems <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@hybrist hybrist hybrist approved these changes
@lpinca lpinca lpinca approved these changes
+2 more reviewers
@refack refack refack approved these changes
@thefourtheye thefourtheye thefourtheye approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gibfahn gibfahn

Labels

npm Issues and PRs related to the npm client dependency or the npm registry. test Issues and PRs related to Node.js core tests and test infrastructure. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@gibfahn @refack @jasnell @hybrist @thefourtheye @lpinca @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.