GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — (v6.x backport) process: add --redirect-warnings command line argument by sam-github · Pull Request #14480 · nodejs/node

Conversation

@sam-github

@sam-github sam-github commented Jul 25, 2017

Copy link
Copy Markdown
Contributor

The --redirect-warnings command line argument allows process warnings
to be written to a specified file rather than printed to stderr.

Also adds an equivalent NODE_REDIRECT_WARNINGS environment variable.

If the specified file cannot be opened or written to for any reason,
the argument is ignored and the warning is printed to stderr.

If the file already exists, it will be appended to.

PR-URL: #10116
Reviewed-By: Michael Dawson [email protected]
Reviewed-By: Michal Zasso [email protected]
Reviewed-By: Fedor Indutny [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. v6.x labels Jul 25, 2017
@sam-github

sam-github commented Jul 25, 2017

Copy link
Copy Markdown
Contributor Author

Parking this until the next semver minor release of 6.x, see #14418 (comment)

@nodejs/lts
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sam-github sam-github added lts-watch-v6.x semver-minor PRs that contain new features and should be released in the next minor version. labels Jul 25, 2017
@MylesBorins
MylesBorins force-pushed the v6.x-staging branch from 7b8fcf8 to f4691bb Compare August 1, 2017 07:09
@MylesBorins
MylesBorins force-pushed the v6.x-staging branch 6 times, most recently from f9419c2 to 403c465 Compare August 16, 2017 18:43
@mhdawson mhdawson mentioned this pull request Aug 28, 2017
Meeting Aug 28th, 2017 nodejs/Release#243
Closed
@MylesBorins
MylesBorins force-pushed the v6.x-staging branch 2 times, most recently from aaf4e13 to 31f572c Compare September 5, 2017 16:50
@gibfahn gibfahn mentioned this pull request Sep 16, 2017
Release WG meeting Tuesday 19th September 2017 nodejs/Release#244
Closed
@MylesBorins

MylesBorins commented Sep 19, 2017

Copy link
Copy Markdown
Contributor

Needs a rebase. Good to land
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins MylesBorins removed the lts-agenda label Sep 19, 2017
@sam-github
sam-github force-pushed the v6.x-backport-redirect-warnings branch 2 times, most recently from f6063fc to 33c45ce Compare September 20, 2017 18:21
@sam-github

sam-github commented Sep 20, 2017

Copy link
Copy Markdown
Contributor Author

Landed in adf6d16
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sam-github sam-github closed this Sep 20, 2017
@MylesBorins MylesBorins reopened this Sep 20, 2017
@MylesBorins

MylesBorins commented Sep 20, 2017

Copy link
Copy Markdown
Contributor

backing this out of v6.x-staging it is not ready to land yet. We will land the minors next month when we are prepping the minor release
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sam-github
sam-github force-pushed the v6.x-backport-redirect-warnings branch from 33c45ce to a76b3b8 Compare September 25, 2017 19:44
@sam-github sam-github mentioned this pull request Sep 25, 2017
(v6.x backport) src: allow CLI args in env with NODE_OPTIONS #12677
Closed
4 tasks
@MylesBorins
MylesBorins force-pushed the v6.x-staging branch from b811464 to 2c8fe97 Compare September 26, 2017 03:44
@MylesBorins

MylesBorins commented Oct 10, 2017

Copy link
Copy Markdown
Contributor

landed in 158906b707
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins MylesBorins closed this Oct 10, 2017
@MylesBorins MylesBorins reopened this Oct 10, 2017
@MylesBorins

MylesBorins commented Oct 10, 2017

Copy link
Copy Markdown
Contributor

@sam-github I had to back this out as it was breaking the build. Can you please rebase and confirm that this compiles
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins
MylesBorins force-pushed the v6.x-staging branch from 355249a to 0597d3f Compare October 10, 2017 13:11
@sam-github
sam-github force-pushed the v6.x-backport-redirect-warnings branch 2 times, most recently from b879e03 to 2604584 Compare October 10, 2017 21:46
@sam-github

sam-github commented Oct 10, 2017

Copy link
Copy Markdown
Contributor Author

rebased again, and it compiles for me, I'm running tests locally and on ci: https://ci.nodejs.org/job/node-test-pull-request/10590/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sam-github

sam-github commented Oct 10, 2017

Copy link
Copy Markdown
Contributor Author

OK, I think this is because secure_getenv() doesn't exist on all linux platforms. I think this should have been fixed by #11051, but perhaps #11051 was landed before this semver-minor, so the part applying to this PR is missing. I'll patch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell and others added 2 commits October 10, 2017 16:26
@jasnell @sam-github
process: add --redirect-warnings command line argument
bc89407 
The --redirect-warnings command line argument allows process warnings
to be written to a specified file rather than printed to stderr.

Also adds an equivalent NODE_REDIRECT_WARNINGS environment variable.

If the specified file cannot be opened or written to for any reason,
the argument is ignored and the warning is printed to stderr.

If the file already exists, it will be appended to.

PR-URL: nodejs#10116
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Michal Zasso <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
@sam-github
src: make copies of startup environment variables
63c1ce4 
Mutations of the environment can invalidate pointers to environment
variables, so make `secure_getenv()` copy them out instead of returning
pointers.

This is the part of nodejs#11051 that
applies to
nodejs@03e89b3
@sam-github
sam-github force-pushed the v6.x-backport-redirect-warnings branch from 2604584 to 63c1ce4 Compare October 10, 2017 23:27
@sam-github

sam-github commented Oct 10, 2017

Copy link
Copy Markdown
Contributor Author

replaced by #12677
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sam-github sam-github closed this Oct 10, 2017
@sam-github
sam-github deleted the v6.x-backport-redirect-warnings branch October 16, 2018 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sam-github @MylesBorins @nodejs-github-bot @jasnell
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.