GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v8.x backport] repl: improve require() autocompletion by tniessen · Pull Request #14525 · nodejs/node

Conversation

@tniessen

@tniessen tniessen commented Jul 27, 2017

Copy link
Copy Markdown
Member

Backport of @aqrln's PR #14409 to v8.x.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aqrln @tniessen
repl: improve require() autocompletion
2f6f4ec 
Currently REPL supports autocompletion for core modules and those found
in node_modules.  This commit adds tab completion for modules relative
to the current directory.

PR-URL: nodejs#14409
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@tniessen tniessen added the v8.x label Jul 27, 2017
@tniessen
tniessen requested review from addaleax and aqrln July 27, 2017 23:35
@nodejs-github-bot nodejs-github-bot added repl Issues and PRs related to the REPL subsystem. v8.x labels Jul 27, 2017
@tniessen

tniessen commented Jul 27, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/9384/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax self-assigned this Jul 28, 2017
addaleax
addaleax approved these changes Jul 28, 2017
View reviewed changes
@addaleax

addaleax commented Jul 28, 2017

Copy link
Copy Markdown
Member

Landed in 5a8862b, thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Jul 28, 2017
addaleax pushed a commit that referenced this pull request Jul 28, 2017
@aqrln @addaleax
repl: improve require() autocompletion
5a8862b 
Currently REPL supports autocompletion for core modules and those found
in node_modules.  This commit adds tab completion for modules relative
to the current directory.

Backport-PR-URL: #14525
Backport-Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: #14409
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@aqrln

aqrln commented Jul 28, 2017

Copy link
Copy Markdown
Contributor

Oh, thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@aqrln aqrln Awaiting requested review from aqrln

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@addaleax addaleax

Labels

repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tniessen @addaleax @aqrln @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.