GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — test: fix flaky test-crypto-classes.js by bengl · Pull Request #15662 · nodejs/node

Conversation

bengl commented Sep 28, 2017

Copy link

Copy Markdown

Member

On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024.
This should be quite a bit faster, and therefore prevent the timeouts.

Fixes: #15655

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

test

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          test: fix flaky test-crypto-classes.js

fd666cd

On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024.
This should be quite a bit faster, and therefore prevent the timeouts.

Fixes: nodejs#15655

nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label

Sep 28, 2017

bengl commented Sep 28, 2017

Copy link

Copy Markdown

Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/10322/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mscdex added the crypto Issues and PRs related to the crypto subsystem. label

Sep 28, 2017

refack approved these changes

Sep 28, 2017

View reviewed changes

BridgeAR approved these changes

Sep 28, 2017

View reviewed changes

lpinca approved these changes

Sep 29, 2017

View reviewed changes

jasnell approved these changes

Sep 29, 2017

View reviewed changes

Trott commented Sep 29, 2017

Copy link

Copy Markdown

Member

Looks like CI didn't run on Raspberry Pi, and that's where this fix matters, so here's another CI: https://ci.nodejs.org/job/node-test-pull-request/10342/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Trott commented Sep 29, 2017

Copy link

Copy Markdown

Member

CI is green for Raspberry Pi devices. Other failures in CI are unrelated. Anyone besides me OK with an expedited landing?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Trott approved these changes

Sep 29, 2017

View reviewed changes

jasnell pushed a commit that referenced this pull request

Oct 1, 2017


          test: fix flaky test-crypto-classes.js

3e4f34c

On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024.
This should be quite a bit faster, and therefore prevent the timeouts.

PR-URL: #15662
Fixes: #15655
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

jasnell commented Oct 1, 2017

Copy link

Copy Markdown

Member

Landed in 3e4f34c

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell closed this

Oct 1, 2017

addaleax pushed a commit to addaleax/ayo that referenced this pull request

Oct 4, 2017


          test: fix flaky test-crypto-classes.js

d86e347

On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024.
This should be quite a bit faster, and therefore prevent the timeouts.

PR-URL: nodejs/node#15662
Fixes: nodejs/node#15655
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

MylesBorins mentioned this pull request

Oct 10, 2017

crypto: expose ECDH class #8188

Closed

3 tasks done

MylesBorins added the backport-requested-v8.x label

Oct 10, 2017

MylesBorins commented Oct 10, 2017

Copy link

Copy Markdown

Contributor

This will need to be backported with #8188

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bengl mentioned this pull request

Oct 17, 2017

[v8.x backport] crypto: expose ECDH class #16245

Closed

bengl added a commit to bengl/node that referenced this pull request

Oct 17, 2017


          test: fix flaky test-crypto-classes.js

367116e

On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024.
This should be quite a bit faster, and therefore prevent the timeouts.

PR-URL: nodejs#15662
Fixes: nodejs#15655
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

evanlucas pushed a commit that referenced this pull request

Oct 23, 2017


          test: fix flaky test-crypto-classes.js

e0e5c89

On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024.
This should be quite a bit faster, and therefore prevent the timeouts.

Backport-PR-URL: #16245
PR-URL: #15662
Fixes: #15655
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

lance added backported-to-v8.x and removed backport-requested-v8.x labels

Oct 28, 2017

MylesBorins added baking-for-lts

PRs whose changes need more time before an LTS backport.

lts-watch-v6.x labels

Nov 16, 2017

MylesBorins pushed a commit that referenced this pull request

Jan 16, 2018


          test: fix flaky test-crypto-classes.js

f1f3377

On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024.
This should be quite a bit faster, and therefore prevent the timeouts.

Backport-PR-URL: #16245
PR-URL: #15662
Fixes: #15655
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

MylesBorins pushed a commit that referenced this pull request

Jan 17, 2018


          test: fix flaky test-crypto-classes.js

542f13f

On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024.
This should be quite a bit faster, and therefore prevent the timeouts.

Backport-PR-URL: #16245
PR-URL: #15662
Fixes: #15655
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

MylesBorins mentioned this pull request

Jan 24, 2018

v6.13.0 proposal #18342

Merged

MylesBorins pushed a commit that referenced this pull request

Feb 12, 2018


          test: fix flaky test-crypto-classes.js

c7669db

On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024.
This should be quite a bit faster, and therefore prevent the timeouts.

Backport-PR-URL: #16245
PR-URL: #15662
Fixes: #15655
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

MylesBorins pushed a commit that referenced this pull request

Feb 13, 2018


          test: fix flaky test-crypto-classes.js

365dba2

On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024.
This should be quite a bit faster, and therefore prevent the timeouts.

Backport-PR-URL: #16245
PR-URL: #15662
Fixes: #15655
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

MylesBorins removed the baking-for-lts PRs whose changes need more time before an LTS backport. label

Aug 17, 2018

Reviewers

jasnell

jasnell approved these changes

Trott

Trott approved these changes

lpinca

lpinca approved these changes

BridgeAR

BridgeAR approved these changes

+1 more reviewer

refack

refack approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

crypto

Issues and PRs related to the crypto subsystem.

test

Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test: test-crypto-classes timeout on Raspberry Pi

Uh oh!

There was an error while loading. Please reload this page.

10 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.