GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — v4.8.6 proposal by MylesBorins · Pull Request #16500 · nodejs/node

Conversation

@MylesBorins

@MylesBorins MylesBorins commented Oct 25, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

2017-11-07, Version 4.8.6 'Argon' (Maintenance), @MylesBorins

This Maintenance release comes with 47 commits. This includes 26 commits which are updates to dependencies,
8 which are build / tool related, 4 which are doc related, and 2 which are test related.

This release includes a security update to openssl that has been deemed low severity for the Node.js project.

Notable Changes

  • crypto:
    • update root certificates (Ben Noordhuis) #13279
    • update root certificates (Ben Noordhuis) #12402
  • deps:
    • add support for more modern versions of INTL (Bruno Pagani) #13040
    • upgrade openssl sources to 1.0.2m (Shigeki Ohtsu) #16691
    • upgrade openssl sources to 1.0.2l (Daniel Bevenius) #13233

Commits

  • [e064ae62e4] - build: fix make test-v8 (Ben Noordhuis) #15562
  • [a7f7a87a1b] - build: run test-hash-seed at the end of test-v8 (Michaël Zasso) #14219
  • [05e8b1b7d9] - build: codesign tarball binary on macOS (Evan Lucas) #14179
  • [e2b6fdf93e] - build: avoid /docs/api and /docs/doc/api upload (Rod Vagg) #12957
  • [59d35c0775] - build,tools: do not force codesign prefix (Evan Lucas) #14179
  • [210fa72e9e] - crypto: update root certificates (Ben Noordhuis) #13279
  • [752b46a259] - crypto: update root certificates (Ben Noordhuis) #12402
  • [3640ba4acb] - crypto: clear err stack after ECDH::BufferToPoint (Ryan Kelly) #13275
  • [545235fc4b] - deps: add missing #include "unicode/normlzr.h" (Bruno Pagani) #13040
  • [ea09a1c3e6] - deps: update openssl asm and asm_obsolete files (Shigeki Ohtsu) #16691
  • [68661a95b5] - deps: add -no_rand_screen to openssl s_client (Shigeki Ohtsu) nodejs/io.js#1836
  • [bdcb2525fb] - deps: fix asm build error of openssl in x86_win32 (Shigeki Ohtsu) iojs/io.js#1389
  • [3f93ffee89] - deps: fix openssl assembly error on ia32 win32 (Fedor Indutny) iojs/io.js#1389
  • [16fbd9da0d] - deps: copy all openssl header files to include dir (Shigeki Ohtsu) #16691
  • [55e15ec820] - deps: upgrade openssl sources to 1.0.2m (Shigeki Ohtsu) #16691
  • [9c3e246ffe] - deps: backport 4e18190 from V8 upstream (jshin) #15562
  • [43d1ac3a62] - deps: backport bff3074 from V8 upstream (Myles Borins) #15562
  • [b259fd3bd5] - deps: cherry pick d7f813b4 from V8 upstream (akos.palfi) #15562
  • [85800c4ba4] - deps: backport e28183b5 from upstream V8 (karl) #15562
  • [06eb181916] - deps: update openssl asm and asm_obsolete files (Daniel Bevenius) #13233
  • [c0fe1fccc3] - deps: update openssl config files (Daniel Bevenius) #13233
  • [523eb60424] - deps: add -no_rand_screen to openssl s_client (Shigeki Ohtsu) nodejs/io.js#1836
  • [0aacd5a8cd] - deps: fix asm build error of openssl in x86_win32 (Shigeki Ohtsu) iojs/io.js#1389
  • [80c48c0720] - deps: fix openssl assembly error on ia32 win32 (Fedor Indutny) iojs/io.js#1389
  • [bbd92b4676] - deps: copy all openssl header files to include dir (Daniel Bevenius) #13233
  • [8507f0fb5d] - deps: upgrade openssl sources to 1.0.2l (Daniel Bevenius) #13233
  • [9bfada8f0c] - deps: add example of comparing OpenSSL changes (Daniel Bevenius) #13234
  • [71f9cdf241] - deps: cherry-pick 09db540,686558d from V8 upstream (Jesse Rosenberger) #14829
  • [751f1ac08e] - Revert "deps: backport e093a04, 09db540 from upstream V8" (Jesse Rosenberger) #14829
  • [ed6298c7de] - deps: cherry-pick 18ea996 from c-ares upstream (Anna Henningsen) #13883
  • [639180adfa] - deps: update openssl asm and asm_obsolete files (Shigeki Ohtsu) #12913
  • [9ba73e1797] - deps: cherry-pick 4ae5993 from upstream OpenSSL (Shigeki Ohtsu) #12913
  • [f8e282e51c] - doc: fix typo in zlib.md (Luigi Pinca) #16480
  • [532a2941cb] - doc: add missing make command to UPGRADING.md (Daniel Bevenius) #13233
  • [1db33296cb] - doc: add entry for subprocess.killed property (Rich Trott) #14578
  • [0fa09dfd77] - doc: change child to subprocess (Rich Trott) #14578
  • [43bbfafaef] - docs: Fix broken links in crypto.md (Zuzana Svetlikova) #15182
  • [1bde7f5cef] - openssl: fix keypress requirement in apps on win32 (Shigeki Ohtsu) iojs/io.js#1389
  • [e69f47b686] - openssl: fix keypress requirement in apps on win32 (Shigeki Ohtsu) iojs/io.js#1389
  • [cb92f93cd5] - test: remove internal headers from addons (Gibson Fahnestock) #7947
  • [5d9164c315] - test: move test-cluster-debug-port to sequential (Oleksandr Kushchak) #16292
  • [07c912e849] - tools: update certdata.txt (Ben Noordhuis) #13279
  • [c40bffcb88] - tools: update certdata.txt (Ben Noordhuis) #12402
  • [161162713f] - tools: be explicit about including key-id (Myles Borins) #13309
  • [0c820c092b] - v8: fix stack overflow in recursive method (Ben Noordhuis) #12460
  • [a1f992975f] - zlib: fix crash when initializing failed (Anna Henningsen) #14666
  • [31bf595b94] - zlib: fix node crashing on invalid options (Alexey Orlenko) #13098

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

abernix reacted with heart emoji
All reactions
  • ❤️ 1 reaction
ArchangeGabriel and others added 30 commits October 25, 2017 04:22
@ArchangeGabriel @MylesBorins
deps/v8: add missing #include "unicode/normlzr.h"
545235f
* The following function from <unicode/normlzr.h> is used:
     normalize()

* Until ICU 59, <unicode/normlzr.h> is indirectly included, but this changed with the 59 release. Adding this header has been the right thing to do for many years, so it is backwards compatible and fix compilation with recent ICU.

Refs: #13022
PR-URL: #13040
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@shigeki @MylesBorins
deps: cherry-pick 4ae5993 from upstream OpenSSL
9ba73e1
This fixes wrong hash results on Windows with some CPUs that support
Intel SHA Extension and resolves the issue of TLS connection errors.

After upgrading forthcoming openssl-1.0.2l, this is no nolonger needed.

  Original commit message:

    perlasm/x86_64-xlate.pl: work around problem with hex constants in masm.

    Perl, multiple versions, for some reason occasionally takes issue with
    letter b[?] in ox([0-9a-f]+) regex. As result some constants, such as
    0xb1 came out wrong when generating code for MASM. Fixes GH#3241.

    Reviewed-by: Rich Salz <[email protected]>
    (Merged from openssl/openssl#3385)

    (cherry picked from commit c47aea8af1e28e46e1ad5e2e7468b49fec3f4f29)

Refs: openssl/openssl#3241
Refs: openssl/openssl#3385
Fixes: #12691
PR-URL: #12913
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@shigeki @MylesBorins
deps: update openssl asm and asm_obsolete files
639180a
Regenerate asm files according to the fix of
openssl/crypto/perlasm/x86_64-xlate.pl.

Fixes: #12691
PR-URL: #12913
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@bnoordhuis @MylesBorins
v8: fix stack overflow in recursive method
0c820c0
HGlobalValueNumberingPhase::CollectSideEffectsOnPathsToDominatedBlock()
used to self-recurse before this commit, causing stack overflows on
systems with small stack sizes.  Make it non-recursive by storing
intermediate results in a heap-allocated list.

Fixes: #11991
Backport-PR-URL: #13080
PR-URL: #12460
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yang Guo <[email protected]>
@rfk @MylesBorins
crypto: clear err stack after ECDH::BufferToPoint
3640ba4
Functions that call `ECDH::BufferToPoint` were not clearing the
error stack on failure, so an invalid key could leave leftover
error state and cause subsequent (unrelated) signing operations
to fail.

PR-URL: #13275
Backport-PR-URL: #13399
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@rvagg @MylesBorins
build: avoid /docs/api and /docs/doc/api upload
e2b6fdf
Fixes: #12833
PR-URL: #12957
Reviewed-By: João Reis <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@MylesBorins
tools: be explicit about including key-id
1611627
gpg 2.1 no longer includes the key-id by default which breaks
the release script. This makes sure we are explicit about it.

PR-URL: #13309
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott @MylesBorins
doc: change child to subprocess
0fa09df
Backport-PR-URL: #14635
PR-URL: #14578
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@Trott @MylesBorins
doc: add entry for subprocess.killed property
1db3329
Backport-PR-URL: #14635
PR-URL: #14578
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@evanlucas @MylesBorins
build,tools: do not force codesign prefix
59d35c0
Allow passing the prefix in via the PKGDIR env var. This will allow us
to use this same script to codesign the binary tarball.

PR-URL: #14179
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@evanlucas @MylesBorins
build: codesign tarball binary on macOS
05e8b1b
Previously, we were signing the binary that was released in the .pkg,
but not the binary released in the tarball.

PR-URL: #14179
Fixes: #11936
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax @MylesBorins
deps: cherry-pick 18ea996 from c-ares upstream
ed6298c
Original commit message:

    ares_parse_naptr_reply: make buffer length check more accurate

    9478908a490a6bf009ba58d81de8c1d06d50a117 introduced a length check
    for records parsed by `ares_parse_naptr_reply()`. However, that
    function is designed to parse replies which also contain non-NAPTR
    records; for A records, the `rr_len > 7` check will fail as there
    are only 4 bytes of payload.
    In particular, parsing ANY replies for NAPTR records was broken
    by that patch.

    Fix that by moving the check into the case in which it is already
    known that the record is a NAPTR record.

Ref: c-ares/c-ares@18ea996
PR-URL: #13883
Reviewed-By: James M Snell <[email protected]>
@bnoordhuis @MylesBorins
tools: update certdata.txt
c40bffc
This is the certdata.txt[0] that ships in NSS 3.28.1, released on
2017-01-04.

[0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_28_1_RTM/lib/ckfw/builtins/certdata.txt

PR-URL: #12402
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
@bnoordhuis @MylesBorins
crypto: update root certificates
752b46a
Update the list of root certificates in src/node_root_certs.h with
tools/mk-ca-bundle.pl.

Certificates added:
- AC RAIZ FNMT-RCM
- Amazon Root CA 1
- Amazon Root CA 2
- Amazon Root CA 3
- Amazon Root CA 4
- Certplus Root CA G1
- Certplus Root CA G2
- Hellenic Academic and Research Institutions ECC RootCA 2015
- Hellenic Academic and Research Institutions RootCA 2015
- ISRG Root X1
- LuxTrust Global Root 2
- OpenTrust Root CA G1
- OpenTrust Root CA G2
- OpenTrust Root CA G3

Certificates removed:
- Buypass Class 2 CA 1
- EBG Elektronik Sertifika Hizmet Sağlayıcısı
- IGC/A
- Juur-SK
- RSA Security 2048 v3
- Root CA Generalitat Valenciana

PR-URL: #12402
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
@bnoordhuis @MylesBorins
tools: update certdata.txt
07c912e
This is the certdata.txt[0] that ships in NSS 3.30.2, released on
2017-04-20.

[0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_30_2_RTM/lib/ckfw/builtins/certdata.txt

PR-URL: #13279
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@bnoordhuis @MylesBorins
crypto: update root certificates
210fa72
Update the list of root certificates in src/node_root_certs.h with
tools/mk-ca-bundle.pl.

Certificates added:
- TUBITAK Kamu SM SSL Kok Sertifikasi - Surum 1

Certificates removed:
- ApplicationCA - Japanese Government
- Microsec e-Szigno Root CA
- TÜRKTRUST Elektronik Sertifika Hizmet Sağlayıcısı H6
- WellsSecure Public Root Certificate Authority

PR-URL: #13279
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@abernix @MylesBorins
Revert "deps: backport e093a04, 09db540 from upstream V8"
751f1ac
This reverts commit 2d07fd7, with the
exception of the `V8_PATCH_LEVEL` which will continue to increase.

This commit was intended to be a backport of v8's e093a04 and 09db540,
but it failed to consider the reversion of e093a04 in 5f5a328.

PR-URL: #14829
Reviewed-By: Ben Noordhuis <[email protected]>
@abernix @MylesBorins
deps: cherry-pick 09db540,686558d from V8 upstream
71f9cdf
Original commit messages:
v8/v8@09db540
  Reland of Rehash and clear deleted entries in weak collections during GC

  BUG=v8:4909
  [email protected],[email protected]
  LOG=n

  Review URL: https://codereview.chromium.org/1890123002

  Cr-Commit-Position: refs/heads/master@{#35538}

v8/v8@686558d
  Fix comment about when we rehash ObjectHashTables before growing them

  [email protected]
  BUG=

  Review-Url: https://codereview.chromium.org/1918403003
  Cr-Commit-Position: refs/heads/master@{#35853}

Refs: https://crbug.com/v8/4909
Refs: #6180
Refs: #7689
Refs: #6398
Fixes: #14228

PR-URL: #14829
Reviewed-By: Ben Noordhuis <[email protected]>
@danbev @MylesBorins
deps: add example of comparing OpenSSL changes
9bfada8
When upgrading OpenSSL, Step 6 in upgrading guide explains the steps
that need to be taken if asm files need updating. This might not
always be the case and something that needs to be checked from
release to release.

This commit adds an example of using github to manually compare two tags
to see if any changes were made to asm files.

Backport-PR-URL: #13696
PR-URL: #13234
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@danbev @MylesBorins
deps: upgrade openssl sources to 1.0.2l
8507f0f
This replaces all sources of openssl-1.0.2l.tar.gz into
deps/openssl/openssl

Fixes: #13161
Backport-PR-URL: #13696
PR-URL: #13233
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@danbev @MylesBorins
deps: copy all openssl header files to include dir
bbd92b4
All symlink files in deps/openssl/openssl/include/openssl/ are removed
and replaced with real header files to avoid issues on Windows. Two
files of opensslconf.h in crypto and include dir are replaced to refer
config/opensslconf.h.

Fixes: #13161
Backport-PR-URL: #13696
PR-URL: #13233
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@indutny @MylesBorins
deps: fix openssl assembly error on ia32 win32
80c48c0
`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and
perhaps others) are requiring .686 .

Fixes: #589
Backport-PR-URL: #13696
PR-URL: #1389
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
Shigeki Ohtsu @MylesBorins
deps: fix asm build error of openssl in x86_win32
0aacd5a
See
https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html

iojs needs to stop using masm and move to nasm or yasm on Win32.

Fixes: #589
Backport-PR-URL: #13696
PR-URL: #1389
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Shigeki Ohtsu @MylesBorins
openssl: fix keypress requirement in apps on win32
e69f47b
Reapply b910613 .

Fixes: #589
Backport-PR-URL: #13696
PR-URL: #1389
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Shigeki Ohtsu @MylesBorins
deps: add -no_rand_screen to openssl s_client
523eb60
In openssl s_client on Windows, RAND_screen() is invoked to initialize
random state but it takes several seconds in each connection.
This added -no_rand_screen to openssl s_client on Windows to skip
RAND_screen() and gets a better performance in the unit test of
test-tls-server-verify.
Do not enable this except to use in the unit test.

Fixes: #1461
Backport-PR-URL: #13696
PR-URL: #1836
Reviewed-By: Ben Noordhuis <[email protected]>
@danbev @MylesBorins
deps: update openssl config files
c0fe1fc
Regenerate config files for supported platforms with Makefile.

Fixes: #13161
Backport-PR-URL: #13696
PR-URL: #13233
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@danbev @MylesBorins
deps: update openssl asm and asm_obsolete files
06eb181
Regenerate asm files with Makefile and CC=gcc and ASM=nasm where gcc
version was 5.4.0 and nasm version was 2.11.08.

Also asm files in asm_obsolete dir to support old compiler and
assembler are regenerated without CC and ASM envs.

Fixes: #13161
Backport-PR-URL: #13696
PR-URL: #13233
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@danbev @MylesBorins
doc: add missing make command to UPGRADING.md
532a294
Added the missing make command in steps 6.3 when building
asm_obsolete.

Also updated the commit message to include the version nasm in
addition to the gcc version.

Fixes: #13161
Backport-PR-URL: #13696
PR-URL: #13233
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@aqrln @MylesBorins
zlib: fix node crashing on invalid options
31bf595
This is a partial backport of semver-patch bits of
9e4660b.

This commit fixes the Node process crashing when constructors of classes
of the zlib module are given invalid options.

* Throw an Error when the zlib library rejects the value of windowBits,
  instead of crashing with an assertion.

* Treat windowBits and memLevel options consistently with other ones and
  don't crash when non-numeric values are given.

Backport-PR-URL: #14860
PR-URL: #13098
Fixes: #13082
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@addaleax @MylesBorins
zlib: fix crash when initializing failed
a1f9929
Unset `mode_` when initializing the zlib stream failed, so that
we don’t try to call the zlib end functions (`deflateEnd()` etc.)
when cleaning up in `ZCtx::Close()`.

Fixes: #14178
Ref: #13098
Backport-PR-URL: #14860
PR-URL: #14666
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
@MylesBorins MylesBorins added the v4.x label Oct 25, 2017
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. meta Issues and PRs related to the general management of the project. openssl Issues and PRs related to the OpenSSL dependency. v4.x labels Oct 25, 2017
@MylesBorins

MylesBorins commented Oct 25, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/10983/
citgm: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1029/
rc.1: https://nodejs.org/download/rc/v4.8.6-rc.1/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gibfahn and others added 8 commits November 2, 2017 17:51
@gibfahn @MylesBorins
test: remove internal headers from addons
cb92f93
Backport-PR-URL: #16550
PR-URL: #7947
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@shigeki @MylesBorins
deps: upgrade openssl sources to 1.0.2m
55e15ec
This replaces all sources of openssl-1.0.2m.tar.gz into
deps/openssl/openssl

PR-URL: #16691
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@shigeki @MylesBorins
deps: copy all openssl header files to include dir
16fbd9d
All symlink files in `deps/openssl/openssl/include/openssl/`
are removed and replaced with real header files to avoid
issues on Windows. Two files of opensslconf.h in crypto and
include dir are replaced to refer config/opensslconf.h.

PR-URL: #16691
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@indutny @MylesBorins
deps: fix openssl assembly error on ia32 win32
3f93ffe
`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and
perhaps others) are requiring .686 .

Fixes: #589
PR-URL: #1389
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
Shigeki Ohtsu @MylesBorins
deps: fix asm build error of openssl in x86_win32
bdcb252
See
https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html

iojs needs to stop using masm and move to nasm or yasm on Win32.

Fixes: #589
PR-URL: #1389
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Shigeki Ohtsu @MylesBorins
openssl: fix keypress requirement in apps on win32
1bde7f5
Reapply b910613 .

Fixes: #589
PR-URL: #1389
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Shigeki Ohtsu @MylesBorins
deps: add -no_rand_screen to openssl s_client
68661a9
In openssl s_client on Windows, RAND_screen() is invoked to initialize
random state but it takes several seconds in each connection.
This added -no_rand_screen to openssl s_client on Windows to skip
RAND_screen() and gets a better performance in the unit test of
test-tls-server-verify.
Do not enable this except to use in the unit test.

Fixes: #1461
PR-URL: #1836
Reviewed-By: Ben Noordhuis <[email protected]>
@shigeki @MylesBorins
deps: update openssl asm and asm_obsolete files
ea09a1c
Regenerate asm files with Makefile and CC=gcc and ASM=nasm where gcc
version was 5.4.0 and nasm version was 2.11.08.

Also asm files in asm_obsolete dir to support old compiler and
assembler are regenerated without CC and ASM envs.

PR-URL: #16691
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins
MylesBorins force-pushed the v4.8.6-proposal branch from 24a1610 to 01d174e Compare November 3, 2017 18:06
@MylesBorins

MylesBorins commented Nov 3, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/11176/
citgm: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1059/
rc.2: https://nodejs.org/download/rc/v4.8.6-rc.2/

v4.8.5 citgm for comparison: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1060/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jasnell

jasnell commented Nov 3, 2017

Copy link
Copy Markdown
Member

Really not a fan of doing releases on a Friday. Can these wait until Monday?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MylesBorins MylesBorins mentioned this pull request Nov 4, 2017
November 7th release for all lines nodejs/Release#282
Closed
@MylesBorins

MylesBorins commented Nov 6, 2017

Copy link
Copy Markdown
Contributor Author

CITGM is not as green as I couldn't find new failures as compared to the previous release that were not infrastructure related.

A large number of the failures are timeouts, and I believe that is mostly due to snapshots being turned off

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MylesBorins
MylesBorins force-pushed the v4.8.6-proposal branch from 01d174e to 8bf35b9 Compare November 6, 2017 20:30
@MylesBorins
2017-11-07, Version 4.8.6 'Argon' (Maintenance)
449d60d
Notable Changes:

* **crypto**:
  - update root certificates (Ben Noordhuis)
    #13279
  - update root certificates (Ben Noordhuis)
    #12402
* **deps**:
  - add support for more modern versions of INTL (Bruno Pagani)
    #13040
  - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
    #16691
  - upgrade openssl sources to 1.0.2l (Daniel Bevenius)
    #13233

PR-URL: #16500
@MylesBorins
MylesBorins force-pushed the v4.8.6-proposal branch from 8bf35b9 to 449d60d Compare November 6, 2017 20:31
@MylesBorins

MylesBorins commented Nov 6, 2017

Copy link
Copy Markdown
Contributor Author

Hey all, I've updated the PR with notable changes. Please lmk if you think there should be any changes made.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MylesBorins
MylesBorins merged commit 449d60d into v4.x Nov 7, 2017
MylesBorins added a commit that referenced this pull request Nov 7, 2017
@MylesBorins
Working on v4.8.7
a7c4fab
PR-URL: #16500
MylesBorins added a commit that referenced this pull request Nov 7, 2017
@MylesBorins
2017-11-07, Version 4.8.6 'Argon' (Maintenance)
16b1faa
Notable Changes:

* **crypto**:
  - update root certificates (Ben Noordhuis)
    #13279
  - update root certificates (Ben Noordhuis)
    #12402
* **deps**:
  - add support for more modern versions of INTL (Bruno Pagani)
    #13040
  - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
    #16691
  - upgrade openssl sources to 1.0.2l (Daniel Bevenius)
    #13233

PR-URL: #16500
@MylesBorins MylesBorins mentioned this pull request Nov 7, 2017
blog: add release post for 4.8.6 and 6.12.0 nodejs/nodejs.org#1453
Merged
@gibfahn
gibfahn deleted the v4.8.6-proposal branch November 13, 2017 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. meta Issues and PRs related to the general management of the project. openssl Issues and PRs related to the OpenSSL dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

@MylesBorins @jasnell @nodejs-github-bot @ArchangeGabriel @shigeki @bnoordhuis @rfk @rvagg @Trott @evanlucas @addaleax @abernix @danbev @indutny @aqrln @targos @skomski @jungshik @Oleksandr-Kushchak-i2 @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.