GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix a typo in the documentation by mamatha-jv · Pull Request #16909 · nodejs/node

Conversation

@mamatha-jv

@mamatha-jv mamatha-jv commented Nov 10, 2017

Copy link
Copy Markdown
Contributor
Checklist
  • [x ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • [x ] documentation is changed or added
  • [ x] commit message follows commit guidelines
Affected core subsystem(s)

Trivial typo correction, this is my first PR to nodejs repo, Thanks in Advance!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pushkarnk and maclover7 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@mamatha-jv
doc: fix a typo in the documentation
25189ae
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Nov 10, 2017
apapirovski
apapirovski approved these changes Nov 10, 2017
View reviewed changes

@apapirovski apapirovski left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
gireeshpunathil
gireeshpunathil approved these changes Nov 10, 2017
View reviewed changes

@gireeshpunathil gireeshpunathil left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trivial change, fast-track candidate.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 10, 2017
gireeshpunathil pushed a commit that referenced this pull request Nov 10, 2017
@mamatha-jv @gireeshpunathil
doc: fix a typo in the documentation
7af469a 
PR-URL: #16909
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@gireeshpunathil

gireeshpunathil commented Nov 10, 2017

Copy link
Copy Markdown
Member

Landed in 7af469a , thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gireeshpunathil gireeshpunathil closed this Nov 10, 2017
evanlucas pushed a commit that referenced this pull request Nov 13, 2017
@mamatha-jv @evanlucas
doc: fix a typo in the documentation
e60eff6 
PR-URL: #16909
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@evanlucas evanlucas mentioned this pull request Nov 13, 2017
v9.2.0 proposal #16992
Merged
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
@mamatha-jv @MylesBorins
doc: fix a typo in the documentation
adb8f08 
PR-URL: #16909
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@MylesBorins MylesBorins added dont-land-on-v6.x labels Nov 17, 2017
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
v8.9.2 proposal #17204
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
+1 more reviewer
@apapirovski apapirovski apapirovski approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@mamatha-jv @gireeshpunathil @apapirovski @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.