GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: add test description to fs.readFile tests by davisjam · Pull Request #17610 · nodejs/node

Conversation

@davisjam

@davisjam davisjam commented Dec 11, 2017

Copy link
Copy Markdown
Contributor

See #17054 here.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@davisjam
Add test description to fs.readFile tests
c5b0512
See nodejs#17054 (comment)
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Dec 11, 2017
@davisjam davisjam changed the title Add test description to fs.readFile tests test: add test description to fs.readFile tests Dec 11, 2017
addaleax
addaleax approved these changes Dec 11, 2017
View reviewed changes

@addaleax addaleax left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@addaleax addaleax added fast-track PRs proposed for a shorter-than-standard waiting period before landing. fs Issues and PRs related to file-system APIs and the fs module. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Dec 11, 2017
evanlucas
evanlucas approved these changes Dec 11, 2017
View reviewed changes
cjihrig
cjihrig approved these changes Dec 11, 2017
View reviewed changes
Fishrock123
Fishrock123 approved these changes Dec 11, 2017
View reviewed changes
maclover7
maclover7 approved these changes Dec 11, 2017
View reviewed changes
@maclover7

maclover7 commented Dec 11, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/12044/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@davisjam

davisjam commented Dec 11, 2017

Copy link
Copy Markdown
Contributor Author

I still haven't figured out how to drill through Jenkins to find the console output for the CI failure.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott

Trott commented Dec 12, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I still haven't figured out how to drill through Jenkins to find the console output for the CI failure.

@davisjam In this case:

  • go to the bottom center of the CI page and follow the link that says build #14753 (to the right of node-test-commit)
  • scroll to the bottom of the resulting page and find the one that failed (with a white exclamation point inside a red circle), in this case node-test-commit-plinux. Follow the link to the right of it that says build #13879
  • once again, on the resulting page, scroll to the bottom and look at the bottom center to find the host that failed (again, denoted by an exclamation point). In this case, it's ppcle-ubuntu1404. Follow that link.
  • On the resulting page, you now have two options. For a nifty readable interface, select "Console Output" from the list of links on the left side. There's also a plain text option "View as plain text" under that "Console Output" link. In this particular case, it looks like the build failed during the compilation of addons or something like that. No tests were run. Or something weird happened anyway:
make: *** [run-ci] Error 2
Process leaked file descriptors. See https://jenkins.io/redirect/troubleshooting/process-leaked-file-descriptors for more information

@nodejs/build FYI on that build failure (for anyone that wants to investigate mysterious build failures, no need to comment here, although feel free to open an issue in nodejs/build or wherever of course!).

Just in case it really is a problem with this PR (which seems highly unlikely), here's a re-run:
https://ci.nodejs.org/job/node-test-commit-plinux/13885/

@davisjam If the instructions for getting to the console output above don't work for you, let me know what step you got stuck on and I'll try to provide a screenshot or something.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BridgeAR
BridgeAR approved these changes Dec 12, 2017
View reviewed changes
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Dec 12, 2017
@davisjam @BridgeAR
test: add test description to fs.readFile tests
dd2200e
PR-URL: nodejs#17610
Refs: nodejs#17054 (comment)
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR

BridgeAR commented Dec 12, 2017

Copy link
Copy Markdown
Member

Thanks a lot. Landed in dd2200e

@davisjam please note that the commit message was not according to the commit guidlines that are linked in the the PR. I added the subsystem accordingly.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@BridgeAR BridgeAR closed this Dec 12, 2017
@davisjam

davisjam commented Dec 12, 2017

Copy link
Copy Markdown
Contributor Author

@BridgeAR Thank you for fixing that. I'll try to be more careful.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@davisjam

davisjam commented Dec 12, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@Trott Thanks for the guide. I see the failure now. Definitely not my fault :-)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@addaleax addaleax removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 13, 2017
MylesBorins pushed a commit that referenced this pull request Dec 20, 2017
@davisjam @MylesBorins
test: add test description to fs.readFile tests
a6f95d1
PR-URL: #17610
Refs: #17054 (comment)
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2017
@davisjam @MylesBorins
test: add test description to fs.readFile tests
bc7dc65
PR-URL: #17610
Refs: #17054 (comment)
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
v9.4.0 proposal #18069
Merged
@MylesBorins MylesBorins added land-on-v6.x labels Jan 22, 2018
MylesBorins pushed a commit that referenced this pull request Jan 22, 2018
@davisjam @MylesBorins
test: add test description to fs.readFile tests
aada57b
PR-URL: #17610
Refs: #17054 (comment)
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 22, 2018
@davisjam @MylesBorins
test: add test description to fs.readFile tests
d181977
PR-URL: #17610
Refs: #17054 (comment)
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2018
v6.13.0 proposal #18342
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@davisjam @MylesBorins
test: add test description to fs.readFile tests
e2aa052
PR-URL: #17610
Refs: #17054 (comment)
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@davisjam @MylesBorins
test: add test description to fs.readFile tests
3e8002d
PR-URL: #17610
Refs: #17054 (comment)
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@davisjam @MylesBorins
test: add test description to fs.readFile tests
b3b2456
PR-URL: #17610
Refs: #17054 (comment)
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@cjihrig cjihrig cjihrig approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
+3 more reviewers
@evanlucas evanlucas evanlucas approved these changes
@Fishrock123 Fishrock123 Fishrock123 approved these changes
@maclover7 maclover7 maclover7 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. fs Issues and PRs related to file-system APIs and the fs module. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@davisjam @maclover7 @Trott @BridgeAR @evanlucas @addaleax @Fishrock123 @cjihrig @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.