GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||
GeezerVison is showing github.com — test: add test description to fs.readFile tests by davisjam · Pull Request #17610 · nodejs/node Conversation
Contributor
Checklist
Affected core subsystem(s)test
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
addaleax
approved these changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Awesome, thanks!
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
evanlucas
approved these changes
cjihrig
approved these changes
Fishrock123
approved these changes
maclover7
approved these changes
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
@davisjam In this case:
make: *** [run-ci] Error 2 Process leaked file descriptors. See https://jenkins.io/redirect/troubleshooting/process-leaked-file-descriptors for more information @nodejs/build FYI on that build failure (for anyone that wants to investigate mysterious build failures, no need to comment here, although feel free to open an issue in nodejs/build or wherever of course!). Just in case it really is a problem with this PR (which seems highly unlikely), here's a re-run: @davisjam If the instructions for getting to the console output above don't work for you, let me know what step you got stuck on and I'll try to provide a screenshot or something. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
PR-URL: nodejs#17610 Refs: nodejs#17054 (comment) Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
Thanks a lot. Landed in dd2200e @davisjam please note that the commit message was not according to the commit guidlines that are linked in the the PR. I added the subsystem accordingly. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@BridgeAR Thank you for fixing that. I'll try to be more careful. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@Trott Thanks for the guide. I see the failure now. Definitely not my fault :-) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
PR-URL: #17610 Refs: #17054 (comment) Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #17610 Refs: #17054 (comment) Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #17610 Refs: #17054 (comment) Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #17610 Refs: #17054 (comment) Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #17610 Refs: #17054 (comment) Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #17610 Refs: #17054 (comment) Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #17610 Refs: #17054 (comment) Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.