GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix AttributeError: __exit__ on Python 2.6 by dkasyanov · Pull Request #17663 · nodejs/node

Conversation

@dkasyanov

@dkasyanov dkasyanov commented Dec 13, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Error occurs while dealing with Tar archives

To reproduce run ./configure --with-intl=full-icu --with-icu-source=icu4c-60_1-src.tgz

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dkasyanov @cl-dkasyanov
Fix AttributeError: __exit__ on Python 2.6
f2bfaf8 
Error occurs while dealing with Tar archives
@maclover7

maclover7 commented Dec 13, 2017

Copy link
Copy Markdown
Contributor

cc @srl295
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Dec 13, 2017
View reviewed changes
@addaleax addaleax added i18n-api Issues and PRs related to Node.js internationalization support. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory. labels Dec 13, 2017
jasnell
jasnell approved these changes Dec 14, 2017
View reviewed changes
srl295
srl295 approved these changes Dec 14, 2017
View reviewed changes
@srl295 srl295 self-assigned this Dec 14, 2017
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 27, 2017
@addaleax

addaleax commented Dec 27, 2017

Copy link
Copy Markdown
Member

@srl295 Is there a specific reason you assigned yourself for this? Should we wait for sth from you? I don't think there's anything standing in the way of landing this PR at this point...

CI: https://ci.nodejs.org/job/node-test-commit/15083/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Dec 27, 2017
View reviewed changes
cjihrig
cjihrig approved these changes Dec 27, 2017
View reviewed changes
@addaleax

addaleax commented Dec 27, 2017

Copy link
Copy Markdown
Member

Landed in b0dd43c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Dec 27, 2017
@addaleax addaleax removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 27, 2017
addaleax pushed a commit that referenced this pull request Dec 27, 2017
@dkasyanov @addaleax
tools: fix AttributeError: __exit__ on Python 2.6
b0dd43c 
Error occurs while dealing with Tar archives

PR-URL: #17663
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@dkasyanov @MylesBorins
tools: fix AttributeError: __exit__ on Python 2.6
c4b4be6 
Error occurs while dealing with Tar archives

PR-URL: #17663
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@dkasyanov @MylesBorins
tools: fix AttributeError: __exit__ on Python 2.6
6156101 
Error occurs while dealing with Tar archives

PR-URL: #17663
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@dkasyanov @MylesBorins
tools: fix AttributeError: __exit__ on Python 2.6
b89cda4 
Error occurs while dealing with Tar archives

PR-URL: #17663
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
v9.4.0 proposal #18069
Merged
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@dkasyanov @gibfahn
tools: fix AttributeError: __exit__ on Python 2.6
39d701a 
Error occurs while dealing with Tar archives

PR-URL: #17663
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@dkasyanov @gibfahn
tools: fix AttributeError: __exit__ on Python 2.6
a1d0ea5 
Error occurs while dealing with Tar archives

PR-URL: #17663
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@gibfahn gibfahn added land-on-v6.x labels Jan 24, 2018
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@dkasyanov @gibfahn
tools: fix AttributeError: __exit__ on Python 2.6
990d22e 
Error occurs while dealing with Tar archives

PR-URL: #17663
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2018
v6.13.0 proposal #18342
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@dkasyanov @MylesBorins
tools: fix AttributeError: __exit__ on Python 2.6
cba202f 
Error occurs while dealing with Tar archives

PR-URL: #17663
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@dkasyanov @MylesBorins
tools: fix AttributeError: __exit__ on Python 2.6
045956d 
Error occurs while dealing with Tar archives

PR-URL: #17663
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@dkasyanov @MylesBorins
tools: fix AttributeError: __exit__ on Python 2.6
32f528a 
Error occurs while dealing with Tar archives

PR-URL: #17663
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@srl295 srl295 srl295 approved these changes
@addaleax addaleax addaleax approved these changes
@cjihrig cjihrig cjihrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@srl295 srl295

Labels

i18n-api Issues and PRs related to Node.js internationalization support. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@dkasyanov @maclover7 @addaleax @jasnell @srl295 @cjihrig @gibfahn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.