GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: instructions on how to make membership public by mhdawson · Pull Request #17688 · nodejs/node

Conversation

@mhdawson

@mhdawson mhdawson commented Dec 14, 2017

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhdawson
doc: instructions on how to make membership public
a0da3b8
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Dec 14, 2017
@mhdawson mhdawson mentioned this pull request Dec 14, 2017
More clear indicator of key stakeholders and gatekeepers of features. nodejs/TSC#442
Closed
lpinca
lpinca approved these changes Dec 14, 2017
View reviewed changes
maclover7
maclover7 approved these changes Dec 14, 2017
View reviewed changes

@maclover7 maclover7 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, otherwise LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread doc/onboarding.md Outdated
* Branches in the nodejs/node repository are only for release lines
* [See "Updating Node.js from Upstream"](./onboarding-extras.md#updating-nodejs-from-upstream)
* Make a new branch for each PR you submit.
* Membership: We ask that collaborators make their membership in the Node.js

@maclover7 maclover7 Dec 14, 2017

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe specify GitHub membership or move into a separate GitHub section? At first is a little bit unclear.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@cjihrig cjihrig Dec 14, 2017

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, is this a request or a requirement for collaborators?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax and maclover7 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

@richardlau richardlau Dec 14, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move to near the requirement for enabling 2FA?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@addaleax addaleax Dec 14, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, the current wording makes this sound like a requirement, which is something I would be really careful about.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@jdalton jdalton Dec 14, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjihrig

Just to clarify, is this a request or a requirement for collaborators?

Having your membership public means GitHub can assign you the appropriate UI badges. As it is now...

...there's no indicator that you're part of the Node org. much less a member of the TSC or collaborator.

Your membership is already public in the sense that your name is listed here and here. This just lets GitHub do their UI thing so that users can more easily identify project maintainers.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@cjihrig cjihrig Dec 14, 2017

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know. Aren't the labels that GitHub shows next to your name in these threads, along with the list in the project's README enough?

I'm fine with a request/recommendation, but would be -1 on a hard requirement.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@jdalton jdalton Dec 14, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm saying as it is now your label is incorrect. I'm also labeled a "contributor" but I'm not part of the org (not a collaborator, TSC, or core). The "contributor" badge just means I've had at least 1 commit merged. If you were part of the org you would have the label "member" or "owner".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@cjihrig cjihrig Dec 14, 2017

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I thought you were a contributor :-)

Even still, I'm not sure that it would be a huge help. We have a members team with over 500 people that includes more people than the core collaborator list.

I'm mostly being argumentative on principle. It feels like Node would be overstepping its boundaries by requiring that collaborators make membership public. I'm a member of several other orgs, and none of them have such a requirement.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@jdalton jdalton Dec 14, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I thought you were a contributor :-)

Exactly. You proved my point 😋

The closeness of "collaborator" and "contributor" may also be part of the confusion.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott, apapirovski, and cjihrig reacted with laugh emoji
All reactions
  • 😄 3 reactions

@TimothyGu TimothyGu Dec 14, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjihrig the "Owner" next to your name is only shown if the current logged-in user is in the @ nodejs org. If I wasn't logged in, I would see "Contributor" instead.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig reacted with confused emoji
All reactions
  • 😕 1 reaction
jasnell
jasnell approved these changes Dec 14, 2017
View reviewed changes
@Trott
Update onboarding.md
3dddd0b
@Trott

Trott commented Dec 14, 2017

Copy link
Copy Markdown
Member

I updated the text a bit (capitalized Collaborators the way we do everywhere else, made it clear this is a request, etc.). PTAL. It's a separate commit so it can be reverted if it's TERRIBLE.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Dec 14, 2017
View reviewed changes

@addaleax addaleax left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current wording sounds fine to me :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
TimothyGu
TimothyGu approved these changes Dec 14, 2017
View reviewed changes
cjihrig
cjihrig approved these changes Dec 14, 2017
View reviewed changes
gireeshpunathil
gireeshpunathil approved these changes Dec 15, 2017
View reviewed changes
maclover7
maclover7 approved these changes Dec 15, 2017
View reviewed changes
@maclover7

maclover7 commented Dec 21, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/35/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BridgeAR
BridgeAR approved these changes Dec 21, 2017
View reviewed changes
@maclover7

maclover7 commented Dec 21, 2017

Copy link
Copy Markdown
Contributor

Landing...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@maclover7 maclover7 self-assigned this Dec 21, 2017
@maclover7

maclover7 commented Dec 21, 2017

Copy link
Copy Markdown
Contributor

Landed in 7a0f774
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@maclover7 maclover7 closed this Dec 21, 2017
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@mhdawson @MylesBorins
doc: instructions on how to make membership public
4f6edc9 
PR-URL: #17688
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@mhdawson @MylesBorins
doc: instructions on how to make membership public
f5ba05a 
PR-URL: #17688
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@mhdawson @MylesBorins
doc: instructions on how to make membership public
1d935a0 
PR-URL: #17688
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
v9.4.0 proposal #18069
Merged
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@mhdawson @gibfahn
doc: instructions on how to make membership public
b35ecb1 
PR-URL: #17688
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@mhdawson @gibfahn
doc: instructions on how to make membership public
7f29a98 
PR-URL: #17688
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@gibfahn gibfahn added land-on-v6.x labels Jan 24, 2018
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@mhdawson @gibfahn
doc: instructions on how to make membership public
b121d51 
PR-URL: #17688
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2018
v6.13.0 proposal #18342
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@mhdawson @MylesBorins
doc: instructions on how to make membership public
53cc120 
PR-URL: #17688
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@mhdawson @MylesBorins
doc: instructions on how to make membership public
64d30ef 
PR-URL: #17688
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@mhdawson @MylesBorins
doc: instructions on how to make membership public
722640f 
PR-URL: #17688
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@mhdawson
mhdawson deleted the membership-organization branch September 30, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau left review comments
@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
+3 more reviewers
@jdalton jdalton jdalton left review comments
@TimothyGu TimothyGu TimothyGu approved these changes
@maclover7 maclover7 maclover7 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@maclover7 maclover7

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

14 participants

@mhdawson @Trott @maclover7 @jdalton @jasnell @addaleax @lpinca @TimothyGu @cjihrig @richardlau @gireeshpunathil @BridgeAR @gibfahn @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.