GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: change callback function to arrow function by skanamaru · Pull Request #17699 · nodejs/node

Conversation

@skanamaru

@skanamaru skanamaru commented Dec 15, 2017

Copy link
Copy Markdown
Contributor

I'd like to send to pull request.
I change callback function to arrow function.

This is practice on code-and-learn for contributing oss.
nodejs/code-and-learn#78

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@skanamaru
test: change callback function to arrow function
6d59ab6
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Dec 15, 2017
yosuke-furukawa
yosuke-furukawa approved these changes Dec 15, 2017
View reviewed changes
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 15, 2017
gireeshpunathil
gireeshpunathil approved these changes Dec 15, 2017
View reviewed changes
tniessen
tniessen approved these changes Dec 15, 2017
View reviewed changes
cjihrig
cjihrig approved these changes Dec 15, 2017
View reviewed changes
maclover7
maclover7 approved these changes Dec 15, 2017
View reviewed changes
@maclover7

maclover7 commented Dec 15, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/12132/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BridgeAR
BridgeAR approved these changes Dec 15, 2017
View reviewed changes
@BridgeAR BridgeAR added author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Dec 15, 2017
@BridgeAR

BridgeAR commented Dec 15, 2017

Copy link
Copy Markdown
Member

Landed in 37d2773
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR BridgeAR closed this Dec 15, 2017
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Dec 15, 2017
@skanamaru @BridgeAR
test: change callback function to arrow function
37d2773 
PR-URL: nodejs#17699
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR

BridgeAR commented Dec 15, 2017

Copy link
Copy Markdown
Member

@skanamaru congratulations on your first commit to Node.js! 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 29, 2017
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@skanamaru @MylesBorins
test: change callback function to arrow function
90e3161 
PR-URL: #17699
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@skanamaru @MylesBorins
test: change callback function to arrow function
a9d83ce 
PR-URL: #17699
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
v9.4.0 proposal #18069
Merged
@MylesBorins MylesBorins added the dont-land-on-v6.x label Jan 23, 2018
MylesBorins pushed a commit that referenced this pull request Jan 23, 2018
@skanamaru @MylesBorins
test: change callback function to arrow function
49d2b29 
PR-URL: #17699
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins added land-on-v6.x and removed dont-land-on-v6.x labels Jan 23, 2018
MylesBorins pushed a commit that referenced this pull request Jan 23, 2018
@skanamaru @MylesBorins
test: change callback function to arrow function
b6c65af 
PR-URL: #17699
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@skanamaru @gibfahn
test: change callback function to arrow function
c81b851 
PR-URL: #17699
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2018
v6.13.0 proposal #18342
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@skanamaru @MylesBorins
test: change callback function to arrow function
6981fda 
PR-URL: #17699
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@skanamaru @MylesBorins
test: change callback function to arrow function
e0671e4 
PR-URL: #17699
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@skanamaru @MylesBorins
test: change callback function to arrow function
2d77241 
PR-URL: #17699
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes
@tniessen tniessen tniessen approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
+2 more reviewers
@yosuke-furukawa yosuke-furukawa yosuke-furukawa approved these changes
@maclover7 maclover7 maclover7 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs proposed for a shorter-than-standard waiting period before landing. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@skanamaru @maclover7 @BridgeAR @yosuke-furukawa @cjihrig @tniessen @gireeshpunathil @MylesBorins @addaleax @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.