GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: fix flaky test-http-pipeline-flood by apapirovski · Pull Request #17955 · nodejs/node

Conversation

@apapirovski

@apapirovski apapirovski commented Jan 2, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This fixes one of the issues with this test (the repeated timeout, for which there's no real reason to validate that it only occurs exactly once). Haven't been able to reproduce the other one so perhaps there was a bug that was fixed in the meantime or something. Not sure.

Refs: #16317

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@apapirovski apapirovski added the test Issues and PRs related to Node.js core tests and test infrastructure. label Jan 2, 2018
@apapirovski

apapirovski commented Jan 2, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/12391/
Stress test CI: https://ci.nodejs.org/job/node-stress-single-test/1603/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@apapirovski
apapirovski force-pushed the fix-test-http-pipeline-flood branch 2 times, most recently from 888a02f to a41fba7 Compare January 3, 2018 02:23
@apapirovski
test: fix flaky test-http-pipeline-flood
0ea2754
@apapirovski
apapirovski force-pushed the fix-test-http-pipeline-flood branch from a41fba7 to 0ea2754 Compare January 3, 2018 02:44
@apapirovski apapirovski added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 3, 2018
@apapirovski

apapirovski commented Jan 5, 2018

Copy link
Copy Markdown
Contributor Author

ping @nodejs/http @nodejs/http2 — this test fails fairly regularly so it would be nice to get it fixed. The timeout here is irrelevant to the test and is only used to stop it so having it called multiple times is completely harmless.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Jan 5, 2018
View reviewed changes
@apapirovski

apapirovski commented Jan 6, 2018

Copy link
Copy Markdown
Contributor Author

Landed in b396c4d
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@apapirovski apapirovski closed this Jan 6, 2018
@apapirovski
apapirovski deleted the fix-test-http-pipeline-flood branch January 6, 2018 17:48
apapirovski added a commit that referenced this pull request Jan 6, 2018
@apapirovski
test: fix flaky test-http-pipeline-flood
b396c4d 
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@apapirovski @MylesBorins
test: fix flaky test-http-pipeline-flood
7711f00 
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@apapirovski @MylesBorins
test: fix flaky test-http-pipeline-flood
7feabf5 
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@apapirovski @MylesBorins
test: fix flaky test-http-pipeline-flood
b313e81 
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
v9.4.0 proposal #18069
Merged
@TimothyGu TimothyGu removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 13, 2018
@BridgeAR BridgeAR mentioned this pull request Jan 15, 2018
parallel/test-http-pipeline-flood being flaky #16317
Closed
MylesBorins pushed a commit that referenced this pull request Jan 24, 2018
@apapirovski @MylesBorins
test: fix flaky test-http-pipeline-flood
edcf9ac 
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2018
@apapirovski @MylesBorins
test: fix flaky test-http-pipeline-flood
a275032 
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins added land-on-v6.x labels Jan 24, 2018
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2018
v6.13.0 proposal #18342
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@apapirovski @MylesBorins
test: fix flaky test-http-pipeline-flood
5c40881 
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@apapirovski @MylesBorins
test: fix flaky test-http-pipeline-flood
dffe0e1 
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@apapirovski @MylesBorins
test: fix flaky test-http-pipeline-flood
4473c6c 
PR-URL: #17955
Refs: #16317
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@apapirovski @jasnell @MylesBorins @TimothyGu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.