GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

GeezerVison is showing github.com — (v6.x backport) crypto: warn on invalid authentication tag length by tniessen · Pull Request #18347 · nodejs/node

Conversation

tniessen commented Jan 24, 2018

Copy link

Copy Markdown

Member

Manual backport of #17566 to v6.x.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tniessen added 2 commits

January 24, 2018 14:27


          test: use valid authentication tag length

9da580c

Using authentication tags of invalid length does not conform to NIST
standards.

PR-URL: nodejs#17566
Refs: nodejs#17523
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          crypto: warn on invalid authentication tag length

3d57549

PR-URL: nodejs#17566
Refs: nodejs#17523
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

crypto

Issues and PRs related to the crypto subsystem.

v6.x labels

tniessen mentioned this pull request

crypto: warn on invalid authentication tag length #17566

Closed

3 of 4 tasks

gibfahn assigned MylesBorins

MylesBorins commented Feb 5, 2018

Copy link

Copy Markdown

Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/12950/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MylesBorins commented Feb 7, 2018

Copy link

Copy Markdown

Contributor

So I'm thinking that this maybe should have been semver-minor on v9.x... as such we maybe shouldn't land this in v6.x or v8.x for now. It might make sense to revisit in a later semver-minor, but we had already disqualified minors from v6.4.0

@gibfahn should we back this out of v8.x?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tniessen commented Feb 7, 2018

Copy link

Copy Markdown

Member Author

@MylesBorins I don't have a strong opinion here, but this and #18376 are probably the only things we can do to prevent users from exposing themselves to inauthentic messages, so I would suggest to backport as soon as possible. cc @bnoordhuis

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MylesBorins commented Feb 10, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

landed in 076ca9f...7ed3e85

tniessen reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MylesBorins closed this

MylesBorins pushed a commit that referenced this pull request


          test: use valid authentication tag length

21c2fab

Using authentication tags of invalid length does not conform to NIST
standards.

Backport-PR-URL: #18347
PR-URL: #17566
Refs: #17523
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

MylesBorins pushed a commit that referenced this pull request


          crypto: warn on invalid authentication tag length

7ed3e85

Backport-PR-URL: #18347
PR-URL: #17566
Refs: #17523
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

MylesBorins pushed a commit that referenced this pull request


          test: use valid authentication tag length

e1bd969

Using authentication tags of invalid length does not conform to NIST
standards.

Backport-PR-URL: #18347
PR-URL: #17566
Refs: #17523
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

MylesBorins pushed a commit that referenced this pull request


          crypto: warn on invalid authentication tag length

b661570

Backport-PR-URL: #18347
PR-URL: #17566
Refs: #17523
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

MylesBorins pushed a commit that referenced this pull request


          test: use valid authentication tag length

d28fae8

Using authentication tags of invalid length does not conform to NIST
standards.

Backport-PR-URL: #18347
PR-URL: #17566
Refs: #17523
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

MylesBorins pushed a commit that referenced this pull request


          crypto: warn on invalid authentication tag length

5bdb18e

Backport-PR-URL: #18347
PR-URL: #17566
Refs: #17523
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

MylesBorins pushed a commit that referenced this pull request


          test: use valid authentication tag length

734ce67

Using authentication tags of invalid length does not conform to NIST
standards.

Backport-PR-URL: #18347
PR-URL: #17566
Refs: #17523
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

MylesBorins pushed a commit that referenced this pull request


          crypto: warn on invalid authentication tag length

691cd5a

Backport-PR-URL: #18347
PR-URL: #17566
Refs: #17523
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

Labels

c++

Issues and PRs that require attention from people who are familiar with C++.

Issues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.