GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: cover extra load-via-special-symbol scenario by gabrielschulhof · Pull Request #20186 · nodejs/node

Conversation

@gabrielschulhof

@gabrielschulhof gabrielschulhof commented Apr 21, 2018

Copy link
Copy Markdown
Contributor

We need to look for a special symbol even if the module self-registers
when the module self-registers with the wrong version.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Re #20161

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Gabriel Schulhof
src: cover extra load-via-special-symbol scenario
c951284 
We need to look for a special symbol even if the module self-registers
when the module self-registers with the wrong version.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 21, 2018
@gabrielschulhof
gabrielschulhof requested a review from bnoordhuis April 21, 2018 02:41
bnoordhuis
bnoordhuis approved these changes Apr 21, 2018
View reviewed changes
joyeecheung
joyeecheung approved these changes Apr 21, 2018
View reviewed changes
@joyeecheung

joyeecheung commented Apr 21, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/14420/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR BridgeAR added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 21, 2018
@gabrielschulhof

gabrielschulhof commented Apr 23, 2018

Copy link
Copy Markdown
Contributor Author

Landed in c1078c4.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gabrielschulhof gabrielschulhof closed this Apr 23, 2018
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 23, 2018
Gabriel Schulhof
src: cover extra load-via-special-symbol scenario
c1078c4 
We need to look for a special symbol even if the module self-registers
when the module self-registers with the wrong version.

PR-URL: nodejs#20186
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@gabrielschulhof
gabrielschulhof deleted the addon-special-symbol branch April 23, 2018 13:00
jasnell pushed a commit that referenced this pull request Apr 23, 2018
Gabriel Schulhof @jasnell
src: cover extra load-via-special-symbol scenario
6949543 
We need to look for a special symbol even if the module self-registers
when the module self-registers with the wrong version.

PR-URL: #20186
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@gabrielschulhof @joyeecheung @bnoordhuis @BridgeAR @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.