GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: remove "For example" expression in N-API doc by gabrielschulhof · Pull Request #20187 · nodejs/node

Conversation

@gabrielschulhof

@gabrielschulhof gabrielschulhof commented Apr 21, 2018

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Re #20161

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Gabriel Schulhof
doc: remove "For example" expression in N-API doc
3a994d1
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. dont-land-on-v4.x node-api Issues and PRs related to Node-API. labels Apr 21, 2018
@gabrielschulhof
gabrielschulhof requested a review from bnoordhuis April 21, 2018 02:54
Trott
Trott approved these changes Apr 21, 2018
View reviewed changes
@Trott

Trott commented Apr 21, 2018

Copy link
Copy Markdown
Member

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/562/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 21, 2018
vsemozhetbyt
vsemozhetbyt approved these changes Apr 21, 2018
View reviewed changes

@vsemozhetbyt vsemozhetbyt left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for fast-track

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vsemozhetbyt vsemozhetbyt added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Apr 21, 2018
@Trott

Trott commented Apr 21, 2018

Copy link
Copy Markdown
Member

+1 for fast-track
lpinca reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Apr 21, 2018
View reviewed changes
trivikr
trivikr approved these changes Apr 21, 2018
View reviewed changes
lpinca
lpinca approved these changes Apr 21, 2018
View reviewed changes
bnoordhuis
bnoordhuis approved these changes Apr 21, 2018
View reviewed changes
@gabrielschulhof

gabrielschulhof commented Apr 21, 2018

Copy link
Copy Markdown
Contributor Author

Landed in a71f9ba.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gabrielschulhof gabrielschulhof closed this Apr 21, 2018
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 21, 2018
Gabriel Schulhof
doc: remove "For example" expression in N-API doc
a71f9ba 
PR-URL: nodejs#20187
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@gabrielschulhof
gabrielschulhof deleted the n-api-remove-for-example branch April 21, 2018 14:24
jasnell pushed a commit that referenced this pull request Apr 23, 2018
Gabriel Schulhof @jasnell
doc: remove "For example" expression in N-API doc
3d76055 
PR-URL: #20187
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes
@trivikr trivikr trivikr approved these changes
+1 more reviewer
@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. node-api Issues and PRs related to Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@gabrielschulhof @Trott @bnoordhuis @lpinca @richardlau @vsemozhetbyt @trivikr @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.