GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — dgram and tls close() cleanup wrt. callbacks by sam-github · Pull Request #217 · nodejs/node

Conversation

@sam-github

@sam-github sam-github commented Dec 30, 2014

Copy link
Copy Markdown
Contributor
  • dgram: make 'close' event async
  • dgram: close() should accept a callback
  • doc: add tls server.close() callback docs

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sam-github

sam-github commented Dec 30, 2014

Copy link
Copy Markdown
Contributor Author

@piscisaureus Above changes may make promisification (in-core or thirdparty) smoother by increasing the number of core APIs that use the callback last convention, rather than triggering a one-time event on completion of the action. If it wasn't so late, I'd dig up the rant in the promisification thread about one-time events being an anti-pattern... I kindof agree, though I also use EE as a kind of Observer pattern, so I kindof don't. :-)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sam-github
sam-github force-pushed the dgram-close-async-emit branch 2 times, most recently from 89cba90 to 9b09606 Compare December 30, 2014 18:00
bnoordhuis
bnoordhuis reviewed Dec 30, 2014
View reviewed changes
Comment thread test/parallel/test-dgram-close.js Outdated

@bnoordhuis bnoordhuis Dec 30, 2014

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: don't check if code === 0, we don't do that anywhere else. Sorry, missed that one last time.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@sam-github sam-github Dec 30, 2014

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It avoids duplicate stack traces on failure, but sure, deleted.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
sam-github added 3 commits December 30, 2014 12:06
@sam-github
dgram: make 'close' event async
7df8969
Emit the close event asynchronously, after the close, as it is with the
net/http close events.
@sam-github
dgram: close() should accept a callback
c07fac0
Like net, http, and https server.close, and socket.end(), etc.
@sam-github
doc: add tls server.close() callback docs
61ac711
Also, tests to confirm its existence.
@sam-github
sam-github force-pushed the dgram-close-async-emit branch from 9b09606 to 61ac711 Compare December 30, 2014 20:10
bnoordhuis pushed a commit that referenced this pull request Dec 30, 2014
@sam-github @bnoordhuis
dgram: make 'close' event async
7349d7f
Emit the close event asynchronously, after the close, as it is with the
net/http close events.

PR-URL: #217
Reviewed-By: Ben Noordhuis <[email protected]>
bnoordhuis pushed a commit that referenced this pull request Dec 30, 2014
@sam-github @bnoordhuis
dgram: close() should accept a callback
63005ee
Like net, http, and https server.close, and socket.end(), etc.

PR-URL: #217
Reviewed-By: Ben Noordhuis <[email protected]>
bnoordhuis pushed a commit that referenced this pull request Dec 30, 2014
@sam-github @bnoordhuis
doc: add tls server.close() callback docs
b42c085
Also, tests to confirm its existence.

PR-URL: #217
Reviewed-By: Ben Noordhuis <[email protected]>
@bnoordhuis

bnoordhuis commented Dec 30, 2014

Copy link
Copy Markdown
Member

Cheers Sam, landed in commits 7349d7f to b42c085.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bnoordhuis bnoordhuis closed this Dec 30, 2014
@sam-github

sam-github commented Dec 30, 2014

Copy link
Copy Markdown
Contributor Author

Thanks, Ben.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sam-github
sam-github deleted the dgram-close-async-emit branch December 30, 2014 21:24
@rvagg rvagg mentioned this pull request Jan 3, 2015
governance: Add new Collaborators #234
Closed
Trott pushed a commit to npm/node that referenced this pull request Aug 20, 2019
@isaacs @Trott
deps: update npm to 6.11.0
5fb908e
Full release notes:

A few meaty bugfixes, and introducing `peerDependenciesMeta`.

FEATURES

* [`a12341088`](npm/cli@a123410)
  [nodejs#224](npm/cli#224) Implements
  peerDependenciesMeta ([@arcanis](https://github.com/arcanis))
* [`2f3b79bba`](npm/cli@2f3b79b)
  [nodejs#234](npm/cli#234) add new forbidden 403
  error code ([@claudiahdz](https://github.com/claudiahdz))

BUGFIXES

* [`24acc9fc8`](npm/cli@24acc9f)
  and
  [`45772af0d`](npm/cli@45772af)
  [nodejs#217](npm/cli#217)
  [npm.community#8863](https://npm.community/t/installing-the-same-module-under-multiple-relative-paths-fails-on-linux/8863)
  [npm.community#9327](https://npm.community/t/reinstall-breaks-after-npm-update-to-6-10-2/9327,)
  do not descend into directory deps' child modules, fix shrinkwrap
  files that inappropriately list child nodes of symlink packages
  ([@isaacs](https://github.com/isaacs) and
  [@salomvary](https://github.com/salomvary))
* [`50cfe113d`](npm/cli@50cfe11)
  [nodejs#229](npm/cli#229) fixed typo in semver doc
  ([@gall0ws](https://github.com/gall0ws))
* [`e8fb2a1bd`](npm/cli@e8fb2a1)
  [nodejs#231](npm/cli#231) Fix spelling mistakes in
  CHANGELOG-3.md ([@XhmikosR](https://github.com/XhmikosR))
* [`769d2e057`](npm/cli@769d2e0)
  [npm/uid-number#7](npm/uid-number#7) Better
  error on invalid `--user`/`--group` configs. This addresses the issue
  when people fail to install binary packages on Docker and other
  environments where there is no 'nobody' user.
  ([@isaacs](https://github.com/isaacs))
* [`8b43c9624`](npm/cli@8b43c96)
  [nodejs#28987](nodejs#28987)
  [npm.community#6032](https://npm.community/t/npm-ci-doesnt-respect-npmrc-variables/6032)
  [npm.community#6658](https://npm.community/t/npm-ci-doesnt-fill-anymore-the-process-env-npm-config-cache-variable-on-post-install-scripts/6658)
  [npm.community#6069](https://npm.community/t/npm-ci-does-not-compile-native-dependencies-according-to-npmrc-configuration/6069)
  [npm.community#9323](https://npm.community/t/npm-6-9-x-not-passing-environment-to-node-gyp-regression-from-6-4-x/9323/2)
  Fix the regression where random config values in a .npmrc file are not
  passed to lifecycle scripts, breaking build processes which rely on
  them.  ([@isaacs](https://github.com/isaacs))
* [`8b85eaa47`](npm/cli@8b85eaa)
  save files with inferred ownership rather than relying on `SUDO_UID`
  and `SUDO_GID`. ([@isaacs](https://github.com/isaacs))
* [`b7f6e5f02`](npm/cli@b7f6e5f)
  Infer ownership of shrinkwrap files
  ([@isaacs](https://github.com/isaacs))
* [`54b095d77`](npm/cli@54b095d)
  [nodejs#235](npm/cli#235) Add spec to dist-tag
  remove function ([@theberbie](https://github.com/theberbie))

DEPENDENCIES

* [`dc8f9e52f`](npm/cli@dc8f9e5)
  `[email protected]`: Infer the ownership of all unpacked files in
  `node_modules`, so that we never have user-owned files in root-owned
  folders, or root-owned files in user-owned folders.
  ([@isaacs](https://github.com/isaacs))
* [`bb33940c3`](npm/cli@bb33940)
  `[email protected]`:
  * [`9c93ac3`](npm/cmd-shim@9c93ac3)
    [#2](npm/cmd-shim#2)
    [npm#3380](npm/npm#3380) Handle
    environment variables properly
    ([@basbossink](https://github.com/basbossink))
  * [`2d277f8`](npm/cmd-shim@2d277f8)
    [nodejs#25](npm/cmd-shim#25)
    [nodejs#36](npm/cmd-shim#36)
    [nodejs#35](npm/cmd-shim#35) Fix 'no shebang' case
    by always providing `$basedir` in shell script
    ([@igorklopov](https://github.com/igorklopov))
  * [`adaf20b`](npm/cmd-shim@adaf20b)
    [nodejs#26](npm/cmd-shim#26) Fix `$*` causing an
    error when arguments contain parentheses
    ([@satazor](https://github.com/satazor))
  * [`49f0c13`](npm/cmd-shim@49f0c13)
    [nodejs#30](npm/cmd-shim#30) Fix paths for
    MSYS/MINGW bash ([@dscho](https://github.com/dscho))
  * [`51a8af3`](npm/cmd-shim@51a8af3)
    [nodejs#34](npm/cmd-shim#34) Add proper support
    for PowerShell ([@ExE-Boss](https://github.com/ExE-Boss))
  * [`4c37e04`](npm/cmd-shim@4c37e04)
    [#10](npm/cmd-shim#10) Work around quoted
    batch file names ([@isaacs](https://github.com/isaacs))
* [`a4e279544`](npm/cli@a4e2795)
  `[email protected]` ([@isaacs](https://github.com/isaacs)):
    * fail properly if `uid-number` raises an error
    * [`7086a1809`](npm/cli@7086a18)
  `[email protected]` ([@isaacs](https://github.com/isaacs))
* [`8845141f9`](npm/cli@8845141)
  `[email protected]` ([@isaacs](https://github.com/isaacs))
* [`51c028215`](npm/cli@51c0282)
  `[email protected]` ([@isaacs](https://github.com/isaacs))
* [`534a5548c`](npm/cli@534a554)
  `[email protected]` ([@isaacs](https://github.com/isaacs))
* [`3038f2fd5`](npm/cli@3038f2f)
  `[email protected]` ([@isaacs](https://github.com/isaacs))
* [`a609a1648`](npm/cli@a609a16)
  `[email protected]` ([@isaacs](https://github.com/isaacs))
* [`f0346f754`](npm/cli@f0346f7)
  `[email protected]` ([@isaacs](https://github.com/isaacs))
* [`ca9c615c8`](npm/cli@ca9c615)
  `[email protected]` ([@isaacs](https://github.com/isaacs))
* [`b417affbf`](npm/cli@b417aff)
  `[email protected]` ([@isaacs](https://github.com/isaacs))

TESTS

* [`b6df0913c`](npm/cli@b6df091)
  [nodejs#228](npm/cli#228) Proper handing of
  /usr/bin/node lifecycle-path test
  ([@olivr70](https://github.com/olivr70))
* [`aaf98e88c`](npm/cli@aaf98e8)
  `[email protected]` ([@isaacs](https://github.com/isaacs))
isaacs added a commit to npm/node that referenced this pull request Aug 21, 2019
@isaacs
deps: update npm to 6.11.1
ee11376
Full changelog:

6.11.1 (2019-08-20):

Fix a regression for windows command shim syntax.

* [`37db29647`](npm/cli@37db296)
  `[email protected]` ([@isaacs](https://github.com/isaacs))

v6.11.0 (2019-08-20):

A few meaty bugfixes, and introducing `peerDependenciesMeta`.

FEATURES

* [`a12341088`](npm/cli@a123410)
  [nodejs#224](npm/cli#224) Implements
  peerDependenciesMeta ([@arcanis](https://github.com/arcanis))
* [`2f3b79bba`](npm/cli@2f3b79b)
  [nodejs#234](npm/cli#234) add new forbidden 403 error
  code ([@claudiahdz](https://github.com/claudiahdz))

BUGFIXES

* [`24acc9fc8`](npm/cli@24acc9f)
  and
  [`45772af0d`](npm/cli@45772af)
  [nodejs#217](npm/cli#217)
  [npm.community#8863](https://npm.community/t/installing-the-same-module-under-multiple-relative-paths-fails-on-linux/8863)
  [npm.community#9327](https://npm.community/t/reinstall-breaks-after-npm-update-to-6-10-2/9327,)
  do not descend into directory deps' child modules, fix shrinkwrap files
  that inappropriately list child nodes of symlink packages
  ([@isaacs](https://github.com/isaacs) and
  [@salomvary](https://github.com/salomvary))
* [`50cfe113d`](npm/cli@50cfe11)
  [nodejs#229](npm/cli#229) fixed typo in semver doc
  ([@gall0ws](https://github.com/gall0ws))
* [`e8fb2a1bd`](npm/cli@e8fb2a1)
  [nodejs#231](npm/cli#231) Fix spelling mistakes in
  CHANGELOG-3.md ([@XhmikosR](https://github.com/XhmikosR))
* [`769d2e057`](npm/cli@769d2e0)
  [npm/uid-number#7](npm/uid-number#7) Better
  error on invalid `--user`/`--group` configs. This addresses the issue
  when people fail to install binary packages on Docker and other
  environments where there is no 'nobody' user.
  ([@isaacs](https://github.com/isaacs))
* [`8b43c9624`](npm/cli@8b43c96)
  [nodejs#28987](nodejs#28987)
  [npm.community#6032](https://npm.community/t/npm-ci-doesnt-respect-npmrc-variables/6032)
  [npm.community#6658](https://npm.community/t/npm-ci-doesnt-fill-anymore-the-process-env-npm-config-cache-variable-on-post-install-scripts/6658)
  [npm.community#6069](https://npm.community/t/npm-ci-does-not-compile-native-dependencies-according-to-npmrc-configuration/6069)
  [npm.community#9323](https://npm.community/t/npm-6-9-x-not-passing-environment-to-node-gyp-regression-from-6-4-x/9323/2)
  Fix the regression where random config values in a .npmrc file are not
  passed to lifecycle scripts, breaking build processes which rely on them.
  ([@isaacs](https://github.com/isaacs))
* [`8b85eaa47`](npm/cli@8b85eaa)
  save files with inferred ownership rather than relying on `SUDO_UID` and
  `SUDO_GID`. ([@isaacs](https://github.com/isaacs))
* [`b7f6e5f02`](npm/cli@b7f6e5f)
  Infer ownership of shrinkwrap files
  ([@isaacs](https://github.com/isaacs))
* [`54b095d77`](npm/cli@54b095d)
  [nodejs#235](npm/cli#235) Add spec to dist-tag remove
  function ([@theberbie](https://github.com/theberbie))

DEPENDENCIES

* [`dc8f9e52f`](npm/cli@dc8f9e5)
  `[email protected]`: Infer the ownership of all unpacked files in
  `node_modules`, so that we never have user-owned files in root-owned
  folders, or root-owned files in user-owned folders.
  ([@isaacs](https://github.com/isaacs))
* [`bb33940c3`](npm/cli@bb33940)
  `[email protected]`:
  * [`9c93ac3`](npm/cmd-shim@9c93ac3)
    [#2](npm/cmd-shim#2)
    [npm#3380](npm/npm#3380) Handle environment
    variables properly ([@basbossink](https://github.com/basbossink))
  * [`2d277f8`](npm/cmd-shim@2d277f8)
    [nodejs#25](npm/cmd-shim#25)
    [nodejs#36](npm/cmd-shim#36)
    [nodejs#35](npm/cmd-shim#35) Fix 'no shebang' case by
    always providing `$basedir` in shell script
    ([@igorklopov](https://github.com/igorklopov))
  * [`adaf20b`](npm/cmd-shim@adaf20b)
    [nodejs#26](npm/cmd-shim#26) Fix `$*` causing an
    error when arguments contain parentheses
    ([@satazor](https://github.com/satazor))
  * [`49f0c13`](npm/cmd-shim@49f0c13)
    [nodejs#30](npm/cmd-shim#30) Fix paths for MSYS/MINGW
    bash ([@dscho](https://github.com/dscho))
  * [`51a8af3`](npm/cmd-shim@51a8af3)
    [nodejs#34](npm/cmd-shim#34) Add proper support for
    PowerShell ([@ExE-Boss](https://github.com/ExE-Boss))
  * [`4c37e04`](npm/cmd-shim@4c37e04)
    [#10](npm/cmd-shim#10) Work around quoted
    batch file names ([@isaacs](https://github.com/isaacs))
* [`a4e279544`](npm/cli@a4e2795)
  `[email protected]` ([@isaacs](https://github.com/isaacs)):
    * fail properly if `uid-number` raises an error
* [`7086a1809`](npm/cli@7086a18)
  `[email protected]` ([@isaacs](https://github.com/isaacs))
* [`8845141f9`](npm/cli@8845141)
  `[email protected]` ([@isaacs](https://github.com/isaacs))
* [`51c028215`](npm/cli@51c0282)
  `[email protected]` ([@isaacs](https://github.com/isaacs))
* [`534a5548c`](npm/cli@534a554)
  `[email protected]` ([@isaacs](https://github.com/isaacs))
* [`3038f2fd5`](npm/cli@3038f2f)
  `[email protected]` ([@isaacs](https://github.com/isaacs))
* [`a609a1648`](npm/cli@a609a16)
  `[email protected]` ([@isaacs](https://github.com/isaacs))
* [`f0346f754`](npm/cli@f0346f7)
  `[email protected]` ([@isaacs](https://github.com/isaacs))
* [`ca9c615c8`](npm/cli@ca9c615)
  `[email protected]` ([@isaacs](https://github.com/isaacs))
* [`b417affbf`](npm/cli@b417aff)
  `[email protected]` ([@isaacs](https://github.com/isaacs))

TESTS

* [`b6df0913c`](npm/cli@b6df091)
  [nodejs#228](npm/cli#228) Proper handing of
  /usr/bin/node lifecycle-path test
  ([@olivr70](https://github.com/olivr70))
* [`aaf98e88c`](npm/cli@aaf98e8)
  `[email protected]` ([@isaacs](https://github.com/isaacs))
@snyk-bot snyk-bot mentioned this pull request Jan 8, 2020
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 timscharfenort/node#5
Open
@snyk-bot snyk-bot mentioned this pull request Jul 5, 2020
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 sitedata/node#3
Open
@snyk-bot snyk-bot mentioned this pull request Aug 11, 2020
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 radiumrasheed/node#3
Open
@snyk-bot snyk-bot mentioned this pull request Aug 27, 2020
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 aliceUnhinged613/node#5
Open
@snyk-bot snyk-bot mentioned this pull request Jan 10, 2021
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 ryan-ally/node#9
Merged
@trongham trongham mentioned this pull request Feb 25, 2021
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 trongham/node#9
Open
@snyk-bot snyk-bot mentioned this pull request Jun 28, 2021
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 ramonbrugman/node#13
Open
@snyk-bot snyk-bot mentioned this pull request Aug 11, 2021
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 Andrea-MariaDB-2/node#9
Open
This was referenced Sep 23, 2021
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 PinkDiamond1/node#10
Open
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 yotamselementor/node#11
Open
@snyk-bot snyk-bot mentioned this pull request Oct 10, 2022
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 lokera666/node#4
Open
This was referenced Feb 14, 2023
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 Dixiejane/node#5
Open
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 SanchitMahajan236/node#8
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 15, 2023
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 davidmather/node#1
Open
@snyk-bot snyk-bot mentioned this pull request Mar 22, 2023
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 Bank4500/nodejs#5
Open
@snyk-bot snyk-bot mentioned this pull request Apr 24, 2023
[Snyk] Fix for 44 vulnerabilities aliscco/alisco-node#115
Open
@snyk-bot snyk-bot mentioned this pull request May 5, 2023
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 ashly1111111/node#14
Open
@nicholaschoi168 nicholaschoi168 mentioned this pull request May 16, 2023
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 nicholaschoi168/node#7
Open
This was referenced Jul 7, 2023
[Snyk] Fix for 21 vulnerabilities leonardoadame/node#65
Open
[Snyk] Fix for 22 vulnerabilities leonardoadame/node#75
Open
[Snyk] Fix for 22 vulnerabilities leonardoadame/node#89
Open
@pranathi-nallamilli pranathi-nallamilli mentioned this pull request Aug 5, 2023
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 pranathi-nallamilli/node#5
Open
@JCsomeShots JCsomeShots mentioned this pull request Sep 19, 2023
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 JCsomeShots/node#1
Open
@kingjay66 kingjay66 mentioned this pull request Oct 15, 2023
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 kingjay66/node#4
Open
@Jingyi090 Jingyi090 mentioned this pull request Nov 17, 2023
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 Jingyi090/node#1
Open
@nickfnblum nickfnblum mentioned this pull request Nov 21, 2023
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 nickfnblum/node#7
Open
@ashly1111111 ashly1111111 mentioned this pull request Nov 24, 2023
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 ashly1111111/node#69
Open
@aravindb26 aravindb26 mentioned this pull request Jan 4, 2024
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 aravindb26/node#1
Open
@CxsLucyfer CxsLucyfer mentioned this pull request Jan 29, 2024
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 CxsLucyfer/node#1
Open
@ahamedislam ahamedislam mentioned this pull request Feb 22, 2024
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 ahamedislam/node#1
Open
@DanyRay420 DanyRay420 mentioned this pull request Feb 24, 2024
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 DanyRay420/node#2
Open
@matrix-compute matrix-compute mentioned this pull request Mar 28, 2024
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 matrix-compute/node.js#2
Open
@ashly1111111 ashly1111111 mentioned this pull request Mar 29, 2024
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 ashly1111111/node#94
Open
@lairortega lairortega mentioned this pull request Apr 14, 2024
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 lairortega/node#1
Open
@yaseenaljamal yaseenaljamal mentioned this pull request Apr 25, 2024
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 yaseenaljamal/node#5
Open
@dannybrown13 dannybrown13 mentioned this pull request May 7, 2024
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 dannybrown13/node#93
Open
@CharliesAngel1 CharliesAngel1 mentioned this pull request May 7, 2024
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 CharliesAngel1/node#14
Open
@snyk-io snyk-io Bot mentioned this pull request May 21, 2024
[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 Hawthorne001/node2#2
Open
syg pushed a commit to syg/node that referenced this pull request May 5, 2025
@rmahdav
deps: update simdutf to v7.0.0 (nodejs#217)
1b3c1e1
bakkot pushed a commit to bakkot/node that referenced this pull request May 11, 2026
@rmahdav pthier
deps: update simdutf to v7.0.0 (nodejs#217)
e8d2eee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sam-github @bnoordhuis
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.