GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — doc: use Cookie in request.setHeader() examples by lpinca · Pull Request #23707 · nodejs/node

Conversation

lpinca commented Oct 17, 2018

Copy link

Copy Markdown

Member

Set-Cookie is a response header, replace it with Cookie.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          doc: use Cookie in request.setHeader() examples

764bfd7

`Set-Cookie` is a response header, replace it with `Cookie`.

nodejs-github-bot commented Oct 17, 2018

Copy link

Copy Markdown

Collaborator

@lpinca build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1272/pipeline

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added doc

Issues and PRs related to Node.js documentation.

http Issues and PRs related to the http subsystem. labels

Oct 17, 2018

cjihrig approved these changes

Oct 17, 2018

View reviewed changes

vsemozhetbyt approved these changes

Oct 17, 2018

View reviewed changes

jasnell approved these changes

Oct 17, 2018

View reviewed changes

addaleax commented Oct 24, 2018

Copy link

Copy Markdown

Member

Landed in 862b7a1

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

addaleax closed this

Oct 24, 2018

addaleax pushed a commit that referenced this pull request

Oct 24, 2018


          doc: use Cookie in request.setHeader() examples

862b7a1

`Set-Cookie` is a response header, replace it with `Cookie`.

PR-URL: #23707
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>

lpinca deleted the replace/set-cookie-with-cookie branch

October 24, 2018 10:45

targos pushed a commit that referenced this pull request

Oct 24, 2018


          doc: use Cookie in request.setHeader() examples

d808d27

`Set-Cookie` is a response header, replace it with `Cookie`.

PR-URL: #23707
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>

targos mentioned this pull request

Oct 27, 2018

Release proposal: v11.1.0 #23922

Merged

This was referenced Nov 2, 2018

2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#245

Closed

2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#246

Closed

2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#247

Closed

2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#248

Closed

MylesBorins added dont-land-on-v8.x labels

Nov 26, 2018

MylesBorins pushed a commit that referenced this pull request

Nov 26, 2018


          doc: use Cookie in request.setHeader() examples

8a6086c

`Set-Cookie` is a response header, replace it with `Cookie`.

PR-URL: #23707
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>

codebytere mentioned this pull request

Nov 27, 2018

v10.13.1 proposal #24675

Closed

rvagg pushed a commit that referenced this pull request

Nov 28, 2018


          doc: use Cookie in request.setHeader() examples

1589cb7

`Set-Cookie` is a response header, replace it with `Cookie`.

PR-URL: #23707
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>

MylesBorins pushed a commit that referenced this pull request

Nov 29, 2018


          doc: use Cookie in request.setHeader() examples

`Set-Cookie` is a response header, replace it with `Cookie`.

PR-URL: #23707
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>

codebytere mentioned this pull request

Nov 29, 2018

v10.14.2 proposal #24727

Merged

Reviewers

jasnell

jasnell approved these changes

cjihrig

cjihrig approved these changes

+1 more reviewer

vsemozhetbyt

vsemozhetbyt approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc

Issues and PRs related to Node.js documentation.

http

Issues and PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.