GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add note about removeListener order by jasnell · Pull Request #23762 · nodejs/node

Conversation

@jasnell

@jasnell jasnell commented Oct 19, 2018

Copy link
Copy Markdown
Member

Fixes: #21635

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jasnell jasnell added doc Issues and PRs related to Node.js documentation. events Issues and PRs related to EventEmitter and the events module. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Oct 19, 2018
@nodejs-github-bot

nodejs-github-bot commented Oct 19, 2018

Copy link
Copy Markdown
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1300/pipeline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Oct 19, 2018

Copy link
Copy Markdown
Member Author

Please 👍 to fast-track
vsemozhetbyt, trivikr, and lpinca reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vsemozhetbyt
vsemozhetbyt reviewed Oct 19, 2018
View reviewed changes
Comment thread doc/api/events.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
vsemozhetbyt
vsemozhetbyt reviewed Oct 19, 2018
View reviewed changes
Comment thread doc/api/events.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
mmarchini
mmarchini approved these changes Oct 19, 2018
View reviewed changes
vsemozhetbyt
vsemozhetbyt approved these changes Oct 19, 2018
View reviewed changes
@vsemozhetbyt vsemozhetbyt added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 19, 2018
trivikr
trivikr approved these changes Oct 20, 2018
View reviewed changes
addaleax
addaleax approved these changes Oct 20, 2018
View reviewed changes
lpinca
lpinca approved these changes Oct 21, 2018
View reviewed changes
@jasnell
doc: add note about removeListener order
2f8098d 
Fixes: nodejs#21635
@jasnell
jasnell force-pushed the events-removelistener-order branch from c9cbf95 to 2f8098d Compare October 23, 2018 20:03
@jasnell

jasnell commented Oct 23, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Landed in 2f8098d
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Oct 23, 2018
@jasnell jasnell reopened this Oct 23, 2018
@jasnell

jasnell commented Oct 23, 2018

Copy link
Copy Markdown
Member Author

Sorry... heh... mixed up the PRs lol
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell added a commit that referenced this pull request Oct 23, 2018
@jasnell
doc: add note about removeListener order
b049d55 
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@jasnell

jasnell commented Oct 23, 2018

Copy link
Copy Markdown
Member Author

Landed in b049d55
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Oct 23, 2018
targos pushed a commit that referenced this pull request Oct 24, 2018
@jasnell @targos
doc: add note about removeListener order
84fdb1c 
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Oct 27, 2018
Release proposal: v11.1.0 #23922
Merged
This was referenced Nov 2, 2018
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#245
Closed
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#246
Closed
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#247
Closed
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#248
Closed
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@jasnell @MylesBorins
doc: add note about removeListener order
c251d40 
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@jasnell @MylesBorins
doc: add note about removeListener order
9982c09 
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins added land-on-v8.x labels Nov 26, 2018
@codebytere codebytere mentioned this pull request Nov 27, 2018
v10.13.1 proposal #24675
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@jasnell @rvagg
doc: add note about removeListener order
e5f75cf 
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@jasnell @rvagg
doc: add note about removeListener order
8990e32 
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@jasnell @MylesBorins
doc: add note about removeListener order
98fc848 
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
v10.14.2 proposal #24727
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
v8.14.1 proposal #24832
Merged
This was referenced Dec 18, 2018
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#267
Closed
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#268
Closed
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#269
Closed
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#270
Closed
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#271
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@lpinca lpinca lpinca approved these changes
@trivikr trivikr trivikr approved these changes
+2 more reviewers
@mmarchini mmarchini mmarchini approved these changes
@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. events Issues and PRs related to EventEmitter and the events module. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@jasnell @nodejs-github-bot @addaleax @lpinca @mmarchini @vsemozhetbyt @trivikr @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.