GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: icu: apply workaround patch to 62.1 for significant digits by srl295 · Pull Request #23764 · nodejs/node

Conversation

@srl295

@srl295 srl295 commented Oct 19, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

patch from https://chromium.googlesource.com/chromium/deps/icu/+/master/patches/nf_maxsig.patch

from https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503

ICU bug: https://unicode-org.atlassian.net/browse/ICU-20063

Fixes: #22156

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jskeate reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Oct 19, 2018

Copy link
Copy Markdown
Collaborator

@srl295 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1302/pipeline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srl295 srl295 self-assigned this Oct 19, 2018
@nodejs-github-bot nodejs-github-bot added i18n-api Issues and PRs related to Node.js internationalization support. tools Issues and PRs related to the tools directory. labels Oct 19, 2018
@srl295 srl295 changed the title deps: icu: apply workaround patch deps: icu: apply workaround patch to 62.1 for significant digits Oct 19, 2018
@srl295

srl295 commented Oct 19, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

for ICU 62 this warning will appear:

WARNING: Using floating patch "tools/icu/patches/62/source/i18n/decimfmt.cpp" from "tools/icu"
WARNING: warnings were emitted in the configure phase

This will go away with ICU 63, #23715 because ICU 63 has fixed this issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srl295
srl295 requested a review from devsnek October 19, 2018 20:57
@srl295 srl295 mentioned this pull request Oct 19, 2018
Elm 0.18 compatibility vanwagonet/elm-intl#4
Merged
@srl295
srl295 requested a review from TimothyGu October 19, 2018 20:59
jasnell
jasnell approved these changes Oct 19, 2018
View reviewed changes
@srl295
srl295 force-pushed the patch-icu-62-sigdig branch from 4b61932 to 6576f41 Compare October 19, 2018 22:58
@srl295

srl295 commented Oct 19, 2018

Copy link
Copy Markdown
Member Author

@jasnell thanks. Rebased and fixed a linter problem (long line)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srl295
srl295 force-pushed the patch-icu-62-sigdig branch from 6576f41 to 4a21d69 Compare October 22, 2018 22:19
@srl295
srl295 requested a review from refack October 23, 2018 01:27
refack
refack approved these changes Oct 23, 2018
View reviewed changes
@srl295

srl295 commented Oct 23, 2018

Copy link
Copy Markdown
Member Author

CI : https://ci.nodejs.org/job/node-test-pull-request/18059/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srl295 srl295 closed this Oct 23, 2018
@srl295
srl295 force-pushed the patch-icu-62-sigdig branch from 4a21d69 to 4194b05 Compare October 23, 2018 20:33
@srl295
srl295 merged commit 4194b05 into nodejs:master Oct 23, 2018
@srl295
srl295 deleted the patch-icu-62-sigdig branch October 23, 2018 20:33
targos pushed a commit that referenced this pull request Oct 24, 2018
@srl295 @targos
deps: icu: apply workaround patch
ab58439 
ICU 62.1 had a bug where certain orders of operations would not
work with the minimum significant digit setting. Fixed in
ICU 63.1. Applied the following patch from v8.

https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503

ICU Bug:
https://unicode-org.atlassian.net/browse/ICU-20063

Fixes: #22156

PR-URL: #23764
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@srl295 srl295 mentioned this pull request Oct 24, 2018
2018-10-30 Version 10.13.0 'Dubnium' (LTS) #23831
Merged
@targos targos mentioned this pull request Oct 27, 2018
Release proposal: v11.1.0 #23922
Merged
This was referenced Nov 2, 2018
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#245
Closed
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#246
Closed
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#247
Closed
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#248
Closed
@MylesBorins MylesBorins added land-on-v8.x labels Nov 26, 2018
@MylesBorins

MylesBorins commented Nov 26, 2018

Copy link
Copy Markdown
Contributor

@srl295 I've landed this on 8.x and 10.x staging. Please lmk if it shouldn't have landed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@srl295 @MylesBorins
deps: icu: apply workaround patch
b988792 
ICU 62.1 had a bug where certain orders of operations would not
work with the minimum significant digit setting. Fixed in
ICU 63.1. Applied the following patch from v8.

https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503

ICU Bug:
https://unicode-org.atlassian.net/browse/ICU-20063

Fixes: #22156

PR-URL: #23764
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@srl295 @MylesBorins
deps: icu: apply workaround patch
b2fbefb 
ICU 62.1 had a bug where certain orders of operations would not
work with the minimum significant digit setting. Fixed in
ICU 63.1. Applied the following patch from v8.

https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503

ICU Bug:
https://unicode-org.atlassian.net/browse/ICU-20063

Fixes: #22156

PR-URL: #23764
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
v10.13.1 proposal #24675
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@srl295 @rvagg
deps: icu: apply workaround patch
34d9129 
ICU 62.1 had a bug where certain orders of operations would not
work with the minimum significant digit setting. Fixed in
ICU 63.1. Applied the following patch from v8.

https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503

ICU Bug:
https://unicode-org.atlassian.net/browse/ICU-20063

Fixes: #22156

PR-URL: #23764
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@srl295 @rvagg
deps: icu: apply workaround patch
2a10f59 
ICU 62.1 had a bug where certain orders of operations would not
work with the minimum significant digit setting. Fixed in
ICU 63.1. Applied the following patch from v8.

https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503

ICU Bug:
https://unicode-org.atlassian.net/browse/ICU-20063

Fixes: #22156

PR-URL: #23764
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@srl295 @MylesBorins
deps: icu: apply workaround patch
1bed110 
ICU 62.1 had a bug where certain orders of operations would not
work with the minimum significant digit setting. Fixed in
ICU 63.1. Applied the following patch from v8.

https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503

ICU Bug:
https://unicode-org.atlassian.net/browse/ICU-20063

Fixes: #22156

PR-URL: #23764
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
v10.14.2 proposal #24727
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
v8.14.1 proposal #24832
Merged
This was referenced Dec 18, 2018
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#267
Closed
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#268
Closed
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#269
Closed
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#270
Closed
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#271
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@devsnek devsnek Awaiting requested review from devsnek
@TimothyGu TimothyGu Awaiting requested review from TimothyGu
+1 more reviewer
@refack refack refack approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@srl295 srl295

Labels

i18n-api Issues and PRs related to Node.js internationalization support. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@srl295 @nodejs-github-bot @MylesBorins @refack @jasnell
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.