GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: document and warn if the ICU version is too old by srl295 · Pull Request #23766 · nodejs/node

Conversation

@srl295

@srl295 srl295 commented Oct 19, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes: #19657

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Example:

$ ./configure --with-intl=small-icu --with-icu-source=https://sourceforge.net/projects/icu/files/ICU4C/4.6.1/icu4c-4_6_1-src.tgz/download
Deleting old ICU source: deps/icu
 <https://sourceforge.net/projects/icu/files/ICU4C/4.6.1/icu4c-4_6_1-src.tgz/download>
 Fetch: . 15.2MB total, 15.2MB downloaded
 Extracting tarfile: deps/icu-tmp/download
WARNING: icu4c v46.x may be too old, v57.x or later is recommended.
WARNING: warnings were emitted in the configure phase

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Oct 19, 2018

Copy link
Copy Markdown
Collaborator

@srl295 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1303/pipeline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation. labels Oct 19, 2018
@srl295
srl295 requested review from devsnek, jasnell and ryzokuken October 19, 2018 21:06
@srl295 srl295 added the i18n-api Issues and PRs related to Node.js internationalization support. label Oct 19, 2018
@srl295 srl295 self-assigned this Oct 19, 2018
richardlau
richardlau approved these changes Oct 19, 2018
View reviewed changes
jasnell
jasnell approved these changes Oct 19, 2018
View reviewed changes
addaleax
addaleax approved these changes Oct 20, 2018
View reviewed changes
@addaleax

addaleax commented Oct 20, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/17999/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 20, 2018
refack
refack reviewed Oct 20, 2018
View reviewed changes
Comment thread configure.py Outdated

@refack refack Oct 20, 2018

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may? what can happen if it is? why not go all out and error?
(escape hatch is to manually edit config.gypi)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@srl295 srl295 Oct 21, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably a compile error. which they will see soon enough… ±0 on making it an error, either way.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@refack refack Oct 23, 2018

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
refack
refack suggested changes Oct 20, 2018
View reviewed changes

@refack refack left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good concept. Left two comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread configure.py Outdated

@refack refack Oct 20, 2018

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you read this with:
https://github.com/nodejs/node/blob/bce91be01e333aa67874c89eeea419eb68dcc33a/configure.py#L1266-L1267

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
srl295 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@srl295 srl295 Oct 22, 2018

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@refack hm. Doesn't make sense with the format of current_ver.dep … the minimum ICU is global, doesn't need to be repeated multiple times.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@srl295 srl295 Oct 22, 2018

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@refack I split the minimum version to a separate file.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@refack refack Oct 23, 2018

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could change the format of tools/icu/current_ver.dep to be:

{
  "current_minimum": 57,
  "packages": [ ... current content ... ]
}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
refack
refack approved these changes Oct 23, 2018
View reviewed changes
@refack

refack commented Oct 23, 2018

Copy link
Copy Markdown
Contributor

CI (just in case you don't wanna patch this any more): https://ci.nodejs.org/job/node-test-pull-request/18060/
srl295 reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@refack refack removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 23, 2018
@srl295

srl295 commented Oct 23, 2018

Copy link
Copy Markdown
Member Author

@refack how about moving the contents to the new .json file in a future PR once these land? (this and the 2 other PRs)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ryzokuken
ryzokuken approved these changes Oct 23, 2018
View reviewed changes
@srl295 srl295 closed this Oct 23, 2018
@srl295
srl295 force-pushed the min-icu branch from 21762a0 to d8b6a1d Compare October 23, 2018 20:38
@srl295
srl295 merged commit d8b6a1d into nodejs:master Oct 23, 2018
targos pushed a commit that referenced this pull request Oct 24, 2018
@srl295 @targos
doc: document and warn if the ICU version is too old
db113a2 
Fixes: #19657

PR-URL: #23766
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
@srl295 srl295 mentioned this pull request Oct 24, 2018
2018-10-30 Version 10.13.0 'Dubnium' (LTS) #23831
Merged
@targos targos mentioned this pull request Oct 27, 2018
Release proposal: v11.1.0 #23922
Merged
This was referenced Nov 2, 2018
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#245
Closed
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#246
Closed
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#247
Closed
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#248
Closed
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@srl295 @MylesBorins
doc: document and warn if the ICU version is too old
f1c2fb3 
Fixes: #19657

PR-URL: #23766
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
@MylesBorins MylesBorins added land-on-v10.x labels Nov 26, 2018
@MylesBorins

MylesBorins commented Nov 26, 2018

Copy link
Copy Markdown
Contributor

This lands cleanly on 10.x, should we backport to 8.x?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codebytere codebytere mentioned this pull request Nov 27, 2018
v10.13.1 proposal #24675
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@srl295 @rvagg
doc: document and warn if the ICU version is too old
feacd47 
Fixes: #19657

PR-URL: #23766
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@srl295 @MylesBorins
doc: document and warn if the ICU version is too old
e87e9f2 
Fixes: #19657

PR-URL: #23766
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
v10.14.2 proposal #24727
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@richardlau richardlau richardlau approved these changes
@devsnek devsnek Awaiting requested review from devsnek
+2 more reviewers
@refack refack refack approved these changes
@ryzokuken ryzokuken ryzokuken approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@srl295 srl295

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation. i18n-api Issues and PRs related to Node.js internationalization support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@srl295 @nodejs-github-bot @addaleax @refack @MylesBorins @jasnell @richardlau @ryzokuken
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.