GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build,meta: bump gcc on travis by refack · Pull Request #23778 · nodejs/node

Conversation

@refack

@refack refack commented Oct 20, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The version of clang provided in the Travis linux image uses
libstdc++4.8 whice is below our minimal supported version.

Switching to make test -j1 is to avoid races during the test cycle
causes by the main target being "unstable", that is it always builds
some files, and relinks the binary, which is used by the test procedure.

Details 
../src/node_crypto.cc:3641:29: error: no matching function for call to 'get'
    return sign->CheckThrow(std::get<Error>(ret));
                            ^~~~~~~~~~~~~~~
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/utility:142:5: note: candidate template ignored: invalid explicitly-specified argument for template parameter '_Int'
    get(std::pair<_Tp1, _Tp2>& __in) noexcept
    ^
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/utility:147:5: note: candidate template ignored: invalid explicitly-specified argument for template parameter '_Int'
    get(std::pair<_Tp1, _Tp2>&& __in) noexcept
    ^
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/utility:152:5: note: candidate template ignored: invalid explicitly-specified argument for template parameter '_Int'
    get(const std::pair<_Tp1, _Tp2>& __in) noexcept
    ^
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/array:268:5: note: candidate template ignored: invalid explicitly-specified argument for template parameter '_Int'
    get(array<_Tp, _Nm>& __arr) noexcept
    ^
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/array:277:5: note: candidate template ignored: invalid explicitly-specified argument for template parameter '_Int'
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@refack refack added build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. regression Issues related to regressions. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Oct 20, 2018
@nodejs-github-bot

nodejs-github-bot commented Oct 20, 2018

Copy link
Copy Markdown
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1309/pipeline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@refack refack mentioned this pull request Oct 20, 2018
crypto: simplify internal state handling #23648
Closed
2 tasks done
@refack
refack requested review from addaleax and lpinca October 20, 2018 02:34
@refack

refack commented Oct 20, 2018

Copy link
Copy Markdown
Contributor Author

/CC @nodejs/build-files @nodejs/testing
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
refack
refack commented Oct 20, 2018
View reviewed changes
Comment thread .travis.yml Outdated

@refack refack Oct 20, 2018

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refs: #23733

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@addaleax addaleax Oct 20, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d prefer to undo this unless it’s actually causing trouble on Travis – I don’t think we’ve seen this so far.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@refack refack Oct 20, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes the tests consistent with JEnkins, but I'll do it in another PR

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
addaleax
addaleax reviewed Oct 20, 2018
View reviewed changes
Comment thread .travis.yml Outdated

@addaleax addaleax Oct 20, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d prefer to undo this unless it’s actually causing trouble on Travis – I don’t think we’ve seen this so far.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .travis.yml Outdated

@addaleax addaleax Oct 20, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe set these using export CC='ccache gcc-4.9' && CXX='ccache g++-4.9' on the first line of install:, and then leave these lines as they are?

Also, I’d prefer to keep ./configure – firstly, the .travis.yml of a project is sometimes used by devs to figure out how to build it, because it’s usually much more to-the-point than build instructions, and secondly that way we simply test more code than without it (namely the contents of configure).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@refack refack Oct 20, 2018

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm suspicious it's not behaving as we expect (hence it's using GCC over clang), so I'd rather has it explicit (like in Jenkins).

Ack on the ./configure

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@refack refack Oct 20, 2018

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing export in install

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@addaleax

addaleax commented Oct 20, 2018

Copy link
Copy Markdown
Member

I'm suspicious it's not behaving as we expect (hence it's using GCC over clang), so I'd rather has it explicit (like in Jenkins).

From a quick google search, it seems like the error message is a clang one.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@refack

refack commented Oct 20, 2018

Copy link
Copy Markdown
Contributor Author

From a quick google search, it seems like the error message is a clang one.

So it might be just an stdlibc++ issue?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented Oct 20, 2018

Copy link
Copy Markdown
Member

@refack My guess is that it might be the gcc-provided libstdc++ 4.8 not playing along well with clang? Could be totally wrong on that one, though.

(I also don’t remember the reason for picking clang in the first place, tbh.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@refack

refack commented Oct 20, 2018

Copy link
Copy Markdown
Contributor Author

I also changed the output generator from

make -j2 V=
make -C out BUILDTYPE=Release V=
make[1]: Entering directory `/home/travis/build/nodejs/node/out'
  CXX(host) /home/travis/build/nodejs/node/out/Release/obj.host/v8_libbase/deps/v8/src/base/bits.o
  CXX(host) /home/travis/build/nodejs/node/out/Release/obj.host/v8_libbase/deps/v8/src/base/cpu.o
  CXX(host) /home/travis/build/nodejs/node/out/Release/obj.host/v8_libbase/deps/v8/src/base/debug/stack_trace.o
  CXX(host) /home/travis/build/nodejs/node/out/Release/obj.host/v8_libbase/deps/v8/src/base/division-by-constant.o
  CXX(host) /home/travis/build/nodejs/node/out/Release/obj.host/v8_libbase/deps/v8/src/base/file-utils.o

to

$ make -j2 V=1 | sed -e "s/'.*\$//" -e "s|$PWD||g"
make -C out BUILDTYPE=Release V=1
make[1]: Entering directory `/out
  ccache g++-4.9 -o /out/Release/obj.host/v8_libbase/deps/v8/src/base/bits.o ../deps/v8/src/base/bits.cc 
  ccache g++-4.9 -o /out/Release/obj.host/v8_libbase/deps/v8/src/base/cpu.o ../deps/v8/src/base/cpu.cc 
  ccache g++-4.9 -o /out/Release/obj.host/v8_libbase/deps/v8/src/base/debug/stack_trace.o ../deps/v8/src/base/debug/stack_trace.cc

(this is planned to change in Jenkins as well nodejs/build#1517)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax mentioned this pull request Oct 20, 2018
src: use more explicit return type in Sign::SignFinal() #23779
Closed
2 tasks done
@addaleax

addaleax commented Oct 20, 2018

Copy link
Copy Markdown
Member

@refack One thing I’m noticing here is that the extra apt install took about a minute in https://travis-ci.com/nodejs/node/jobs/153110829 … not the end of the world, but something we might want to consider?
refack reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca reviewed Oct 20, 2018
View reviewed changes
Comment thread .travis.yml Outdated

@lpinca lpinca Oct 20, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems nodejs/build#1517 is still being discussed. I'm not a fan of this change, can we revert it?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@refack refack Oct 20, 2018

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@refack
refack force-pushed the bump-gcc-on-tavis branch from 5310a62 to aeae42a Compare October 20, 2018 13:33
lpinca
lpinca approved these changes Oct 20, 2018
View reviewed changes
@richardlau richardlau mentioned this pull request Oct 21, 2018
build: use libc++ with clang on Travis #23791
Closed
1 task done
@refack

refack commented Oct 22, 2018

Copy link
Copy Markdown
Contributor Author

One thing I’m noticing here is that the extra apt install took about a minute in travis-ci.com/nodejs/node/jobs/153110829

But for some reason total was 13m
and other job took 14m
image

While currently the jobs (using clang) take 15m+
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@refack
refack force-pushed the bump-gcc-on-tavis branch from aeae42a to 9e1081f Compare October 23, 2018 00:09
richardlau
richardlau reviewed Oct 23, 2018
View reviewed changes
Comment thread .travis.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@refack
refack force-pushed the bump-gcc-on-tavis branch from 9e1081f to 3c9fecb Compare October 23, 2018 02:44
@addaleax addaleax removed fast-track PRs proposed for a shorter-than-standard waiting period before landing. meta Issues and PRs related to the general management of the project. labels Oct 24, 2018
addaleax
addaleax reviewed Oct 24, 2018
View reviewed changes
Comment thread .travis.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@refack refack self-assigned this Oct 24, 2018
@refack

refack commented Oct 24, 2018

Copy link
Copy Markdown
Contributor Author

It's back:

In file included from ../src/bootstrapper.cc:2:
In file included from ../src/env-inl.h:27:
../src/aliased_buffer.h:27:27: error: no template named 'enable_if_t' in namespace 'std'; did you mean 'enable_if'?
          typename = std::enable_if_t<std::is_scalar<NativeT>::value>>
                     ~~~~~^~~~~~~~~~~
                          enable_if
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/type_traits:1766:12: note: 'enable_if' declared here
    struct enable_if
           ^
1 error generated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Oct 24, 2018
View reviewed changes
@refack

refack commented Oct 24, 2018

Copy link
Copy Markdown
Contributor Author

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1361/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@refack
build,meta: switch to gcc-4.9 on travis
a2328da 
The version of `clang` provided in the Travis linux image uses
libstdc++4.8 whice is below our minimal supported version.

Switching to `make test -j1` is to avoid races during the test cycle
causes by the main target being "unstable", that is it always builds
some files, and relinks the binary, which is used by the test procedure.

PR-URL: nodejs#23778
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@refack
refack force-pushed the bump-gcc-on-tavis branch from a19546f to a2328da Compare October 24, 2018 21:34
@refack
refack merged commit a2328da into nodejs:master Oct 24, 2018
@refack refack removed their assignment Oct 24, 2018
@refack
refack deleted the bump-gcc-on-tavis branch October 24, 2018 21:38
targos pushed a commit that referenced this pull request Oct 26, 2018
@refack @targos
build,meta: switch to gcc-4.9 on travis
48807f5 
The version of `clang` provided in the Travis linux image uses
libstdc++4.8 whice is below our minimal supported version.

Switching to `make test -j1` is to avoid races during the test cycle
causes by the main target being "unstable", that is it always builds
some files, and relinks the binary, which is used by the test procedure.

PR-URL: #23778
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@targos targos mentioned this pull request Oct 27, 2018
Release proposal: v11.1.0 #23922
Merged
targos pushed a commit that referenced this pull request Nov 1, 2018
@refack @targos
build,meta: switch to gcc-4.9 on travis
5c35d0d 
The version of `clang` provided in the Travis linux image uses
libstdc++4.8 whice is below our minimal supported version.

Switching to `make test -j1` is to avoid races during the test cycle
causes by the main target being "unstable", that is it always builds
some files, and relinks the binary, which is used by the test procedure.

PR-URL: #23778
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
This was referenced Nov 2, 2018
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#245
Closed
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#246
Closed
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#247
Closed
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#248
Closed
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@refack @MylesBorins
build,meta: switch to gcc-4.9 on travis
8f58eed 
The version of `clang` provided in the Travis linux image uses
libstdc++4.8 whice is below our minimal supported version.

Switching to `make test -j1` is to avoid races during the test cycle
causes by the main target being "unstable", that is it always builds
some files, and relinks the binary, which is used by the test procedure.

PR-URL: #23778
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@refack @MylesBorins
build,meta: switch to gcc-4.9 on travis
6386d3d 
The version of `clang` provided in the Travis linux image uses
libstdc++4.8 whice is below our minimal supported version.

Switching to `make test -j1` is to avoid races during the test cycle
causes by the main target being "unstable", that is it always builds
some files, and relinks the binary, which is used by the test procedure.

PR-URL: #23778
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@MylesBorins MylesBorins added land-on-v8.x labels Nov 26, 2018
@codebytere codebytere mentioned this pull request Nov 27, 2018
v10.13.1 proposal #24675
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@refack @rvagg
build,meta: switch to gcc-4.9 on travis
85a6dae 
The version of `clang` provided in the Travis linux image uses
libstdc++4.8 whice is below our minimal supported version.

Switching to `make test -j1` is to avoid races during the test cycle
causes by the main target being "unstable", that is it always builds
some files, and relinks the binary, which is used by the test procedure.

PR-URL: #23778
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@refack @rvagg
build,meta: switch to gcc-4.9 on travis
ea5674b 
The version of `clang` provided in the Travis linux image uses
libstdc++4.8 whice is below our minimal supported version.

Switching to `make test -j1` is to avoid races during the test cycle
causes by the main target being "unstable", that is it always builds
some files, and relinks the binary, which is used by the test procedure.

PR-URL: #23778
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@refack @MylesBorins
build,meta: switch to gcc-4.9 on travis
156fa12 
The version of `clang` provided in the Travis linux image uses
libstdc++4.8 whice is below our minimal supported version.

Switching to `make test -j1` is to avoid races during the test cycle
causes by the main target being "unstable", that is it always builds
some files, and relinks the binary, which is used by the test procedure.

PR-URL: #23778
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
v10.14.2 proposal #24727
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
v8.14.1 proposal #24832
Merged
This was referenced Dec 18, 2018
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#267
Closed
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#268
Closed
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#269
Closed
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#270
Closed
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#271
Closed
@richardlau richardlau mentioned this pull request Mar 30, 2019
Fix Travis builds #27002
Closed
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax left review comments
@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes
+1 more reviewer
@targos targos targos left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. regression Issues related to regressions.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@refack @nodejs-github-bot @addaleax @lpinca @targos @richardlau @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.