GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: add test-benchmark-http2 by Trott · Pull Request #23863 · nodejs/node

Conversation

@Trott

@Trott Trott commented Oct 25, 2018

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Oct 25, 2018

Copy link
Copy Markdown
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1362/pipeline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. http Issues and PRs related to the http subsystem. http2 Issues and PRs related to the http2 subsystem. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 25, 2018
@Trott

Trott commented Oct 25, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/18132/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Oct 25, 2018

Copy link
Copy Markdown
Member

Has h2load been installed on all of the CI machines?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Oct 25, 2018

Copy link
Copy Markdown
Member Author

Has h2load been installed on all of the CI machines?

I doubt it. This PR uses a test double instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Oct 25, 2018

Copy link
Copy Markdown
Member Author

@nodejs/testing
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell reviewed Oct 25, 2018
View reviewed changes
Comment thread benchmark/_test-double-benchmarker.js Outdated

@jasnell jasnell Oct 25, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ':path' defaults to '/' and, when using a GET request, the req.end() is unnecessary because http2 will automatically end()... so this can be simplified to:

request(client.request(), client);

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Trott Trott Oct 25, 2018

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks, will change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jasnell
jasnell reviewed Oct 25, 2018
View reviewed changes
Comment thread benchmark/_test-double-benchmarker.js Outdated

@jasnell jasnell Oct 25, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
res.on('data', () => {});
res.resume();

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Trott Trott Oct 25, 2018

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, why not? Done.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott
Trott force-pushed the test-benchmark-http2 branch from 5a73395 to fdc18b3 Compare October 25, 2018 21:36
@Trott

Trott commented Oct 25, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/18162/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
apapirovski
apapirovski reviewed Oct 26, 2018
View reviewed changes
Comment thread test/sequential/test-benchmark-http2.js Outdated

@apapirovski apapirovski Oct 26, 2018

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTTP2?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Trott Trott Oct 26, 2018

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to HTTP/2. Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
apapirovski
apapirovski approved these changes Oct 26, 2018
View reviewed changes
@Trott

Trott commented Oct 26, 2018

Copy link
Copy Markdown
Member Author

Pushed a new commit, so... CI: https://ci.nodejs.org/job/node-test-pull-request/18164/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Oct 27, 2018

Copy link
Copy Markdown
Member Author

Needs another review... /cc @joyeecheung (primary author of the existing HTTP benchmark test double)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
refack
refack reviewed Oct 27, 2018
View reviewed changes

@refack refack left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but left some nits

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread benchmark/_http-benchmarkers.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread benchmark/_test-double-benchmarker.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread benchmark/_test-double-benchmarker.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
refack
refack reviewed Oct 27, 2018
View reviewed changes
Comment thread benchmark/_test-double-benchmarker.js Outdated

@refack refack Oct 27, 2018

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
if (http.get) {
if (myModule === 'http') {

makes is clear what we're benching

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Trott Trott Oct 28, 2018

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment indicating it's 'HTTP' for now. Hope that's sufficient. (If we ever need a test double for https, only the comment will need updating and not the code.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott
test: add test-benchmark-http2
61c98d6
@Trott
Trott force-pushed the test-benchmark-http2 branch from ab76e5e to 61c98d6 Compare October 28, 2018 01:21
@Trott

Trott commented Oct 28, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/18185/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Oct 29, 2018
View reviewed changes
@Trott

Trott commented Oct 29, 2018

Copy link
Copy Markdown
Member Author

Landed in 2812759
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Oct 29, 2018
Trott added a commit to Trott/io.js that referenced this pull request Oct 29, 2018
@Trott
test: add test-benchmark-http2
2812759 
PR-URL: nodejs#23863
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Nov 1, 2018
@Trott @targos
test: add test-benchmark-http2
ed10a91 
PR-URL: #23863
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Nov 1, 2018
Release proposal: v11.1.0 #23922
Merged
This was referenced Nov 2, 2018
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#245
Closed
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#246
Closed
This was referenced Nov 2, 2018
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#247
Closed
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#248
Closed
@MylesBorins MylesBorins added backport-requested-v8.x labels Nov 26, 2018
@MylesBorins

MylesBorins commented Nov 26, 2018

Copy link
Copy Markdown
Contributor

this requires a manual backport to 8.x and 10.x

should it be backported?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Nov 27, 2018

Copy link
Copy Markdown
Member Author

should it be backported?

Low value. I'd say no.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added dont-land-on-v8.x and removed backport-requested-v10.x labels Nov 27, 2018
@Trott
Trott deleted the test-benchmark-http2 branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau left review comments
@jasnell jasnell jasnell approved these changes
+2 more reviewers
@refack refack refack left review comments
@apapirovski apapirovski apapirovski approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. http Issues and PRs related to the http subsystem. http2 Issues and PRs related to the http2 subsystem. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@Trott @nodejs-github-bot @jasnell @MylesBorins @apapirovski @refack @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.