GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: fix compiler warnings by addaleax · Pull Request #23880 · nodejs/node

Conversation

@addaleax

@addaleax addaleax commented Oct 25, 2018

Copy link
Copy Markdown
Member

Address a number of compiler warnings I am currently seeing on master.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
danbev and bricss reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
addaleax added 3 commits October 25, 2018 20:22
@addaleax
src: include util-inl.h in worker_agent.cc
211e40e 
Otherwise, the compiler complains about a missing definition
for the (inline) `Calloc` function.
@addaleax
src: make model counter in GetCPUInfo() unsigned
107ca53 
This fixes a compiler warning about comparing against
the (unsigned) `NODE_PUSH_VAL_TO_ARRAY_MAX` constant.
@addaleax
src: remove unused variables
7b0396c 
These have been overlooked in 036fbdb.
@nodejs-github-bot

nodejs-github-bot commented Oct 25, 2018

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1370/pipeline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. os Issues and PRs related to the os subsystem. labels Oct 25, 2018
richardlau
richardlau approved these changes Oct 25, 2018
View reviewed changes
cjihrig
cjihrig approved these changes Oct 25, 2018
View reviewed changes
sam-github
sam-github approved these changes Oct 25, 2018
View reviewed changes
lpinca
lpinca approved these changes Oct 25, 2018
View reviewed changes
eugeneo
eugeneo approved these changes Oct 25, 2018
View reviewed changes
jasnell
jasnell approved these changes Oct 25, 2018
View reviewed changes
targos
targos approved these changes Oct 26, 2018
View reviewed changes
@mmarchini

mmarchini commented Oct 26, 2018

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/18171/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mmarchini mmarchini added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 26, 2018
mmarchini
mmarchini approved these changes Oct 26, 2018
View reviewed changes
@cjihrig cjihrig mentioned this pull request Oct 26, 2018
Fix some compiler warnings #23910
Closed
@addaleax

addaleax commented Oct 28, 2018

Copy link
Copy Markdown
Member Author

Landed in 336651b...1b47354
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Oct 28, 2018
@addaleax
addaleax deleted the fix-warnings branch October 28, 2018 08:55
pull Bot pushed a commit to shakir-abdo/node that referenced this pull request Oct 28, 2018
@addaleax
src: include util-inl.h in worker_agent.cc
1ba10db 
Otherwise, the compiler complains about a missing definition
for the (inline) `Calloc` function.

PR-URL: nodejs#23880
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
pull Bot pushed a commit to shakir-abdo/node that referenced this pull request Oct 28, 2018
@addaleax
src: make model counter in GetCPUInfo() unsigned
b0089a5 
This fixes a compiler warning about comparing against
the (unsigned) `NODE_PUSH_VAL_TO_ARRAY_MAX` constant.

PR-URL: nodejs#23880
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
pull Bot pushed a commit to shakir-abdo/node that referenced this pull request Oct 28, 2018
@addaleax
src: remove unused variables
1b47354 
These have been overlooked in 036fbdb.

PR-URL: nodejs#23880
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
targos pushed a commit that referenced this pull request Oct 28, 2018
@addaleax @targos
src: include util-inl.h in worker_agent.cc
11e9425 
Otherwise, the compiler complains about a missing definition
for the (inline) `Calloc` function.

PR-URL: #23880
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
targos pushed a commit that referenced this pull request Oct 28, 2018
@addaleax @targos
src: make model counter in GetCPUInfo() unsigned
682e06e 
This fixes a compiler warning about comparing against
the (unsigned) `NODE_PUSH_VAL_TO_ARRAY_MAX` constant.

PR-URL: #23880
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
targos pushed a commit that referenced this pull request Oct 28, 2018
@addaleax @targos
src: remove unused variables
f5cb83f 
These have been overlooked in 036fbdb.

PR-URL: #23880
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
@targos targos mentioned this pull request Oct 28, 2018
Release proposal: v11.1.0 #23922
Merged
@refack refack mentioned this pull request Oct 29, 2018
build: add -Werror=undefined-inline to clang builds #23961
Merged
3 tasks done
refack added a commit to refack/node that referenced this pull request Oct 31, 2018
@refack
build: add -Werror=undefined-inline to clang builds
c515e5c 
PR-URL: nodejs#23961
Refs: nodejs#23954
Refs: nodejs#23910
Refs: nodejs#23880
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@targos targos added the dont-land-on-v11.x label Nov 1, 2018
@MylesBorins

MylesBorins commented Nov 27, 2018

Copy link
Copy Markdown
Contributor

@targos it looks like you meant to remove the dont-land-label. LMK if this was a mistake
targos reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
@refack @MylesBorins
build: add -Werror=undefined-inline to clang builds
bd73da0 
PR-URL: #23961
Refs: #23954
Refs: #23910
Refs: #23880
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@refack @rvagg
build: add -Werror=undefined-inline to clang builds
cb44bd0 
PR-URL: #23961
Refs: #23954
Refs: #23910
Refs: #23880
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@addaleax @rvagg
src: include util-inl.h in worker_agent.cc
dba003c 
Otherwise, the compiler complains about a missing definition
for the (inline) `Calloc` function.

PR-URL: #23880
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@addaleax @rvagg
src: remove unused variables
c2fde21 
These have been overlooked in 036fbdb.

PR-URL: #23880
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
@targos targos added the dont-land-on-v11.x label Nov 28, 2018
@targos

targos commented Nov 28, 2018

Copy link
Copy Markdown
Member

Oh, I forgot to post a message. I could only cherry-pick two commits from the PR. The third (107ca53) doesn't apply anymore because #24264 is already on v11.x and removes the changed line.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins

MylesBorins commented Nov 28, 2018

Copy link
Copy Markdown
Contributor

@targos in that case would it be better to add the backported-to label instead, since some of the commits landed?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added backported-to-v11.x and removed dont-land-on-v11.x labels Nov 28, 2018
@targos

targos commented Nov 28, 2018

Copy link
Copy Markdown
Member

SGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@refack @MylesBorins
build: add -Werror=undefined-inline to clang builds
a1b5643 
PR-URL: #23961
Refs: #23954
Refs: #23910
Refs: #23880
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
@refack @MylesBorins
build: add -Werror=undefined-inline to clang builds
2e83f1e 
PR-URL: #23961
Refs: #23954
Refs: #23910
Refs: #23880
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
@codebytere codebytere added the dont-land-on-v10.x label Jan 13, 2019
This was referenced Apr 23, 2019
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#302
Closed
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#275
Closed
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#276
Closed
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#303
Closed
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#277
Closed
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#304
Closed
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#278
Closed
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#305
Closed
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-nodejs#279
Closed
2019-04-23 Version 12.0.0 (Current) @BethGriggs beevelop/docker-android-nodejs#306
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes
+4 more reviewers
@sam-github sam-github sam-github approved these changes
@eugeneo eugeneo eugeneo approved these changes
@targos targos targos approved these changes
@mmarchini mmarchini mmarchini approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. os Issues and PRs related to the os subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

12 participants

@addaleax @nodejs-github-bot @mmarchini @targos @MylesBorins @sam-github @eugeneo @jasnell @lpinca @cjihrig @richardlau @codebytere
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.