GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add optional callback to socket.end by Ajido · Pull Request #23937 · nodejs/node

Conversation

@Ajido

@Ajido Ajido commented Oct 28, 2018

Copy link
Copy Markdown
Contributor

Since the optional callback was missing in the socket.end, I added it.

Refs: #18708

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Ajido
doc: add optional callback to socket.end
897bd02
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. net Issues and PRs related to the net subsystem. labels Oct 28, 2018
@vsemozhetbyt

vsemozhetbyt commented Oct 28, 2018

Copy link
Copy Markdown
Contributor

CI fails as this ref needs to be updated now. It should be:

[`socket.end()`]: #net_socket_end_data_encoding_callback
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Ajido
fix a link
a270357
@vsemozhetbyt

vsemozhetbyt commented Oct 28, 2018

Copy link
Copy Markdown
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1401/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Ajido

Ajido commented Oct 28, 2018

Copy link
Copy Markdown
Contributor Author

@vsemozhetbyt thank you for your review comments.
vsemozhetbyt reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Oct 28, 2018
View reviewed changes
vsemozhetbyt
vsemozhetbyt approved these changes Oct 28, 2018
View reviewed changes
@vsemozhetbyt vsemozhetbyt added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 28, 2018
@vsemozhetbyt

vsemozhetbyt commented Oct 28, 2018

Copy link
Copy Markdown
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.
vsemozhetbyt, lpinca, and trivikr reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
trivikr
trivikr approved these changes Oct 29, 2018
View reviewed changes
@vsemozhetbyt vsemozhetbyt added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 29, 2018
@vsemozhetbyt

vsemozhetbyt commented Oct 29, 2018

Copy link
Copy Markdown
Contributor

Landed in 9697c08
Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vsemozhetbyt vsemozhetbyt closed this Oct 29, 2018
vsemozhetbyt pushed a commit that referenced this pull request Oct 29, 2018
@Ajido @vsemozhetbyt
doc: add optional callback to socket.end()
9697c08 
PR-URL: #23937
Refs: #18708
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Nov 1, 2018
@Ajido @targos
doc: add optional callback to socket.end()
f01a806 
PR-URL: #23937
Refs: #18708
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Nov 1, 2018
Release proposal: v11.1.0 #23922
Merged
This was referenced Nov 2, 2018
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#245
Closed
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#246
Closed
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#247
Closed
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#248
Closed
@Ajido Ajido mentioned this pull request Nov 4, 2018
test: add test for socket.end callback #24087
Closed
3 tasks done
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@Ajido @MylesBorins
doc: add optional callback to socket.end()
64c683b 
PR-URL: #23937
Refs: #18708
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@MylesBorins MylesBorins added land-on-v8.x and removed land-on-v8.x labels Nov 26, 2018
@codebytere codebytere mentioned this pull request Nov 27, 2018
v10.13.1 proposal #24675
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@Ajido @rvagg
doc: add optional callback to socket.end()
e14226c 
PR-URL: #23937
Refs: #18708
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 28, 2018
@Ajido @Trott
test: add test for socket.end callback
628f955 
PR-URL: nodejs#24087
Refs: nodejs#23937
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Nov 28, 2018
@Ajido @targos
test: add test for socket.end callback
d6fff0e 
PR-URL: #24087
Refs: #23937
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@Ajido @MylesBorins
doc: add optional callback to socket.end()
cc22a2a 
PR-URL: #23937
Refs: #18708
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
v10.14.2 proposal #24727
Merged
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Ajido @refack
test: add test for socket.end callback
f4bd08e 
PR-URL: nodejs#24087
Refs: nodejs#23937
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@Ajido @BethGriggs
test: add test for socket.end callback
4093572 
PR-URL: #24087
Refs: #23937
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@Ajido @rvagg
test: add test for socket.end callback
6799d3b 
PR-URL: #24087
Refs: #23937
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@trivikr trivikr trivikr approved these changes
+1 more reviewer
@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. net Issues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Ajido @vsemozhetbyt @lpinca @trivikr @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.