GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: use 'Node.js' instead of 'Node' per Foundation branding guidelines by Trott · Pull Request #23967 · nodejs/node

Conversation

@Trott

@Trott Trott commented Oct 30, 2018

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot

nodejs-github-bot commented Oct 30, 2018

Copy link
Copy Markdown
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1415/pipeline

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation. labels Oct 30, 2018
@Trott
Trott force-pushed the node-js branch from 68f0811 to 22950b7 Compare October 30, 2018 05:40
richardlau
richardlau approved these changes Oct 30, 2018
View reviewed changes

@richardlau richardlau left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we lint for this? (I thought we already did like we do for "V8" but clearly we don't otherwise the linter would be failing.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@richardlau

richardlau commented Oct 30, 2018

Copy link
Copy Markdown
Member

Can we lint for this? (I thought we already did like we do for "V8" but clearly we don't otherwise the linter would be failing.)

Ah we only lint for "Node.JS":

node/tools/lint-md.js

Line 33286 in b255cd4

{ no: 'Node.JS', yes: 'Node.js' },

(from https://github.com/watilde/remark-preset-lint-node/blob/f9ad8005a90e5056028df96d2cb24de8bdf1c649/index.js#L47)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott

Trott commented Oct 30, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Can we lint for this? (I thought we already did like we do for "V8" but clearly we don't otherwise the linter would be failing.)

@richardlau Yes, but there are problems, such as an unclear error message because of the way the lint plugin handles regexp-y things. Fortunately, I'm the maintainer of the lint plugin, and I have it on my to-do list to fix this so that we can enable it eventually. (Or if some eager contributor wants to beat me to it, go for it. It's Trott/remark-lint-prohibited-strings#2.)

We do currently lint for NodeJS and recommend Node.js instead, but that's it. We don't lint for other variants like Node.

richardlau reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

trivikr
trivikr approved these changes Oct 30, 2018
View reviewed changes
@fhinkel

fhinkel commented Oct 30, 2018

Copy link
Copy Markdown
Contributor

When did the guidelines change? Last time I looked them up it said Node.js for headlines, and Node in text. Could you link to the guidelines please?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mmarchini
mmarchini approved these changes Oct 30, 2018
View reviewed changes
cjihrig
cjihrig approved these changes Oct 30, 2018
View reviewed changes
jasnell
jasnell approved these changes Oct 30, 2018
View reviewed changes
@Trott

Trott commented Oct 30, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

When did the guidelines change? Last time I looked them up it said Node.js for headlines, and Node in text. Could you link to the guidelines please?

@fhinkel AFAIK, it didn't change. I've always understood it to be "Node.js, never Node, but node is OK if referring to the executable".

It's possible I've misunderstood but it does appear that the Foundation website homepage uses Node.js everywhere--headlines, text, etc.--with the sole exception of Node+JS Interactive.

Maybe someone (Zibby?) from Foundation marketing can chime in. /ping @nodejs/foundation

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ZibbyKeaton

ZibbyKeaton commented Oct 30, 2018

Copy link
Copy Markdown

Happy to chime in. The guidelines that we started at least when the Foundation was formed was to use Node.js consistently and everywhere (headlines, text, etc.).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@fhinkel

fhinkel commented Oct 30, 2018

Copy link
Copy Markdown
Contributor

@Trott and @ZibbyKeaton thanks for following up. LGTM

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fhinkel
fhinkel approved these changes Oct 30, 2018
View reviewed changes
devsnek
devsnek reviewed Oct 30, 2018
View reviewed changes
Comment thread doc/node.1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

vsemozhetbyt
vsemozhetbyt reviewed Oct 30, 2018
View reviewed changes
Comment thread doc/guides/node-postmortem-support.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

vsemozhetbyt
vsemozhetbyt approved these changes Oct 30, 2018
View reviewed changes
@richardlau

richardlau commented Oct 30, 2018

Copy link
Copy Markdown
Member

When did the guidelines change? Last time I looked them up it said Node.js for headlines, and Node in text. Could you link to the guidelines please?

@fhinkel AFAIK, it didn't change. I've always understood it to be "Node.js, never Node, but node is OK if referring to the executable".

It's possible I've misunderstood but it does appear that the Foundation website homepage uses Node.js everywhere--headlines, text, etc.--with the sole exception of Node+JS Interactive.

Maybe someone (Zibby?) from Foundation marketing can chime in. /ping @nodejs/foundation

I think what @fhinkel might be remembering is the old (pre-Foundation) wiki FAQ: https://github.com/nodejs/wiki-archive/blob/master/node-v0.x-archive/FAQ.md#what-is-the-official-spellingcapitalizationpronunciation:

What is the "official" spelling/capitalization/pronunciation?

  • When referring to the software or the project in general, it's Node.js or simply Node. It is a proper noun, so capitalize it. The .js appears with the first use, to disambiguate from other things called "Node", and Node (without the .js) afterwards. One way to think of this is that Node.js is the full name, and Node is the more familiar first name.
  • When referring specifically to the binary executable, it's always node, lower-case to match the binary's name itself.
  • When referring to the libs that are included with the binary, as opposed to the libs published by Node users in The npm Registry, it's node-core or node core. (See [[node core vs userland]].)
  • "npm" is always lowercase, even when it appears at the start of a sentence, unless used in a context where all-caps are used (such as the title of a man page.)
  • "Node.js" is pronounced either "node dot jay ess", or "node jay ess", or "node point javascript".
  • "npm" is pronounced "en pee em", spelled out.
Trott and fhinkel reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lpinca
lpinca approved these changes Oct 30, 2018
View reviewed changes
Trott added 3 commits October 30, 2018 19:23
@Trott
doc: use Node.js instead of Node
65ea515
Per branding guidelines from the Foundation, use Node.js and not Node.
@Trott
doc: use Node.js in BUILDING.md
73acfa0
Use Node.js instead of Node per branding guidelines.
@Trott
doc: add branding to style guide
4a28361
@Trott
Trott force-pushed the node-js branch from ef9cd30 to 4a28361 Compare October 31, 2018 02:23
@Trott

Trott commented Oct 31, 2018

Copy link
Copy Markdown
Member Author

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1432/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 31, 2018
@Trott

Trott commented Nov 1, 2018

Copy link
Copy Markdown
Member Author

Landed in 51294c8...7b09f5b

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott Trott closed this Nov 1, 2018
Trott added a commit to Trott/io.js that referenced this pull request Nov 1, 2018
@Trott
doc: use Node.js instead of Node
03f5252
Per branding guidelines from the Foundation, use Node.js and not Node.

PR-URL: nodejs#23967
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Nov 1, 2018
@Trott
doc: add branding to style guide
7b09f5b
PR-URL: nodejs#23967
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Nov 1, 2018
@Trott @targos
doc: use Node.js instead of Node
33053ec
Per branding guidelines from the Foundation, use Node.js and not Node.

PR-URL: #23967
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Nov 1, 2018
@Trott @targos
doc: add branding to style guide
26510fb
PR-URL: #23967
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 1, 2018
Release proposal: v11.1.0 #23922
Merged
This was referenced Nov 2, 2018
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#245
Closed
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#246
Closed
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#247
Closed
2018-11-02 Version 11.1.0 (Current) @targos beevelop/docker-android-nodejs#248
Closed
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
@Trott @MylesBorins
doc: use Node.js instead of Node
803070b
Per branding guidelines from the Foundation, use Node.js and not Node.

PR-URL: #23967
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
@Trott @MylesBorins
doc: add branding to style guide
4a52fc0
PR-URL: #23967
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
@Trott @MylesBorins
doc: use Node.js instead of Node
9a4646e
Per branding guidelines from the Foundation, use Node.js and not Node.

PR-URL: #23967
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
@Trott @MylesBorins
doc: add branding to style guide
c564a4a
PR-URL: #23967
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins added land-on-v8.x labels Nov 27, 2018
@codebytere codebytere mentioned this pull request Nov 27, 2018
v10.13.1 proposal #24675
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@Trott @rvagg
doc: use Node.js instead of Node
8bb67a1
Per branding guidelines from the Foundation, use Node.js and not Node.

PR-URL: #23967
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@Trott @rvagg
doc: add branding to style guide
c1723c8
PR-URL: #23967
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@Trott @rvagg
doc: use Node.js instead of Node
471bae3
Per branding guidelines from the Foundation, use Node.js and not Node.

PR-URL: #23967
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@Trott @rvagg
doc: add branding to style guide
728e817
PR-URL: #23967
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@Trott @MylesBorins
doc: use Node.js instead of Node
3de7858
Per branding guidelines from the Foundation, use Node.js and not Node.

PR-URL: #23967
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@Trott @MylesBorins
doc: add branding to style guide
10e6681
PR-URL: #23967
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
v10.14.2 proposal #24727
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
v8.14.1 proposal #24832
Merged
This was referenced Dec 18, 2018
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#267
Closed
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#268
Closed
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#269
Closed
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#270
Closed
2018-12-18 Version 8.14.1 'Carbon' (LTS) @MylesBorins prepared by @BethGriggs beevelop/docker-android-nodejs#271
Closed
@tniessen tniessen mentioned this pull request Oct 29, 2019
doc: change node.js to Node.js per guideline nodejs/node-addon-api#579
Merged
@Trott
Trott deleted the node-js branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes
@trivikr trivikr trivikr approved these changes
+4 more reviewers
@devsnek devsnek devsnek left review comments
@fhinkel fhinkel fhinkel approved these changes
@mmarchini mmarchini mmarchini approved these changes
@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

13 participants

@Trott @nodejs-github-bot @richardlau @fhinkel @ZibbyKeaton @jasnell @lpinca @cjihrig @mmarchini @devsnek @vsemozhetbyt @trivikr @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.