GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Simple project messaging. by mikeal · Pull Request #24 · nodejs/node

Conversation

@mikeal

@mikeal mikeal commented Dec 2, 2014

Copy link
Copy Markdown
Contributor

This should put to bed some of the wilder speculation we've seen.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rvagg

rvagg commented Dec 2, 2014

Copy link
Copy Markdown
Member

+1 for putting to bed "Evented I/O for V8 javascript", I've always hated that title
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@max-mapper

max-mapper commented Dec 2, 2014

Copy link
Copy Markdown
Contributor

your commit should be docs: add simple project messaging to readme :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mikeal

mikeal commented Dec 2, 2014

Copy link
Copy Markdown
Contributor Author

how do i alter commit messages after the fact?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TJkrusinski

TJkrusinski commented Dec 2, 2014

Copy link
Copy Markdown

git commit --amend
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mikeal
docs: simple project messaging.
276ca5e
@mikeal

mikeal commented Dec 2, 2014

Copy link
Copy Markdown
Contributor Author

@TJkrusinski thanks! :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TJkrusinski

TJkrusinski commented Dec 2, 2014

Copy link
Copy Markdown

no problem!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@indutny

indutny commented Dec 2, 2014

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mikeal mikeal mentioned this pull request Dec 2, 2014
The relationship to node.js is confusing #3
Closed
@ralphtheninja

ralphtheninja commented Dec 2, 2014

Copy link
Copy Markdown

@mikeal Are you working on the governance section in https://github.com/mikeal/io.js/blob/readme-messaging/CONTRIBUTING.md#governance ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mikeal

mikeal commented Dec 2, 2014

Copy link
Copy Markdown
Contributor Author

@ralphtheninja wrong branch :) https://github.com/mikeal/io.js/blob/contribution-policy/CONTRIBUTING.md#governance
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ralphtheninja

ralphtheninja commented Dec 2, 2014

Copy link
Copy Markdown

👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
KyleAMathews
KyleAMathews reviewed Dec 2, 2014
View reviewed changes
Comment thread README.md

@KyleAMathews KyleAMathews Dec 2, 2014

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph is a bit awkward.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@kevinohara80 kevinohara80 Dec 3, 2014

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I think it's supposed to say io.js is under the "open governance model" but it reads like node.js is. Not trying to be nitpicky. This is a pretty important paragraph.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@rvagg rvagg Dec 3, 2014

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinohara80 +1, would you or @KyleAMathews mind putting in a PR to clarify this?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@kevinohara80 kevinohara80 Dec 3, 2014

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing that now

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@kevinohara80 kevinohara80 Dec 3, 2014

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #36

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mikeal added a commit that referenced this pull request Dec 2, 2014
@mikeal @indutny
docs: simple project messaging.
51514c8 
Reviewed-By: Fedor Indutny <[email protected]>
PR-URL: #24
@indutny

indutny commented Dec 2, 2014

Copy link
Copy Markdown
Member

Landed in 51514c8! Thank you.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@indutny indutny closed this Dec 2, 2014
@Fishrock123 Fishrock123 mentioned this pull request Dec 3, 2014
Wording & project description nodejs/iojs.org#2
Closed
kevinohara80 added a commit to kevinohara80/io.js that referenced this pull request Dec 10, 2014
@kevinohara80
docs: reword project messaging
0ac6796 
rewords project messaging in README to make the overall
project messaging a bit clearer. More discussion to be
found in nodejs#24
bnoordhuis pushed a commit that referenced this pull request Dec 10, 2014
@kevinohara80 @bnoordhuis
docs: reword project messaging
6f1d0a8 
Rewords project messaging in README to make the overall project
messaging a bit clearer. More discussion to be found in #24.

PR-URL: #36
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
@jianpingw jianpingw mentioned this pull request Dec 13, 2015
node js 5.2.0 segmentation fault after console.log #4261
Closed
@rupamkhaitan rupamkhaitan mentioned this pull request Jun 27, 2016
trap invalid opcode ip:fea6f9 #3898
Closed
@sclinede sclinede mentioned this pull request Sep 6, 2017
Intl.NumberFormat changed behavior (possibly after ICU 58 -> 59 bump) #15223
Closed
@spurreiter spurreiter mentioned this pull request Jun 4, 2018
fs.createWriteStream does not fire close event #21122
Closed
@cornopaez cornopaez mentioned this pull request Sep 28, 2018
Tricky issue with Require() #23144
Closed
@arxeiss arxeiss mentioned this pull request Aug 16, 2019
path.isAbsolute return false for ~ on Ubuntu #29164
Closed
@dewaynesmith3711 dewaynesmith3711 mentioned this pull request May 14, 2022
[Snyk] Security upgrade ansi-regex from 2.1.1 to 4.1.1 dewaynesmith3711/node#12
Open
@snyk-bot snyk-bot mentioned this pull request Jun 11, 2022
[Snyk] Upgrade tempy from 0.5.0 to 0.7.1 violethaze74-jazzededtech/node#5
Open
@snyk-bot snyk-bot mentioned this pull request Jul 21, 2022
[Snyk] Upgrade tempy from 0.5.0 to 0.7.1 MrBrain295/node#4
Open
@snyk-bot snyk-bot mentioned this pull request Sep 12, 2022
[Snyk] Upgrade tempy from 0.5.0 to 0.7.1 ambai/node#8
Open
@tniessen tniessen mentioned this pull request Sep 12, 2022
Test runner swallows uncaughtException #44612
Closed
@theanarkh theanarkh mentioned this pull request Oct 18, 2022
crash when trace ic stats #45052
Closed
@snyk-bot snyk-bot mentioned this pull request Jan 20, 2023
[Snyk] Upgrade tempy from 0.5.0 to 3.0.0 Supermajestcd/node#5
Open
@ashly1111111 ashly1111111 mentioned this pull request Feb 2, 2023
[Snyk] Upgrade tempy from 0.5.0 to 0.7.1 ashly1111111/node#4
Open
@Michaela813 Michaela813 mentioned this pull request Feb 3, 2023
[Snyk] Upgrade tempy from 0.5.0 to 0.7.1 Michaela813/node#5
Open
@SanchitMahajan236 SanchitMahajan236 mentioned this pull request Feb 17, 2023
[Snyk] Upgrade tempy from 0.5.0 to 0.7.1 SanchitMahajan236/node#5
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 3, 2023
[Snyk] Upgrade tempy from 0.5.0 to 0.7.1 buzzlightyear726/node#5
Open
@davidmather davidmather mentioned this pull request Mar 15, 2023
[Snyk] Upgrade tempy from 0.5.0 to 0.7.1 davidmather/node#5
Open
@Bank4500 Bank4500 mentioned this pull request Mar 22, 2023
[Snyk] Upgrade tempy from 0.5.0 to 0.7.1 Bank4500/nodejs#4
Open
@leonardoadame leonardoadame mentioned this pull request May 3, 2023
[Snyk] Upgrade tempy from 0.5.0 to 0.7.1 leonardoadame/node#7
Merged
@snyk-bot snyk-bot mentioned this pull request May 30, 2023
[Snyk] Upgrade tempy from 0.5.0 to 0.7.1 jefeaguila/node#4
Open
@Renukaloch Renukaloch mentioned this pull request Aug 1, 2023
[Snyk] Upgrade tempy from 0.5.0 to 0.7.1 Renukaloch/node#9
Open
@pranathi-nallamilli pranathi-nallamilli mentioned this pull request Aug 4, 2023
[Snyk] Upgrade tempy from 0.5.0 to 0.7.1 pranathi-nallamilli/node#3
Open
@JCsomeShots JCsomeShots mentioned this pull request Sep 20, 2023
[Snyk] Upgrade tempy from 0.5.0 to 0.7.1 JCsomeShots/node#5
Open
@maverick3312 maverick3312 mentioned this pull request Sep 28, 2023
[Snyk] Upgrade tempy from 0.5.0 to 3.1.0 maverick3312/node#4
Open
@Alexey0312 Alexey0312 mentioned this pull request Sep 29, 2023
[Snyk] Upgrade tempy from 0.5.0 to 0.7.1 Alexey0312/node#3
Open
@CharliesAngel1 CharliesAngel1 mentioned this pull request Oct 15, 2023
[Snyk] Upgrade tempy from 0.5.0 to 0.7.1 CharliesAngel1/node#3
Open
@AliceSof AliceSof mentioned this pull request Nov 14, 2023
[Snyk] Upgrade tempy from 0.5.0 to 0.7.1 AliceSof/node#4
Open
@B020239 B020239 mentioned this pull request Mar 9, 2024
[Snyk] Upgrade p-timeout from 3.2.0 to 6.1.2 B020239/node#6
Open
@ronking-zhu ronking-zhu mentioned this pull request Oct 13, 2025
Nodejs official released build has conflict with msodbcsql driver due to incompatible openssl version #60240
Closed
mcollina added a commit to mcollina/node that referenced this pull request Mar 16, 2026
@mcollina
vfs: address code review feedback from @jasnell
9e8479b 
- Use undefined instead of null for lazy-loaded SEAProvider
- Add validateBoolean for moduleHooks and virtualCwd options
- Use template literal for path concatenation
- Convert VirtualReadStream to use private class fields
- Cache DateNow() result in MemoryEntry constructor

Addresses review comments nodejs#18, nodejs#19, nodejs#21, nodejs#23, nodejs#24, nodejs#29.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@mikeal @rvagg @max-mapper @TJkrusinski @indutny @ralphtheninja @KyleAMathews @kevinohara80
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.