GeezerVison

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/262/

Is the Benchmark CI result acceptable ? 🤔

BTW, didn't understand why we use function

var encode = QueryString.escape;

instead of

var encode = qsEscape;

BTW, didn't understand why we use function

var encode = QueryString.escape;

instead of

var encode = qsEscape;

The reason is that we allow users to override the escape function.

Is the Benchmark CI result acceptable ?

I suppose so.

@nodejs/url This doesn't technically need another review, but it would be nice.

CI: https://ci.nodejs.org/job/node-test-pull-request/18695/

Landed in db9a745