GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: check minimum ICU in configure for system-icu by srl295 · Pull Request #24255 · nodejs/node

Conversation

@srl295

@srl295 srl295 commented Nov 8, 2018

Copy link
Copy Markdown
Member
  • check the version number coming out of pkg-config

Fixes: #24253

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@srl295 srl295 added the i18n-api Issues and PRs related to Node.js internationalization support. label Nov 8, 2018
@srl295 srl295 self-assigned this Nov 8, 2018
@srl295
srl295 requested review from bnoordhuis, devsnek and refack November 8, 2018 18:51
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to Node.js builds or CI infrastructure. label Nov 8, 2018
@nodejs-github-bot

nodejs-github-bot commented Nov 8, 2018

Copy link
Copy Markdown
Collaborator

@srl295 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1545/pipeline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srl295

srl295 commented Nov 8, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

else you get this:

root@4f4928358b09:/src/node# ./configure --with-intl=system-icu
ERROR: icu4c v60.2 is too old, v99.x or later is required.

also updates config.gypi, which wasn't set before. (icu_system_version is new here. icu_ver_major was set by the 'icu generic.gyp' code path, but not by system-icu previously)

                 'icu_system_version': '60.2',
                 'icu_ver_major': '60',
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
srl295
srl295 commented Nov 8, 2018
View reviewed changes
Comment thread configure.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
srl295
srl295 commented Nov 8, 2018
View reviewed changes
Comment thread configure.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
devsnek
devsnek approved these changes Nov 8, 2018
View reviewed changes
bnoordhuis
bnoordhuis reviewed Nov 8, 2018
View reviewed changes

@bnoordhuis bnoordhuis left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If nothing uses/is going to use icu_system_version, can you remove it?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread configure.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread configure.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@srl295

srl295 commented Nov 8, 2018

Copy link
Copy Markdown
Member Author

@bnoordhuis I'll remove icu_system_version but keep icu_ver_major for consistency with the other path.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srl295

srl295 commented Nov 8, 2018

Copy link
Copy Markdown
Member Author

@bnoordhuis thanks. I think I addressed your comments.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
refack
refack approved these changes Nov 8, 2018
View reviewed changes
bnoordhuis
bnoordhuis approved these changes Nov 9, 2018
View reviewed changes

@bnoordhuis bnoordhuis left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread configure.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Nov 10, 2018
View reviewed changes
@Trott

Trott commented Nov 16, 2018

Copy link
Copy Markdown
Member

@srl295 Looks like there's one nit from @bnoordhuis and a CI run and otherwise this is landable? Does that seem right to you?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@refack
refack force-pushed the check-version-system-icu branch from 6695e84 to 2d0d9ce Compare November 16, 2018 22:38
@refack

refack commented Nov 16, 2018

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/18690/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@refack
refack force-pushed the check-version-system-icu branch from 2d0d9ce to 5c47c2b Compare November 16, 2018 22:45
@refack

refack commented Nov 16, 2018

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/18691/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 17, 2018
@srl295 @refack
build: check minimum ICU in configure for system-icu
ed1c40e 
- check the version number coming out of pkg-config

PR-URL: nodejs#24255
Fixes: nodejs#24253
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@refack
refack force-pushed the check-version-system-icu branch from 5c47c2b to ed1c40e Compare November 17, 2018 04:17
@refack refack removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 17, 2018
@refack
refack merged commit ed1c40e into nodejs:master Nov 17, 2018
targos pushed a commit that referenced this pull request Nov 18, 2018
@srl295 @targos
build: check minimum ICU in configure for system-icu
c63243e 
- check the version number coming out of pkg-config

PR-URL: #24255
Fixes: #24253
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@parthitce parthitce mentioned this pull request Nov 21, 2018
chromium-x11 / 70.0.3538.102 compile error OSSystems/meta-browser#195
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@srl295 @rvagg
build: check minimum ICU in configure for system-icu
4dc1e78 
- check the version number coming out of pkg-config

PR-URL: #24255
Fixes: #24253
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
codebytere pushed a commit that referenced this pull request Jan 12, 2019
@srl295 @codebytere
build: check minimum ICU in configure for system-icu
c0f0d19 
- check the version number coming out of pkg-config

PR-URL: #24255
Fixes: #24253
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
v10.15.1 proposal #25346
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@srl295 @codebytere
build: check minimum ICU in configure for system-icu
5d2dadc 
- check the version number coming out of pkg-config

PR-URL: #24255
Fixes: #24253
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Jan 29, 2019
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#280
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#258
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#281
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#259
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#282
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#260
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#283
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#261
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-android-nodejs#284
Closed
2019-01-29 Version 10.15.1 'Dubnium' (LTS) @codebytere beevelop/docker-nodejs#262
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
@jasnell jasnell jasnell approved these changes
+2 more reviewers
@refack refack refack approved these changes
@devsnek devsnek devsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@srl295 srl295

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. i18n-api Issues and PRs related to Node.js internationalization support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@srl295 @nodejs-github-bot @Trott @refack @bnoordhuis @jasnell @devsnek
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.